http://bugs.winehq.org/show_bug.cgi?id=28232
Summary: Keyboard not working in "Hype - The Time Quest" Product: Wine Version: unspecified Platform: x86 URL: http://www.megagames.com/download/hypedemo.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-dinput AssignedTo: wine-bugs@winehq.org ReportedBy: cvoeten@gmail.com
This is a very ancient game (1999), that up until now has not worked (bug #22434). Now that I have gotten it to launch, I've come to notice that the keyboard is not working. This happens in both the full version and in the demo which can be downloaded here: http://www.megagames.com/download/hypedemo.exe (it's a self-extracting zip archive, just extract the files somewhere, then run setup.exe, ignore the errors, the game executable is MaiD3Dvr_bleu.exe).
Since I /believe/ the game uses dinput, I've attached a WINEDEBUG=+dinput trace. (and I did press the down button a few times after starting the game, which did not move the menu selection down (that's the problem)). To my untrained eye it looks like the keyboard events are received, but are somehow not being fed to the application?
Installing MS DirectX (yes, full DirectX) via winetricks does not help.
http://bugs.winehq.org/show_bug.cgi?id=28232
Cesko Voeten cvoeten@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=28232
Andrew Millington andrew.millington@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.millington@gmail.com
--- Comment #1 from Andrew Millington andrew.millington@gmail.com 2011-08-30 04:39:08 CDT --- Works with native dinput and http://bugs.winehq.org/attachment.cgi?id=35873
fixme:keyboard:X11DRV_MapVirtualKeyEx keyboard layout (nil) is not supported fixme:key:X11DRV_ToUnicodeEx keyboard layout (nil) is not supported
The above is printed in the terminal when you press some buttons, the mouse is not functional in-game and some keys do not work.
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #2 from Andrew Millington andrew.millington@gmail.com 2011-08-30 04:49:13 CDT --- I haven't got a Windows box to test if you can play using the mouse but it works perfectly in a non virtual desktop environment.
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #3 from Cesko Voeten cvoeten@gmail.com 2011-08-30 10:45:24 CDT --- Thanks! You're right - using native dinput.dll combined with that patch solves the problem. (The game doesn't use the mouse so the mouse is irrelevant, btw.)
Should I keep this bug open, as, even though the game works now, it appears that there still is a deficiency in wine's dinput implementation (we do need MS dinput.dll, after all)?
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #4 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2011-08-31 20:10:52 CDT --- Duplicate of bug 20395 then if it's uses raw input.
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #5 from Cesko Voeten cvoeten@gmail.com 2011-09-01 01:54:58 CDT --- Created an attachment (id=36194) --> (http://bugs.winehq.org/attachment.cgi?id=36194) console log with WINEDEBUG=dinput
Hm, I now see I've forgotten to actually attach the console log. My apologies.
The log doesn't make any mention of raw input, but since the patch from that bug does fix the problem when coupled with native ddraw, it's probably a dupe anyway, right? (not marking this as dup (yet) because I'm not sure about that)
http://bugs.winehq.org/show_bug.cgi?id=28232
Jake Thomas jjunk97411@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jjunk97411@yahoo.com
--- Comment #6 from Jake Thomas jjunk97411@yahoo.com 2011-10-01 22:05:02 CDT --- Please post the patch command. I.e., what parameters do I pass on to the patch program in terminal?
Cheers, Jake
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #7 from Cesko Voeten cvoeten@gmail.com 2011-10-02 01:47:18 CDT --- You no longer need the patch as of a few days ago (I forgot to add that to this bug when I first noticed it, I apologize for that). You still need native dinput though.
(This is assuming you run the git version of Wine though)
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #8 from Jake Thomas jthomas97411@yahoo.com 2011-10-02 15:19:38 CDT --- That's so awesome! //007! Confirmed! I got it working too. : ) :
The following makes it go swimmingly: NT 4.0 mode dinput override Uncheck "Microsoft Direct X" software test in installer
I submitted an AppDB test result and it didn't go through. I'll try without HTML pictures embedded. That might be what made it not got through.
Cheers, Jake
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #9 from Jake Thomas jthomas97411@yahoo.com 2011-10-02 22:46:42 CDT --- Still doesn't take keyboard input in the Demo, however. Tried with dinput override, but not with the patch. And oddly, the installer would not install in NT 4.0 mode, but would in Win95 mode. The not-demo game only plays in NT 4.0, though installs in other modes.
Jake
http://bugs.winehq.org/show_bug.cgi?id=28232
Vitaliy Margolen vitaliy-bugzilla@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |1.3.31
--- Comment #10 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2011-10-30 21:26:42 CDT --- Confirming. Patch sent.
http://bugs.winehq.org/show_bug.cgi?id=28232
Vitaliy Margolen vitaliy-bugzilla@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #11 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2011-10-30 21:26:58 CDT --- Confirming. Patch sent.
http://bugs.winehq.org/show_bug.cgi?id=28232
Vitaliy Margolen vitaliy-bugzilla@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |35016b05130b71e36d3c28ace95 | |6a6a6ca2414f3 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #12 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2011-10-31 19:44:34 CDT --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=28232
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org 2011-11-04 14:15:43 CDT --- Closing bugs fixed in 1.3.32.
http://bugs.winehq.org/show_bug.cgi?id=28232
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #14 from Wylda wylda@volny.cz 2012-05-12 12:15:48 CDT ---
Why this was closed as fixed? When trying to play the demo, keyboar does not work. The only way how to make keyboard working is dinput=native.
All the following versions need dinput.dll to make keyboard work: * wine-1.3.31 * wine-1.3.32 * wine-1.5.4
Can anybody confirm the dinput.dll?
http://bugs.winehq.org/show_bug.cgi?id=28232
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |
--- Comment #15 from Austin English austinenglish@gmail.com 2012-05-13 20:36:26 CDT --- (In reply to comment #14)
Why this was closed as fixed? When trying to play the demo, keyboar does not work. The only way how to make keyboard working is dinput=native.
All the following versions need dinput.dll to make keyboard work:
- wine-1.3.31
- wine-1.3.32
- wine-1.5.4
Can anybody confirm the dinput.dll?
The download link is dead, so I can't, but I can reopen :).
http://bugs.winehq.org/show_bug.cgi?id=28232
Cesko Voeten cvoeten@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |aric@codeweavers.com Regression SHA1| |8830470a8c248546075ee32bf00 | |e6ba9d096b5be
--- Comment #16 from Cesko Voeten cvoeten@gmail.com 2012-07-30 04:55:54 CDT --- Hi,
As mentioned in previous comments, the keyboard functionality in Hype - The Time Quest has regressed. In fact, on current HEAD the keyboard doesn't work at all even with *dinput=native.
I've run a git bisect between 1.3.29 and HEAD which turns up the following bad commit:
8830470a8c248546075ee32bf00e6ba9d096b5be is the first bad commit commit 8830470a8c248546075ee32bf00e6ba9d096b5be Author: Aric Stewart aric@codeweavers.com Date: Fri Mar 30 20:08:45 2012 -0500
quartz: Have the VideoRenderer use strmbase BaseWindow.
:040000 040000 019588c74722acabbe36f65f3844aeb9f59639b5 2c50dccdae3d4c061d1db0a4176c6cd057b774a1 M dlls
This seems odd to me as I don't see how a change in quartz could affect dinput. However, I am not a programmer, so I don't know what I'm talking about. I've tried going back to HEAD and reverting the commit (with the intent of verifying that this really is the bad commit), but 32 out of 33 hunks fail to revert and I don't know how to deal with that.
I'm adding Aric to the CC list of this bug as per regression testing policy.
If anyone more knowledgeable than me can write a reverse patch of this commit that applies to HEAD, or if you have any other ideas, I will of course be happy to test.
http://bugs.winehq.org/show_bug.cgi?id=28232
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.megagames.com/do |http://megagames.com/downlo |wnload/hypedemo.exe |ad/254607/0 CC| |dank@kegel.com
--- Comment #17 from Dan Kegel dank@kegel.com 2012-07-30 08:28:54 CDT --- Updated download URL. sha1sum of hypedemo.exe from new url is 4053182d4452af2efd8ebf33343329b847091f53 Does that match the old one?
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #18 from Cesko Voeten cvoeten@gmail.com 2012-07-30 08:41:24 CDT --- I'm not sure as I never downloaded the demo before since I own the full version, but it looks like that's the right file. I've just downloaded and installed it (be sure to set windows version to win98 to keep the installer from chickening out) into a clean wineprefix and it's the game all right.
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #19 from Cesko Voeten cvoeten@gmail.com 2012-08-01 05:31:58 CDT --- Update: it's definitely the quartz commit I mentioned in comment #16 that broke the keyboard functionality. When I go to that commit and build Wine, the keyboard breaks; when I do 'git show 8830470a8c248546075ee32bf00e6ba9d096b5be | patch -p1 -R' and rebuild Wine, it works. Furthermore, the game works on current HEAD when you use native quartz and dinput.
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #20 from Lucas Fialho Zawacki lfzawacki@yahoo.com.br 2012-08-18 15:47:17 CDT --- Created attachment 41409 --> http://bugs.winehq.org/attachment.cgi?id=41409 Return a valid value in DIDEVCAPS dwDevType
This patch solves this problem and is the same I posted at bug #21159. I'm pretty sure these two are duplicates.
http://bugs.winehq.org/show_bug.cgi?id=28232
--- Comment #21 from Andrew Millington andrew.millington@gmail.com 2012-08-21 05:18:19 CDT --- Works with wine-1.5.11-60-gd5cec3b using the builtin dinput.dll.
http://bugs.winehq.org/show_bug.cgi?id=28232
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |00cpxxx@gmail.com Resolution| |DUPLICATE
--- Comment #22 from Bruno Jesus 00cpxxx@gmail.com 2012-08-21 07:28:57 CDT --- After testing this bug and bug 21159 I agree with Lucas that they are duplicates based on the input methods used by both games and in the fact that both are fixed with the same patch (besides both of them are from Ubisoft and from the same year as stated by Lucas).
*** This bug has been marked as a duplicate of bug 21159 ***
http://bugs.winehq.org/show_bug.cgi?id=28232
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #23 from Austin English austinenglish@gmail.com 2012-08-21 17:51:35 CDT --- Closing.