http://bugs.winehq.org/show_bug.cgi?id=28465
Summary: shlwapi/path.c test crashes if CFLAGS="-fstack-protector-all" is used Product: Wine Version: 1.3.28 Platform: x86 URL: http://wiki.debian.org/Hardening OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: enhancement Priority: P2 Component: shlwapi AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Created an attachment (id=36503) --> (http://bugs.winehq.org/attachment.cgi?id=36503) backtraces
make test passes for me fine if I use -fstack-protector, but if I use fstack-protector-all, some tests fail. Next up, shlwapi/path.c:
austin@aw25 ~/wine-git/dlls/shlwapi/tests $ make path.ok ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so path.c && touch path.ok *** stack smashing detected ***: shlwapi_test.exe.so terminated ======= Backtrace: ========= /lib/libc.so.6(__fortify_fail+0x50)[0x68278a50] /lib/libc.so.6(+0xe39fa)[0x682789fa] /home/austin/wine-git/dlls/shlwapi/shlwapi.dll.so(+0x50404)[0x6858f404] /home/austin/wine-git/dlls/shlwapi/shlwapi.dll.so(+0x35d82)[0x68574d82] /home/austin/wine-git/dlls/shlwapi/shlwapi.dll.so(PathCombineA+0x103)[0x68574fa3] /home/austin/.wine/dosdevices/z:/home/austin/wine-git/dlls/shlwapi/tests/shlwapi_test.exe.so(+0x2a41d)[0x6851841d] /home/austin/.wine/dosdevices/z:/home/austin/wine-git/dlls/shlwapi/tests/shlwapi_test.exe.so(func_path+0x754)[0x6851d4a4] /home/austin/.wine/dosdevices/z:/home/austin/wine-git/dlls/shlwapi/tests/shlwapi_test.exe.so(+0x3d9ac)[0x6852b9ac] /home/austin/.wine/dosdevices/z:/home/austin/wine-git/dlls/shlwapi/tests/shlwapi_test.exe.so(main+0x162)[0x6852bbc2] /home/austin/.wine/dosdevices/z:/home/austin/wine-git/dlls/shlwapi/tests/shlwapi_test.exe.so(+0x3e8cc)[0x6852c8cc] /home/austin/wine-git/dlls/kernel32/kernel32.dll.so[0x7b85f91c] /home/austin/wine-git/dlls/kernel32/kernel32.dll.so[0x7b86361a] /home/austin/wine-git/dlls/ntdll/ntdll.dll.so[0x7bc77df8] /home/austin/wine-git/dlls/ntdll/ntdll.dll.so[0x7bc78061] /home/austin/wine-git/dlls/ntdll/ntdll.dll.so[0x7bc4ecd9] /home/austin/wine-git/libs/wine/libwine.so.1(+0x984d)[0x6802884d]
Disabling the tests: /* try a directory longer than MAX_PATH */ /* pszPath is too long */
allows it to pass.
testing this when I noticed that Debian is planning to harden packages by default: http://wiki.debian.org/Hardening http://lists.debian.org/debian-devel/2011/09/msg00054.html
http://bugs.winehq.org/show_bug.cgi?id=28465
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #1 from Dan Kegel dank@kegel.com 2011-10-20 07:33:52 CDT --- I just ran into this with Valgrind, I think!
Conditional jump or move depends on uninitialised value(s) at strlenW (unicode.h:200) by PathCombineW (path.c:211) by PathCombineA (path.c:153) by test_PathCombineA (path.c:624) by func_path (path.c:1389) by run_test (test.h:556) by main (test.h:624) Uninitialised value was created by a stack allocation at PathCombineA (path.c:133)
https://bugs.winehq.org/show_bug.cgi?id=28465
--- Comment #2 from Austin English austinenglish@gmail.com --- Still in wine-1.7.12-213-gb0b6728
https://bugs.winehq.org/show_bug.cgi?id=28465
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #36503|0 |1 is obsolete| |
--- Comment #3 from Austin English austinenglish@gmail.com --- Created attachment 47582 --> https://bugs.winehq.org/attachment.cgi?id=47582 output
https://bugs.winehq.org/show_bug.cgi?id=28465
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f26874c523e56c59fd23f002e0d | |7cae9c4ab840c Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #4 from Austin English austinenglish@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/f26874c523e56c59fd23f002e0..., thanks Christoph!
https://bugs.winehq.org/show_bug.cgi?id=28465
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.22.
-
wine-bugs＠winehq.org