[Bug 35006] New: Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

Bug #: 35006
           Summary: Foxit Reader 6.xx crashes on opening Help->About
           Product: Wine
           Version: 1.7.7
          Platform: x86
               URL: http://www.foxitsoftware.com/downloads/
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: gdiplus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: f5d807b7d7f284e2037397007c73e5d73f77138f

Created attachment 46651
  --> http://bugs.winehq.org/attachment.cgi?id=46651
winedbg backtrace

Steps to reproduce the problem:
1. create a new wineprefix, perform 'winetricks mfc42'
2. install FoxitReader611.1031_enu_Setup.exe, you don't have to install Google
Chrome when the installer asks for it.
3. start the application, when it is fully loaded click on <Help> -> <About
Foxit Reader>...the application crashes.

This is a regression from Wine 1.7.7:
f5d807b7d7f284e2037397007c73e5d73f77138f is the first bad commit
commit f5d807b7d7f284e2037397007c73e5d73f77138f
Author: Dmitry Timoshkov 
Date:   Tue Nov 12 18:16:28 2013 +0900

gdiplus: Get rid of no longer needed path and region fields.

:040000 040000 558b0ce1cfc436a7db217c9a03fab0f51d4d373f
99e0d47084a781c7f8a0763dced1692b25d104bb M    dlls

Reverting the patch on wine-1.7.7-69-geb446e8 fixes the crash. Native
gdiplus.dll also works around the crash.

Fedora 19
wine-1.7.7-69-geb446e8

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #1 from GyB  2013-11-27 00:20:29 CST ---
Created attachment 46652
  --> http://bugs.winehq.org/attachment.cgi?id=46652
+gdiplus log

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #2 from Dmitry Timoshkov  2013-11-27 01:17:24 CST ---
(In reply to comment #0)
> This is a regression from Wine 1.7.7:
> f5d807b7d7f284e2037397007c73e5d73f77138f is the first bad commit
> commit f5d807b7d7f284e2037397007c73e5d73f77138f
> Author: Dmitry Timoshkov 
> Date:   Tue Nov 12 18:16:28 2013 +0900
> gdiplus: Get rid of no longer needed path and region fields.

I'd expect this patch be really a NOP, did you try to revert it?

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Ken Thomases  2013-11-27 01:26:28 CST ---
(In reply to comment #2)
> I'd expect this patch be really a NOP, did you try to revert it?

He said he did in the original post: "Reverting the patch on
wine-1.7.7-69-geb446e8 fixes the crash."

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #4 from Dmitry Timoshkov  2013-11-27 01:39:01 CST ---
(In reply to comment #3)
> > I'd expect this patch be really a NOP, did you try to revert it?
>
> He said he did in the original post: "Reverting the patch on
> wine-1.7.7-69-geb446e8 fixes the crash."

Yes, I saw it, just wanted to double check.

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #5 from Dmitry Timoshkov  2013-11-27 22:03:34 CST ---
Created attachment 46658
  --> http://bugs.winehq.org/attachment.cgi?id=46658
gdiplus: Avoid deleting clip region twice in GdipDeleteGraphics

It's a bug in application, it calls GdipDeleteGraphics twice. I don't know how
it worked before, probably due to slightly different memory layout. Attached
patch should avoid the crash.

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #6 from GyB  2013-11-28 01:35:19 CST ---
(In reply to comment #5)
> Created attachment 46658 [details]
> gdiplus: Avoid deleting clip region twice in GdipDeleteGraphics
>
> It's a bug in application, it calls GdipDeleteGraphics twice. I don't know how
> it worked before, probably due to slightly different memory layout. Attached
> patch should avoid the crash.

The patch works here as well..

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #7 from Vincent Povirk  2013-12-09 14:31:10 CST ---
We should probably test whether deleting a Graphics object twice reports
failure on Windows, and detect that if so.

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #8 from Vincent Povirk  2013-12-09 14:40:58 CST ---
Although probably such a test cannot be added to Wine because it would involve
accessing freed memory.

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

--- Comment #9 from Vincent Povirk  ---
Created attachment 47091
  --> http://bugs.winehq.org/attachment.cgi?id=47091
test program (C source)

Testing on Windows, the second free gives a error of ObjectBusy.

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

http://bugs.winehq.org/show_bug.cgi?id=35006

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |51b873b3ca03074698ab027f503
                   |                            |acd7c1940ad80
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Dmitry Timoshkov  ---
Should be fixed by 51b873b3ca03074698ab027f503acd7c1940ad80.

Thanks Vincent.

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

https://bugs.winehq.org/show_bug.cgi?id=35006

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.11.

[Bug 35006] Foxit Reader 6.xx crashes on opening Help->About

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=35006

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|http://www.foxitsoftware.co |https://web.archive.org/web
                   |m/downloads/                |/20131206071907/http://cdn0
                   |                            |1.foxitsoftware.com/pub/fox
                   |                            |it/reader/desktop/win/6.x/6
                   |                            |.1/enu/FoxitReader611.1031_
                   |                            |enu_Setup.exe