[Bug 25908] New: Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Summary: Crash in winmerge when unfocusing edit field
           Product: Wine
           Version: 1.3.12
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

1) Need to install winmerge http://winmerge.org/downloads/ . I'm using 2.12.4.0
Unicode

2) Open WinMerge and select two folders to compare

3) In the file list view, click once on a file name to select, and again to
edit the file name inline.

4) Click outside the file name editable field -> Crash.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

--- Comment #1 from joao.eiras  2011-01-27 23:37:13 CST ---
Created an attachment (id=33021)
 --> (http://bugs.winehq.org/attachment.cgi?id=33021)
wine log

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33021|application/octet-stream    |text/plain
          mime type|                            |

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

--- Comment #2 from Andrew Nguyen  2011-01-28 00:45:22 CST ---
Please attach a new log without WINEDEBUG flags and with debug symbols
installed.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

--- Comment #3 from joao.eiras  2011-01-28 05:54:05 CST ---
Created an attachment (id=33024)
 --> (http://bugs.winehq.org/attachment.cgi?id=33024)
wine log (with debug symbols)

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33024|application/octet-stream    |text/plain
          mime type|                            |

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

--- Comment #4 from Dmitry Timoshkov  2011-01-28 06:18:50 CST ---
Does installing native comctl32 with winetricks help?

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

--- Comment #5 from joao.eiras  2011-01-28 19:36:45 CST ---
Yes, the crash is gone.

However, it triggers a different bug. When the file name is clicked to be
edited, the input field that shows up is empty. And all icons in the file list
get a black background, instead of a transparent one.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comctl32

--- Comment #6 from Nikolay Sivov  2011-01-29 01:42:28 CST ---
(In reply to comment #5)
> Yes, the crash is gone.

Good. Please attach +listview,+tid log with builtin comctl32.
> However, it triggers a different bug. When the file name is clicked to be
> edited, the input field that shows up is empty.

It's possible to deal with it later, it's a minor thing if comctl32 problem is
solved.
> And all icons in the file list
> get a black background, instead of a transparent one.

It's a known difference.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

joao.eiras  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33021|0                           |1
        is obsolete|                            |
  Attachment #33024|0                           |1
        is obsolete|                            |

--- Comment #7 from joao.eiras  2011-01-30 22:36:53 CST ---
Created an attachment (id=33069)
 --> (http://bugs.winehq.org/attachment.cgi?id=33069)
WINEDEBUG=+listview,+tid log

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

joao.eiras  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33069|text/plain                  |application/x-gzip
          mime type|                            |

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Nikolay Sivov  2011-05-08 07:16:23 CDT ---
Yeah, I can see this with current git. Confirming.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #9 from Nikolay Sivov  2011-05-08 09:59:21 CDT ---
The problem is that LVM_GETEDITCONTROL should work from inside LVN_ENDLABELEDIT
notification, but my 2 years old commit
b13cd52b049cacbb1f1176396049c65fd461c079 made this impossible.

I have a patch that fixes that, will send tomorrow.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

--- Comment #10 from Nikolay Sivov  2011-05-08 10:06:24 CDT ---
Created an attachment (id=34545)
 --> (http://bugs.winehq.org/attachment.cgi?id=34545)
patch

Here it is.

P.S. apparently MFC's ASSERT() macro is compiled out for release builds,
otherwise this failure will be caught with it.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Nikolay Sivov  2011-05-09 13:51:33 CDT ---
Fixed with 34d86a2d17464d1e98f92a58491c00e100c005e4.

Please retest to confirm (or wait for next release 1.3.20).

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2011-05-13 13:33:51 CDT ---
Closing bugs fixed in 1.3.20.

[Bug 25908] Crash in winmerge when unfocusing edit field

http://bugs.winehq.org/show_bug.cgi?id=25908

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |34d86a2d17464d1e98f92a58491
                   |                            |c00e100c005e4

[Bug 25908] Crash in winmerge when unfocusing edit field

https://bugs.winehq.org/show_bug.cgi?id=25908

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]