[Bug 33649] New: wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

Bug #: 33649
           Summary: wine-1.5.30 - "./configure --with-gnutls" fails with
                    gnutls-3.2.0 - conftest.c:160:15: error:
                    'gnutls_mac_get_key_size' undeclared
           Product: Wine
           Version: 1.5.30
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Starting with gnutls-3.2.0, wine's ./configure --with-gnutls fails.  This
appears to be due to some header changes from this gnutls commit:
https://gitorious.org/gnutls/gnutls/commit/e0b3dbe3eb60e3a2d59ba0f20560160de...

Relevant config.log lines:

configure:10374: checking for gnutls/gnutls.h
configure:10374: result: yes
configure:10387: x86_64-pc-linux-gnu-gcc -c -O2 -pipe -march=native  
conftest.c >&5
conftest.c: In function 'main':
conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared (first use in
this function)
conftest.c:160:15: note: each undeclared identifier is reported only once for
each function it appears in
configure:10387: $? = 1

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

--- Comment #1 from Ben Kohler  2013-05-24 11:48:51 CDT ---
Created attachment 44541
  --> http://bugs.winehq.org/attachment.cgi?id=44541
wine-gnutls-3.2.0-fix.patch

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

Ben Kohler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://bugs.gentoo.org/sho
                   |                            |w_bug.cgi?id=471077

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

Alexandre Rostovtsev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

--- Comment #2 from Alexandre Rostovtsev  2013-05-25 23:19:36 CDT ---
Created attachment 44559
  --> http://bugs.winehq.org/attachment.cgi?id=44559
alternative patch

I think the intent of AC_LANG_PROGRAM here was to test for linking validity by
making sure that a pointer to the gnutls_mac_get_key_size() function would be
usable at runtime. The patch in comment #1 replaces this test with something
fundamentally different: a test for a type definition that matters only at
compile time.

I therefore think the patch I am attaching would be a better solution.

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

--- Comment #3 from Henri Verbeet  2013-05-28 03:20:43 CDT ---
(In reply to comment #2)
> I therefore think the patch I am attaching would be a better solution.

Looks ok to me, but note that patches are only picked up from wine-patches, not
from bugzilla. And preferably gnutls wouldn't move things around like that, of
course.

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

--- Comment #4 from Alexandre Rostovtsev  2013-06-11 00:10:14 CDT ---
(In reply to comment #3)
> Looks ok to me, but note that patches are only picked up from wine-patches, not
> from bugzilla.

Submitted to wine-patches: http://source.winehq.org/patches/data/96778

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |fee9cd3b243ed4eeb111417a472
                   |                            |831bb364fc2fc
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Austin English  2013-06-11 14:42:12 CDT ---
http://source.winehq.org/git/wine.git/commitdiff/fee9cd3b243ed4eeb111417a472...

Thanks for the patch!

[Bug 33649] wine-1.5.30 - "./configure --with-gnutls" fails with gnutls-3.2.0 - conftest.c:160:15: error: 'gnutls_mac_get_key_size' undeclared

http://bugs.winehq.org/show_bug.cgi?id=33649

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2013-06-14 13:25:24 CDT ---
Closing bugs fixed in 1.6-rc2.