https://bugs.winehq.org/show_bug.cgi?id=38485
Bug ID: 38485 Summary: New Marvel Heroes 2015 Launcher crashes on unimplemented function dhcpcsvc.dll.DhcpRequestParams Product: Wine Version: 1.7.40 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: mellery@gmail.com Distribution: ---
Marvel Heroes 2015 has a new game launcher which crashes on startup in wine with
wine: Call from 0x7b83b6ae to unimplemented function dhcpcsvc.dll.DhcpRequestParams, aborting
Copying the dll from windows gets the launcher a little further and not crash, but it doesn't try to download updates for the game. Also shows this
err:module:import_dll Loading library dhcpcsvc.DLL (which is needed by L"C:\Program Files\Gazillion Entertainment\Marvel Heroes Game\downloader.dll") failed (error c000007b).
https://bugs.winehq.org/show_bug.cgi?id=38485
Mike Ellery mellery@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mellery@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=38485
--- Comment #1 from Mike Ellery mellery@gmail.com --- Created attachment 51565 --> https://bugs.winehq.org/attachment.cgi?id=51565 create stub for dhcpcvc.dll.DhcpRequestParams
https://bugs.winehq.org/show_bug.cgi?id=38485
--- Comment #2 from Mike Ellery mellery@gmail.com --- added patch which allows the launcher to progress
tested with MarvelHeroesLauncher.exe patcher version: CL243408 skin version: 4.0.0.30
shasum MarvelHeroesLauncher.exe 53bad5735eada4c938e733a849b7e9c33c248a27 MarvelHeroesLauncher.exe
https://bugs.winehq.org/show_bug.cgi?id=38485
Mike Ellery mellery@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=38485
Mike Ellery mellery@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://marvelheroes.com/do | |wnload
--- Comment #3 from Mike Ellery mellery@gmail.com --- Adding url for downloading launcher, not launching through steam
https://bugs.winehq.org/show_bug.cgi?id=38485
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #4 from André H. nerv@dawncrow.de --- (In reply to Mike Ellery from comment #1)
Created attachment 51565 [details] create stub for dhcpcvc.dll.DhcpRequestParams
Patch looks nearly good. Some minor cleanup and you can send it to the wine-patches mailing list where patches are picked up from.
Minor cleanup suggestions: whitespace cleanup, one thing is e.g. space after commas further we try to avoid LPVOID, try "void *" as this is a pointer, you need to advertise it as "ptr" in the specfile
https://bugs.winehq.org/show_bug.cgi?id=38485
Mike Ellery mellery@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #51565|0 |1 is obsolete| |
--- Comment #5 from Mike Ellery mellery@gmail.com --- Created attachment 51586 --> https://bugs.winehq.org/attachment.cgi?id=51586 create stub for dhcpcvc.dll.DhcpRequestParams (try 2)
fix whitespace and replace lpvoid with void *
https://bugs.winehq.org/show_bug.cgi?id=38485
--- Comment #6 from Mike Ellery mellery@gmail.com --- Thanks for the feedback, I've attached an update.
There is an existing LPVOID in DllMain that I didn't touch.
Also the Launchers been updated again (now at version CL244391) which doesn't seem to call DhcpRequestParams anymore, so I'm unable to try the patch against anything
https://bugs.winehq.org/show_bug.cgi?id=38485
--- Comment #7 from André H. nerv@dawncrow.de --- (In reply to Mike Ellery from comment #6)
Thanks for the feedback, I've attached an update.
LPDHCPCAPI_CLASSID, DHCPCAPI_PARAMS_ARRAY, DHCPCAPI_PARAMS_ARRAY, LPBYTE, LPDWORD should also be marked as ptr in the specfile We also try to avoid lines longer than 100 characters, i suggest to shorten the parameter names and add line breaks The typedefs you added should maybe go to a new include/dhcpcsdk.h, but maybe it get's accepted this way as you only add a stub We use 4 space indentation, your typedefs don't... You also should use WINAPI instead of APIENTRY
I think it's worth the try sending it to the mailinglist directly after fixing these issues. Thx for the effort
https://bugs.winehq.org/show_bug.cgi?id=38485
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download CC| |austinenglish@gmail.com
--- Comment #8 from Austin English austinenglish@gmail.com --- (In reply to André H. from comment #7)
(In reply to Mike Ellery from comment #6)
Thanks for the feedback, I've attached an update.
LPDHCPCAPI_CLASSID, DHCPCAPI_PARAMS_ARRAY, DHCPCAPI_PARAMS_ARRAY, LPBYTE, LPDWORD should also be marked as ptr in the specfile We also try to avoid lines longer than 100 characters, i suggest to shorten the parameter names and add line breaks The typedefs you added should maybe go to a new include/dhcpcsdk.h, but maybe it get's accepted this way as you only add a stub We use 4 space indentation, your typedefs don't... You also should use WINAPI instead of APIENTRY
I think it's worth the try sending it to the mailinglist directly after fixing these issues. Thx for the effort
I cleaned it up and submitted it: https://source.winehq.org/patches/data/115782
https://bugs.winehq.org/show_bug.cgi?id=38485
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #9 from super_man@post.com --- (In reply to Austin English from comment #8)
(In reply to André H. from comment #7)
(In reply to Mike Ellery from comment #6)
Thanks for the feedback, I've attached an update.
LPDHCPCAPI_CLASSID, DHCPCAPI_PARAMS_ARRAY, DHCPCAPI_PARAMS_ARRAY, LPBYTE, LPDWORD should also be marked as ptr in the specfile We also try to avoid lines longer than 100 characters, i suggest to shorten the parameter names and add line breaks The typedefs you added should maybe go to a new include/dhcpcsdk.h, but maybe it get's accepted this way as you only add a stub We use 4 space indentation, your typedefs don't... You also should use WINAPI instead of APIENTRY
I think it's worth the try sending it to the mailinglist directly after fixing these issues. Thx for the effort
I cleaned it up and submitted it: https://source.winehq.org/patches/data/115782
patching file dlls/dhcpcsvc/dhcpcsvc.c patching file dlls/dhcpcsvc/dhcpcsvc.spec
against 1.9.4-git
https://bugs.winehq.org/show_bug.cgi?id=38485
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #10 from Bruno Jesus 00cpxxx@gmail.com --- Confirming.
https://bugs.winehq.org/show_bug.cgi?id=38485
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #11 from winetest@luukku.com --- Patch applies cleanly against wine 1.9.21. Would be good if someone could review it and submit so it would be merged.
https://bugs.winehq.org/show_bug.cgi?id=38485
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #12 from winetest@luukku.com --- The patch got merged
http://source.winehq.org/git/wine.git/commit/a2ff4f37fd10f95e8ebcd18cbe2fd47...
https://bugs.winehq.org/show_bug.cgi?id=38485
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com Fixed by SHA1| |a2ff4f37fd10f95e8ebcd18cbe2 | |fd477ba18523c Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #13 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Fixed
https://bugs.winehq.org/show_bug.cgi?id=38485
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.2.
https://bugs.winehq.org/show_bug.cgi?id=38485
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.0.x
https://bugs.winehq.org/show_bug.cgi?id=38485
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.0.x |---
--- Comment #15 from Michael Stefaniuc mstefani@winehq.org --- Removing the 2.0.x milestone from bugs included in 2.0.1.