[Bug 18823] New: The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Summary: The Typing of the Dead freezes during intro
           Product: Wine
           Version: 1.1.23
          Platform: PC
               URL: http://downloads.gamezone.com/demos/d2037.htm
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dsound
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=21626)
 --> (http://bugs.winehq.org/attachment.cgi?id=21626)
Terminal output

It's not possible to play The Typing of the Dead with wine-1.1.23 because it
freezes either during the intro video or upon the attempt to skip it.

This bug has something to do with the sound. Switching off all sound drivers in
winecfg acts as a workaround. It's definitely related to Bug 2361 but it's not
a duplicate because the symptoms are different.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Josh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

--- Comment #1 from Torbjörn Söderstedt   2009-08-02 06:18:51 ---
Created an attachment (id=22777)
 --> (http://bugs.winehq.org/attachment.cgi?id=22777)
Fix

DSOUND_PrimarySetFormat will copy the new format before checking if it is
supported. If changing format fails 
without causing DSERR_BUFFERLOST, the buffer will have incorrect settings. I
created a temporary buffer that is used 
by the affected code.

The Typing of the Dead tries to set a format with nBlockAlign=0
(wBitsPerSample=2), leading to a division by zero in 
DSOUND_MixInBuffer.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Austin English   2009-08-02 13:06:10 ---
Please send patches to [e-mail].

BTW, you're mixing tabs and spaces. Please try to stick to the file's original
formatting.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Torbjörn Söderstedt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Torbjörn Söderstedt   2009-08-07 14:35:14 ---
*** This bug has been confirmed by popular vote. ***

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Torbjörn Söderstedt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail].n
                   |                            |et

--- Comment #4 from Torbjörn Söderstedt   2009-08-07 14:45:20 ---
(In reply to comment #2)
> Please send patches to [e-mail].

I did, nothing happened.
> BTW, you're mixing tabs and spaces. Please try to stick to the file's original
> formatting.

The file is already mixed, so I don't know the correct formatting. I provide
the patch as a way to illustrate the cause for this bug. Being very simple in
nature, I trust that you can easily edit it to your liking.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

--- Comment #5 from Josh   2009-08-08 06:06:36 ---
Thanks so much for this fix, Torbjörn. I haven't actually got round to testing
it yet, my Linux partition is a bit messed up right now. But I appreciate the
effort and I'll get round to trying this out as soon possible.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

--- Comment #6 from Josh   2009-08-21 17:32:13 ---
Awesome man, it works! Thanks again. Hope this finds its way into the main
development tree.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Linus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Linus   2009-11-17 15:37:34 ---
Hmm, this patch has not yet been included in the trunk, has it? I tried to
rebase your patch, Torbjörn, but failed as some stuff in the same context has
been added and I don't know how they relate to your patch. Would be great, if
you could check the latest. I also tried the latest git trunk of today and -
hurray! - the PixelFormat issues seem to be solved (again?), which was not the
case a week ago (id=16559).

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

--- Comment #8 from Austin English  2010-10-04 15:54:02 CDT ---
A new patch was committed:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=681d54462017bbca7317f4...

please retest.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

--- Comment #9 from Torbjörn Söderstedt  2010-10-05 08:26:06 CDT ---
I built from commit 79ed8429319509db1ca7723661af5fb4a8017320. The graphics is
mostly upside-down, but I have sound and it doesn't crash so this bug should be
considered fixed.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

--- Comment #10 from [e-mail] 2011-01-22 14:49:34 CST ---
Was unable to reproduce with Wine 1.3.12. Everything works fine.
Suggest closing bug.

And thanks to everyone who worked on this bug, enabling everyone to play a
classing videogame on a Linux system.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Austin English  2011-04-23 14:18:11 CDT ---
Fixed.

[Bug 18823] The Typing of the Dead freezes during intro

http://bugs.winehq.org/show_bug.cgi?id=18823

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2011-04-29 13:15:46 CDT ---
Closing bugs fixed in 1.3.19.