[Bug 26571] New: WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Summary: WoW 4.x D3D: High quality water is broken
           Product: Wine
           Version: 1.3.16
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Since bug 24928 is closed, water quality higher than Fair can be enabled.
However it's completely broken.

Screenshot attached.

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

--- Comment #1 from Jerome Leclanche  2011-03-27 13:53:05 CDT ---
Created an attachment (id=33835)
 --> (http://bugs.winehq.org/attachment.cgi?id=33835)
Screenshot

This spams in Ultra:

err:d3d_surface:surface_blt_fbo >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502)
from glBlitFramebuffer() @ ../../../dlls/wined3d/surface.c / 3410
fixme:d3d_surface:IWineD3DBaseSurfaceImpl_Blt Filter WINED3DTEXF_LINEAR not
supported in software blit.
err:d3d_surface:surface_blt_fbo >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502)
from glBlitFramebuffer() @ ../../../dlls/wined3d/surface.c / 3410
fixme:d3d_surface:IWineD3DBaseSurfaceImpl_Blt Filter WINED3DTEXF_LINEAR not
supported in software blit.
err:d3d_surface:surface_blt_fbo >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502)
from glBlitFramebuffer() @ ../../../dlls/wined3d/surface.c / 3410
fixme:d3d_surface:IWineD3DBaseSurfaceImpl_Blt Filter WINED3DTEXF_LINEAR not
supported in software blit.

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Austin English  2011-04-05 13:18:01 CDT ---
*** Bug 26664 has been marked as a duplicate of this bug. ***

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

paolinidiego  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from paolinidiego  2011-04-06 02:24:57 CDT ---
*** This bug has been confirmed by popular vote. ***

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

--- Comment #4 from Jerome Leclanche  2011-04-19 20:07:36 CDT ---
Still an issue in wine-1.3.18-85-g99f6894

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24928

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Bug 26571 depends on bug 24928, which changed state.

Bug 24928 Summary: WoW 4.x D3D: Water Detail and Sunshafts cannot be enabled fully in d3d9
http://bugs.winehq.org/show_bug.cgi?id=24928

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|FIXED                       |

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Rodd Snook  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #5 from Rodd Snook  2011-12-30 17:53:28 CST ---
Bug 24928 was reopened, since the game has tightened up its graphics support
tests, but I was able to enable these options by using the native nvapi.dll

What I'm seeing now from WINE with default debug flags is the following.

Spamming:
 - fixme:d3d:resource_check_usage Unhandled usage flags 0x8.

When enabling Good/Ultra water or any sunshafts:
 - fixme:d3d_surface:surface_load_ds_location No up to date depth stencil
location.
 - err:d3d_surface:surface_modify_location Surface 0x3555b198 does not have any
up to date location.

Adding CC to Henri Verbeet due to this comment in his patch of 15-APR-2011

+    if (!(surface->flags & SFLAG_DS_LOCATIONS))
     {
+        /* This mostly happens when a depth / stencil is used without being
+         * cleared first. In principle we could upload from sysmem, or
+         * explicitly clear before first usage. For the moment there don't
+         * appear to be a lot of applications depending on this, so a FIXME
+         * should do. */

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

John Porterfield  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Jerome Leclanche  2012-09-12 17:29:46 CDT ---
Looking fixed.

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2012-09-14 13:33:53 CDT ---
Closing bugs fixed in 1.5.13.

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Andrew Mitchell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Andrew Mitchell  2012-09-20 20:18:35 CDT ---
This isn't looking fixed when using the nvidia 304.48 drivers (nvapi.dll
extracted from the windows 304.48 drivers also), with output like:

fixme:d3d:debug_d3dformat Unrecognized 0x5343564e (as fourcc: NVCS)
WINED3DFORMAT!
fixme:d3d:wined3d_get_format Can't find format unrecognized (0x5343564e) in the
format lookup table

Both sunshafts & water are broken with this, with water not showing at all.

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

--- Comment #9 from Rodd Snook  2012-09-20 20:23:20 CDT ---
I'm also seeing no water at Fair or higher with nvidia driver 304.48

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26571] WoW 4.x D3D: High quality water is broken

http://bugs.winehq.org/show_bug.cgi?id=26571

Bug 26571 depends on bug 24928, which changed state.

Bug 24928 Summary: WoW 4.x D3D: Water Detail and Sunshafts cannot be enabled fully in d3d9
http://bugs.winehq.org/show_bug.cgi?id=24928

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |UPSTREAM