[Bug 20898] New: Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

Summary: Rayman 2: wine does not render "transparent color"
           Product: Wine
           Version: 1.1.33
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25045)
 --> (http://bugs.winehq.org/attachment.cgi?id=25045)
Screenshots of the bug

It looks like Wine 1.1.33 do not render transparency in Rayman 2.

It seems to be a regression: it used to work with Wine 1.1.24, but Wine 1.1.25
broke it and no recent version of Wine (including the current last 1.1.33)
fixes that bug.

I attach some screenshots to this report that show the bug: the right side is
1.1.24 with a correct rendering (notice the text and transparent water and
transparent sparks) whereas the left side shows the rendering of version 1.1.25
to 1.1.33 (notice the squares replacing the text and non transparent water and
black shadows and non transparent sparks).

The configuration tool that comes with the game (wine GXSetup.exe) shows the
following information:
 - Renderer: "3 DirectX6 (1.0.0) DirectX 6 Driver"
 - Driver: "DirectDraw HAL (display)"
 - Device: "Wine D3DDevice using WineD3D and OpenGL (Direct3D HAL)"
selecting "RGB Direct3D emulation (Direct3D HEL)" for the Device do not "fix"
the bug.

I also attach the output of wine 1.1.33 when running Rayman2.exe.

Here is my configuration:
 - up to date Ubuntu Karmic Koala 9.10
 - NVidia GeForce FX 5600
 - up to date driver nvidia 173.14.20

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #1 from [e-mail]  2009-12-02 12:06:11 ---
Created an attachment (id=25046)
 --> (http://bugs.winehq.org/attachment.cgi?id=25046)
Log of the output wine 1.1.33: "wine Rayman2.exe"

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #2 from Jeff Zaroyko   2009-12-02 12:42:43 ---
please post the results of your regression test
http://wiki.winehq.org/RegressionTesting

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #3 from [e-mail]  2009-12-03 07:04:16 ---
I have never heard of bisect before. Since this is the first time for me, I ran
the test twice. In both executions, it returns the same commit:

670d9ad90bf5af9bcb2e4c82d37391acbac83210 is first bad commit
commit 670d9ad90bf5af9bcb2e4c82d37391acbac83210
Author: Henri Verbeet 
Date:   Thu Jul 2 10:01:35 2009 +0200

wined3d: Check if formats support blending when attached to an FBO.

Remove the post-pixelshader blending flag if the format doesn't. Note that
the
    patch doesn't enforce this restriction yet, it only adjusts the reported
    format capabilities.

:040000 040000 5aed8354171fbd73747703da5d072e580d03e805
8f711dd83eb0392e114aa9351f4a261e2ffe3fc3 M    dlls

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #4 from Henri Verbeet   2009-12-03 07:30:24 ---
Does this have a demo with the same problem?

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #5 from Henri Verbeet   2009-12-03 07:38:31 ---
Created an attachment (id=25055)
 --> (http://bugs.winehq.org/attachment.cgi?id=25055)
patch

Also, to confirm it's really the removal of this flag that causes the bug, does
applying the attached patch on top of current git fix the game?

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #6 from [e-mail]  2009-12-03 09:51:00 ---
You can find the demo here
http://downloads.ugo.com/downloads/game_demos/action/Rayman_2.shtml

The demo shows the bug with wine 1.1.33.

The demo crashes with last git (with or without the patch).

The full game with last git and the patch is correctly rendered (and no crash
unlike the demo).

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #7 from [e-mail]  2009-12-03 14:10:46 ---
Finally I managed to run the demo with the last git (I have forgotten some dev
files).

So:
 - the demo shows the bug with the last git;
 - the patch fixes the bug for the demo (as it fixes it for the full game).

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #8 from Henri Verbeet   2009-12-07 06:06:48 ---
Created an attachment (id=25100)
 --> (http://bugs.winehq.org/attachment.cgi?id=25100)
demo

This seems to work for me with the demo. Could you attach a +d3d log?

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #9 from [e-mail]  2009-12-07 09:20:18 ---
Created an attachment (id=25103)
 --> (http://bugs.winehq.org/attachment.cgi?id=25103)
output of "WINEDEBUG=+d3d wine Rayman2Demo.exe"

(In reply to comment #8)
> This seems to work for me with the demo.

What graphics card and what driver did you try?
It may only be a bug with the nvidia driver...
> Could you attach a +d3d log?

I've updated my git repository to the last version (should be 1.1.34 now).

I attach the output of "WINEDEBUG=+d3d wine Rayman2Demo.exe" (75Mb
uncompressed!).
I only started the demo, press esc as soon as I get the control of Rayman (with
a black square as a shadow) and then selected the exit item from the menu
(blindly since the menu items are rendered as opaque squares like in the
screenshots I initially attached).

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25055|0                           |1
        is obsolete|                            |

--- Comment #10 from Henri Verbeet   2009-12-07 11:56:03 ---
Created an attachment (id=25105)
 --> (http://bugs.winehq.org/attachment.cgi?id=25105)
patch

How does this patch work?

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #11 from [e-mail]  2009-12-07 15:39:32 ---
This second patch fixes the bug for me in the demo and in the full game.

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #12 from Henri Verbeet   2009-12-09 13:11:55 ---
Should be fixed by bfe6695d30bb0d2cb6a97d83cea66cf417bb144e.

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

--- Comment #13 from [e-mail]  2009-12-09 14:21:40 ---
I have undone the patch and updated my git repository to the last version: the
bug is fixed for me, both for the demo and for the full game.

The only thing that bothers me is that it seems I'm the only one who
experienced that bug...

Anyway, thank you very much!

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Austin English   2009-12-09 15:33:12 ---
Fixed.

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2009-12-18 13:08:01 ---
Closing bugs fixed in 1.1.35.

[Bug 20898] Rayman 2: wine does not render "transparent color"

http://bugs.winehq.org/show_bug.cgi?id=20898

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d