https://bugs.winehq.org/show_bug.cgi?id=56012
Bug ID: 56012 Summary: Regression: FPS drop in wine-9.0-rc1 Product: Wine Version: 9.0-rc1 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: blocker Priority: P2 Component: winex11.drv Assignee: wine-bugs@winehq.org Reporter: h0tc0d3@gmail.com Distribution: ---
In wine 9.0-rc1 FPS does not increase above 55Hz. At the same time, FPS in wine 8 is more than 600Hz, and the game is limited to 240Hz to synchronize with the monitor. At first I thought this was a bug of the new Wayland driver, but research showed that in builds without it the FPS is just as low. Software rendering was also excluded via setting VK_DRIVER_FILES and DXVK_HUD=devinfo,fps. Fsync On with WINEFSYNC=1 env variable.
Logs can be downloaded here: https://bugs.winehq.org/show_bug.cgi?id=55995
https://bugs.winehq.org/show_bug.cgi?id=56012
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|winex11.drv |-unknown Keywords| |regression Severity|blocker |normal
--- Comment #1 from Zeb Figura z.figura12@gmail.com --- DXVK is not supported in this tracker; please test without DXVK or report bugs to the DXVK project. (Yes, I know this is a Wine regression, but that doesn't mean it's not DXVK's bug.)
https://bugs.winehq.org/show_bug.cgi?id=56012
--- Comment #2 from Grigory Vasilyev h0tc0d3@gmail.com --- (In reply to Zeb Figura from comment #1)
DXVK is not supported in this tracker; please test without DXVK or report bugs to the DXVK project. (Yes, I know this is a Wine regression, but that doesn't mean it's not DXVK's bug.)
How can there be a dxvk error if everything works fine in Wine 8? I specifically checked different versions of wine many times, even tried staging patches. This is exactly the regression of wine. Moreover, nothing prevents from analyzing the logs, and if the logs show that the problem is dxvk, then redirect it to them. dxvk is the same everywhere, but wine is not. I even tried deleting the cache.
https://bugs.winehq.org/show_bug.cgi?id=56012
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #3 from Zeb Figura z.figura12@gmail.com --- (In reply to Grigory Vasilyev from comment #2)
How can there be a dxvk error if everything works fine in Wine 8? I specifically checked different versions of wine many times, even tried staging patches. This is exactly the regression of wine.
Because changes in one part of Wine can expose bugs in another part, or in third-party components. In fact many regressions fall into this category.
Moreover, nothing prevents from analyzing the logs, and if the logs show that the problem is dxvk, then redirect it to them.
Well, the major thing that prevents this is that debugging takes time, and that time is extremely scarce to begin with.
If it's truly a Wine bug, it should be reproducible with only builtin Wine components. If not, it's unreasonable to expect Wine developers to waste their time debugging someone else's bug.
This isn't to say that third-party components are absolutely forbidden in this bug tracker, if there's good enough reason for me to believe that the component isn't related. [A bisect may very likely end up being a good enough reason, and would be appreciated regardless.] But when all we have to work with is "FPS is lower", it's hard to be sure it's not DXVK's problem, and critically, it shouldn't be difficult to just test without DXVK.
Somewhat relatedly, I also just now notice you mention fsync. That's not a part of wine or even wine-staging, and could similarly easily be responsible for the problem. Please test with upstream "vanilla" wine, without *any* external patches or components.
https://bugs.winehq.org/show_bug.cgi?id=56012
--- Comment #4 from Grigory Vasilyev h0tc0d3@gmail.com --- (In reply to Zeb Figura from comment #3)
Please test with upstream "vanilla" wine, without *any* external patches or components.
It's vanilla wine.
https://bugs.winehq.org/show_bug.cgi?id=56012
--- Comment #5 from Grigory Vasilyev h0tc0d3@gmail.com --- close
https://bugs.winehq.org/show_bug.cgi?id=56012
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |ABANDONED
--- Comment #6 from Zeb Figura z.figura12@gmail.com --- (In reply to Grigory Vasilyev from comment #4)
(In reply to Zeb Figura from comment #3)
Please test with upstream "vanilla" wine, without *any* external patches or components.
It's vanilla wine.
It can't be. Vanilla wine does not have fsync.
(In reply to Grigory Vasilyev from comment #5)
close
I'll take this as an indication you've unfortunately decided to abandon the bug, so resolving ABANDONED.
https://bugs.winehq.org/show_bug.cgi?id=56012
Grigory Vasilyev h0tc0d3@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|ABANDONED |--- Status|RESOLVED |UNCONFIRMED
--- Comment #7 from Grigory Vasilyev h0tc0d3@gmail.com --- I rechecked again, I thought the problem was in fsync, but I added fsync patches and FPS increased to 70. But FPS is also low.
https://bugs.winehq.org/show_bug.cgi?id=56012
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #8 from Fabian Maurer dark.shadow4@web.de --- Can you do a git bisect to find out what broke it?
https://bugs.winehq.org/show_bug.cgi?id=56012
--- Comment #9 from Grigory Vasilyev h0tc0d3@gmail.com --- (In reply to Fabian Maurer from comment #8)
Can you do a git bisect to find out what broke it?
I'll try this one of these days.
https://bugs.winehq.org/show_bug.cgi?id=56012
Grigory Vasilyev h0tc0d3@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #10 from Grigory Vasilyev h0tc0d3@gmail.com --- My bad. Fixed with external patches.
https://bugs.winehq.org/show_bug.cgi?id=56012
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick@piezo-forte.be Resolution|FIXED |ABANDONED
--- Comment #11 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- (In reply to Grigory Vasilyev from comment #10)
My bad. Fixed with external patches.
Hello,
I would like to know what was patched to fix the issue? Wine, fsync, DXVK or other?
Anyway, that's not what Resolved Fixed is for. If there was a valid Wine bug (which hasn't been determined yet), nothing was changed in Wine to address it.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=56012
--- Comment #12 from Grigory Vasilyev h0tc0d3@gmail.com --- (In reply to Olivier F. R. Dierick from comment #11)
(In reply to Grigory Vasilyev from comment #10)
My bad. Fixed with external patches.
Hello,
I would like to know what was patched to fix the issue? Wine, fsync, DXVK or other?
Anyway, that's not what Resolved Fixed is for. If there was a valid Wine bug (which hasn't been determined yet), nothing was changed in Wine to address it.
Regards.
The problem was solved by some patch from wine staging. I don't know exactly which patch helped from wine staging. But I applied patches the other day, and it didn’t seem to give any results. Perhaps the combination of wine upstream + wine staging helped.
Fsync + Wine Staging patches, without: eventfd_synchronization ntdll-WRITECOPY user32-rawinput-mouse user32-rawinput-mouse-experimental
eventfd_synchronization replaced with fsync ported from valve wine experimental_8.0. The wine-tkg patches have an older fsync implementation.
ntdll-WRITECOPY Probably a buggy patch that was causing me to freeze. Replaced with hack from valve wine.
user32-rawinput doesn't work properly under wine 9.0, mouse input doesn't work under wayland.
https://bugs.winehq.org/show_bug.cgi?id=56012
--- Comment #13 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,
Can you name the affected games?
If I have one of them in my libraries, I may test the issue and check what caused the regression.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=56012
--- Comment #14 from Grigory Vasilyev h0tc0d3@gmail.com --- (In reply to Olivier F. R. Dierick from comment #13)
Hello,
Can you name the affected games?
If I have one of them in my libraries, I may test the issue and check what caused the regression.
Regards.
Yep. Overwatch 2
If you want to run battle.net then you also need this hack - a patch that I pulled out from valve wine. https://pastebin.com/TTPuqyV6
I mentioned it in this bug report: https://bugs.winehq.org/show_bug.cgi?id=55979
https://bugs.winehq.org/show_bug.cgi?id=56012
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Austin English austinenglish@gmail.com --- Closing.