[Bug 43329] New: comdlg32/filedlg: incorrect path selection

List overview All Threads

newer

older

[Bug 49650] New: Bunch of Heroes...

[Bug 48587] New: httpapi tests are...

wine-bugs＠winehq.org

12 Jul 2017 12 Jul '17

7:59 p.m.

https://bugs.winehq.org/show_bug.cgi?id=43329

Bug ID: 43329 Summary: comdlg32/filedlg: incorrect path selection Product: Wine Version: 2.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comdlg32 Assignee: wine-bugs@winehq.org Reporter: me@mixaill.tk Distribution: ---

There is problem with FileDlg path calculation if user tries to select directory.

If user: - selects some folder (for example, C:\Test) and *enters in it* - clicks on OK

Then the "File does not exist" error message appears.

in itemdlg.c::on_default_action() function:

canon_filename variable equal to "C:\Test\Test" (current directory path + value of automatically filled "file name" textbox in dialog).

You can use "Wargaming.net Game Center" to reproduce this error. ("import game" feature)

https://appdb.winehq.org/objectManager.php?sClass=version&iId=35458

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

7 Mar 7 Mar

8:26 a.m.

New subject: [Bug 43329] comdlg32/filedlg: incorrect path selection

https://bugs.winehq.org/show_bug.cgi?id=43329

Zhiyi Zhang yi.gd.cn@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |yi.gd.cn@gmail.com

--- Comment #1 from Zhiyi Zhang yi.gd.cn@gmail.com --- # Work around umimplemented _Temp_get $ winetricks vcrun2017

Can not reproduce with wine-3.3, please retest to verify if the problem still exists. Thanks.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

13 Oct 13 Oct

10:01 p.m.

New subject: [Bug 43329] Multiple applications fail to get selected path after double click last path element in IFileDialog2 folder selection dialog (Wargaming.net Game Center, Adobe DNG Converter 10.x/11.x)

https://bugs.winehq.org/show_bug.cgi?id=43329

Anastasius Focht focht@gmx.net changed:

--- Comment #2 from Anastasius Focht focht@gmx.net --- Hello folks,

I can confirm this annoying behaviour with Adobe DNG Converter 10.x/11.x when doing folder selection for images to convert.

NOTE: The app behaves differently depending on the Windows version setting.

'Windows XP' -> uses 'SHBrowseForFolder' (works properly) 'Windows 7' (default) -> uses 'IFileDialog2'

In 'Windows 7' mode (default) when double clicking on a folder, the app will reset the selection and shows "no images have been selected".

This works:

1) double click "My Computer" 2) double click "C:" 3) select "Program Files" 4) click "select" button -> shows "c:\Program Files" as selected path

This doesn't work:

1) double click "My Computer" 2) double click "C:" 3) double click "Program Files" (shows "Program Files" in filename edit control) 4) click "select" button -> resets selection, folder selection didn't work

--- snip --- $ pwd /home/focht/.wine/drive_c/Program Files/Adobe/Adobe DNG Converter

$ WINEDEBUG=+commdlg wine ./Adobe\ DNG\ Converter.exe ... 0057:trace:commdlg:IExplorerBrowserEvents_fnOnViewCreated 0x6f1c50 (0x1263780) 0057:trace:commdlg:IExplorerBrowserEvents_fnOnNavigationComplete 0x6f1c50 (0xcf06a0) 0057:trace:commdlg:events_OnFolderChange 0x6f1c50 0057:trace:commdlg:on_idok 0x6f1c50 0057:trace:commdlg:on_default_action Acting on 1 file(s). 0057:trace:commdlg:COMDLG32_GetCanonicalPath current directory=L"C:\Program Files\" 0057:trace:commdlg:COMDLG32_GetCanonicalPath canon=L"C:\Program Files\Program Files" 0057:trace:commdlg:FILEDLG95_ValidatePathAction parse now=L"C:\" next=L"Program Files\Program Files" sf=0x6f1f10 0057:trace:commdlg:FILEDLG95_ValidatePathAction parse OK attr=0xf080017f pidl=0x1263640 0057:trace:commdlg:FILEDLG95_ValidatePathAction parse now=L"Program Files\" next=L"Program Files" sf=0xcf2740 0057:trace:commdlg:FILEDLG95_ValidatePathAction parse OK attr=0xf080017f pidl=0x6ccc40 0057:trace:commdlg:FILEDLG95_ValidatePathAction parse now=L"Program Files" next=L"" sf=0x6f5a00 0057:trace:commdlg:events_OnFileOk 0x6f1c50 0057:trace:commdlg:on_wm_destroy 0x6f1c50 0057:trace:commdlg:IExplorerBrowserEvents_fnRelease 0x6f1c50 0057:trace:commdlg:IFileDialog2_fnRelease 0x6f1c50 - ref 5 0057:trace:commdlg:IFileDialog2_fnRelease 0x6f1c50 - ref 4 0057:trace:commdlg:ICommDlgBrowser3_fnRelease 0x6f1c50 0057:trace:commdlg:IFileDialog2_fnRelease 0x6f1c50 - ref 3 0057:trace:commdlg:ICommDlgBrowser3_fnRelease 0x6f1c50 0057:trace:commdlg:IFileDialog2_fnRelease 0x6f1c50 - ref 2 0057:trace:commdlg:ICommDlgBrowser3_fnRelease 0x6f1c50 0057:trace:commdlg:IFileDialog2_fnRelease 0x6f1c50 - ref 1 0057:trace:commdlg:create_dialog Returning 0x00000000 0057:trace:commdlg:IFileDialog2_fnGetResult 0x6f1c50 (0x239f50) 0057:trace:commdlg:IFileDialog2_fnRelease 0x6f1c50 - ref 0 0057:trace:commdlg:ctrl_container_on_wm_destroy 0x6f1c50 --- snip ---

Path was incorrectly canonicalized (last path element repeated).

$ sha1sum DNGConverter_11_0.exe 68ec7f06544d9f893efd3ef19b9487266ad70722 DNGConverter_11_0.exe

$ du -sh DNGConverter_11_0.exe 376M DNGConverter_11_0.exe

$ wine --version wine-3.18

Regards

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

14 Oct 14 Oct

1:54 p.m.

https://bugs.winehq.org/show_bug.cgi?id=43329

--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- I'd like to test this, but it doesn't install correctly for me. Only ProgramData part is copied over, I don't get Program Files/Adobe/ dir. Is it a regression or did I miss some workaround?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7:16 p.m.

https://bugs.winehq.org/show_bug.cgi?id=43329

--- Comment #4 from Anastasius Focht focht@gmx.net --- Hello Nikolay,

works for me in new 64-bit WINEPREFIX (default).

--- snip --- $ wine --version wine-3.18

$ find .wine/drive_c/ -iname *.exe -exec file {} ; ... .wine/drive_c/Program Files/Adobe/Adobe DNG Converter/Adobe DNG Converter.exe: PE32+ executable (GUI) x86-64, for MS Windows ... --- snip ---

Are you by chance trying to install Adobe DNG converter in 32-bit WINEPREFIX (WINEARCH=win32)? Sorry that I didn't mention this, this won't work.

https://supportdownloads.adobe.com/detail.jsp?ftpID=6450

--- snip --- File Information Product Adobe Camera Raw and DNG Converter Version 11.0 Platform Windows File Name DNGConverter_11_0.exe File Size 375.5MB

System requirements

Microsoft® Windows® 7 with Service Pack 1, or Windows 10 (version 1703 or later) --- snip ---

It seems there is no 32-bit executable of the app at all in the NSIS package, even though the installer runs and claims success.

One can use 7-zip to list the content of the .exe. 7-zip supports decompressing NSIS installers.

--- snip --- $ 7z l DNGConverter_11_0.exe

7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_US.utf8,Utf16=on,HugeFiles=on,64 bits,8 CPUs Intel(R) Core(TM) i7-4700HQ CPU @ 2.40GHz (306C3),ASM,AES-NI)

Scanning the drive for archives: 1 file, 393662064 bytes (376 MiB)

Listing archive: DNGConverter_11_0.exe

-- Path = DNGConverter_11_0.exe Type = PE Physical Size = 393662064 CPU = x86 Characteristics = Executable 32-bit NoRelocs NoLineNums NoLocalSyms Created = 2018-01-30 05:57:45 Headers Size = 1024 Checksum = 393709481 Image Size = 290816 Section Alignment = 4096 File Alignment = 512 Code Size = 25600 Initialized Data Size = 162816 Uninitialized Data Size = 1024 Linker Version = 6.0 OS Version = 4.0 Image Version = 6.0 Subsystem Version = 4.0 Subsystem = Windows GUI DLL Characteristics = Relocated NX-Compatible NoSEH TerminalServerAware Stack Reserve = 1048576 Stack Commit = 4096 Heap Reserve = 1048576 Heap Commit = 4096 Image Base = 4194304 ---- Path = [0] Size = 393604216 Packed Size = 393604216 Virtual Size = 393604216 Offset = 50176 -- Path = [0] Type = Nsis Physical Size = 393604211 Tail Size = 5 Method = Deflate Solid = - Headers Size = 352217 Embedded Stub Size = 0 SubType = NSIS-3 BadCmd=11

Date Time Attr Size Compressed Name ------------------- ----- ------------ ------------ ------------------------ 2003-09-23 20:34:00 ..... 1884 $PLUGINSDIR/modern-wizard.bmp ..... 4549 $PLUGINSDIR/nsDialogs.dll ..... 6818 $PLUGINSDIR/System.dll 2018-09-12 09:32:08 ..... 4279 $PLUGINSDIR/modern-header.bmp 2018-09-12 10:22:02 ..... 64760883 $PROGRAMFILES64/Adobe/Adobe DNG Converter/Adobe DNG Converter.exe 2018-09-12 09:33:26 ..... 106818 $PROGRAMFILES64/Adobe/Adobe DNG Converter/tbb.dll 2018-09-12 09:33:26 ..... 55077 $PROGRAMFILES64/Adobe/Adobe DNG Converter/tbbmalloc.dll 2018-09-12 09:31:20 ..... 49177 $PROGRAMFILES64/Adobe/Adobe DNG Converter/vcruntime140.dll 2018-09-12 09:33:04 ..... 26354 $APPDATA/Adobe/CameraRaw/CameraProfiles/Index.dat ... 2018-09-12 09:33:22 ..... 252249 $APPDATA/Adobe/CameraRaw/Settings/Adobe/Profiles/Vintage/Vintage 08.xmp 2018-09-12 09:33:22 ..... 251890 $APPDATA/Adobe/CameraRaw/Settings/Adobe/Profiles/Vintage/Vintage 09.xmp 2018-09-12 09:33:22 ..... 253031 $APPDATA/Adobe/CameraRaw/Settings/Adobe/Profiles/Vintage/Vintage 10.xmp ------------------- ----- ------------ ------------ ------------------------ 2018-09-12 10:22:02 53 393545249 4365 files --- snip ---

'$PROGRAMFILES64'. Totally stupid from Adobe to not block the install of DNG converter 11.x on a pure 32-bit system.

Regards

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

15 Oct 15 Oct

12:28 p.m.

https://bugs.winehq.org/show_bug.cgi?id=43329

zzzzzyzz@hacari.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zzzzzyzz@hacari.org

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

24 Dec 24 Dec

10:41 a.m.

https://bugs.winehq.org/show_bug.cgi?id=43329

Anastasius Focht focht@gmx.net changed:

--- Comment #5 from Anastasius Focht focht@gmx.net --- Hello folks,

this was fixed a long time ago by commit https://source.winehq.org/git/wine.git/commitdiff/5a622342d9e658e0db880d79c1... ("comdlg32: When FOS_PICKFOLDERS is specified item selection box should contain full path name"). Part of Wine 4.0-rc3 release.

Thanks Dmitry

The time frame from my comment (Wine 3.18) to Wine 4.0-rc3 let me think if he knew about this ticket. I was offline between 2018-12-17 and 2019-01-13 otherwise I would have recognized the commit from 2018-12-20.

I've created a stable snapshot via Internet Archive:

https://web.archive.org/web/20201224103741/http://download.adobe.com/pub/ado...

$ sha1sum DNGConverter_11_0.exe 68ec7f06544d9f893efd3ef19b9487266ad70722 DNGConverter_11_0.exe

$ du -sh DNGConverter_11_0.exe 376M DNGConverter_11_0.exe

$ wine --version wine-4.0-rc3

Regards

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

26 Dec 26 Dec

7:10 p.m.

https://bugs.winehq.org/show_bug.cgi?id=43329

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.0-rc4.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1476

Age (days ago)

2739

Last active (days ago)

wine-bugs@winehq.org

7 comments

2 participants

tags (0)

participants (2)

wine-bugs＠winehq.org
WineHQ Bugzilla