[Bug 28442] New: CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

Summary: CSpy5: Listview icons have a black background
           Product: Wine
           Version: 1.3.28
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Just finished regression test and the result is:

dc9a218a00e3abd48536e1c9d976ba52745a221e is first bad commit
commit dc9a218a00e3abd48536e1c9d976ba52745a221e
Author: Alexandre Julliard 
Date:   Thu Sep 15 12:49:08 2011 +0200

winex11: Add a StretchBlt entry point to the XRender driver.

:040000 040000 7e9122263e58d6ae6392583ed526d0b70475d257
6a893ebc5e7080ba732eddfc16cea36f73928277 M    dlls

It's not revertible on current git, but commit before it works fine as it used
to. So I believe results are correct.

I tested this with ControlSpy5 - application for comctl32 and user32 controls
from MS, could be downloaded from msdn website.

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |dc9a218a00e3abd48536e1c9d97
                   |                            |6ba52745a221e

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #1 from Alexandre Julliard  2011-09-23 04:25:12 CDT ---
Please retest with current git.

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #2 from Nikolay Sivov  2011-09-23 04:31:35 CDT ---
I did yesterday, no change. The problem was also visible in product selection
tree on Office 2010 installer - "+" expand button had black background just
like icons in CSpy. Not sure Office example is still valid for current git,
CSpy's is.

Could it be XRender problem on my side, bug or something? I use the one shipped
with Debian 5, package manager says it's 0.9.4-2.

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #3 from Alexandre Julliard  2011-09-23 05:11:35 CDT ---
CSpy looks fine here. What's your graphics card?

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #4 from Nikolay Sivov  2011-09-23 05:54:29 CDT ---
(In reply to comment #3)
> CSpy looks fine here. What's your graphics card?

It's VMWare driver actually, I'll try with real hardware (Intel).

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #5 from Nikolay Sivov  2011-09-23 06:50:51 CDT ---
Works fine with Intel card, marking invalid.

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Nikolay Sivov  2011-09-23 06:51:06 CDT ---
Closing.

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #7 from Austin English  2011-09-23 12:36:00 CDT ---
(In reply to comment #5)
> Works fine with Intel card, marking invalid.

Was it broken on intel at commit dc9a218a00e3abd48536e1c9d976ba52745a221e?

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #8 from Nikolay Sivov  2011-09-23 12:38:23 CDT ---
(In reply to comment #7)
> (In reply to comment #5)
> > Works fine with Intel card, marking invalid.
>
> Was it broken on intel at commit dc9a218a00e3abd48536e1c9d976ba52745a221e?

Good question, will check if find some time today.

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #9 from Nikolay Sivov  2011-09-27 16:14:11 CDT ---
This is fixed for me with wine-1.3.29-99-g3960ea8. Icons look good again, no
system changes just new wine.

[Bug 28442] CSpy5: Listview icons have a black background

http://bugs.winehq.org/show_bug.cgi?id=28442

--- Comment #10 from Alexandre Julliard  2011-09-27 16:22:31 CDT ---
Most likely it's now going through the DIB engine instead of XRender, so it
doesn't trigger the driver bug.