[Bug 22957] New: MapSource 6.16.1 doesn't draw the main map anymore

http://bugs.winehq.org/show_bug.cgi?id=22957

Summary: MapSource 6.16.1 doesn't draw the main map anymore
           Product: Wine
           Version: 1.2-rc2
          Platform: x86
               URL: http://www8.garmin.com/software/MapSource_6161.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=28429)
 --> (http://bugs.winehq.org/attachment.cgi?id=28429)
Wine output running mapsource, doing some zooming on the absent map, and
closing

Newer MapSource version 6.16.1 upgrades ok (after changing OS from WinXP to
Win7 since the installer fails saying it needs WinXP SP3 at least).

After installing and running, window and menus draws fine, but the main map
window shows no map, just gray tiles.

The map legends still show up.

Opening a track or drawing routes do display the lines, but not the map.
Hovering the mouse over shows street names, etc., but we can't see the map.

Zooming in and out constantly makes the application crash.

[Bug 22957] MapSource 6.16.1 doesn't draw the main map anymore

http://bugs.winehq.org/show_bug.cgi?id=22957

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|MapSource 6.16.1 doesn't    |MapSource 6.16.1 doesn't
                   |draw the main map anymore   |draw the main map
              Alias|MapSource                   |

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

--- Comment #1 from [e-mail]  2010-07-31 15:11:05 ---
Created an attachment (id=29954)
 --> (http://bugs.winehq.org/attachment.cgi?id=29954)
mapsource screen

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

Krzysztof Nowicki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Krzysztof Nowicki  2010-10-16 16:30:01 CDT ---
It looks like the problem lies in the implementation of
FormatConverter_CopyPixels. According to the MSDN it is legal to pass a NULL
rectangle pointer to this function. In such case the whole bitmap area should
be copied. The existing implementation silently assumes that the rectangle will
never be NULL.

Fixing this function to properly handle NULL rectangles causes the map to be
drawn correctly.

A patch fixing this issue has been submitted to wine-patches.

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |windowscodecs

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

--- Comment #3 from Vincent Povirk  2010-10-16 18:26:00 CDT ---
This will also have to be fixed in copy_pixels, FlipRotator_CopyPixels,
copy_interlaced_pixels, and TiffFrameDecode_CopyPixels.

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

--- Comment #4 from Krzysztof Nowicki  2010-10-20 15:36:30 CDT ---
The patch has been committed to git repo.

http://source.winehq.org/git/wine.git/?a=commit;h=145bda5aa6a1811f5c31d287bb...

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

--- Comment #5 from Juan Lang  2010-10-20 15:43:33 CDT ---
Fixed then?

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] 2010-10-30 11:08:25 CDT ---
Fixed in Wine 3.1.6

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

--- Comment #7 from [e-mail] 2010-10-30 11:11:07 CDT ---
(In reply to comment #6)
> Fixed in Wine 3.1.6

sorry! 1.3.6

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Nikolay Sivov  2010-10-30 11:12:50 CDT ---
Reported fixed.

[Bug 22957] MapSource 6.16.1 doesn't draw the main map

http://bugs.winehq.org/show_bug.cgi?id=22957

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2010-11-12 13:33:52 CST ---
Closing bugs fixed in 1.3.7.