[Bug 19411] New: 'wine uninstaller' crashes on launch (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19411

Summary: 'wine uninstaller' crashes on launch (appinstall)
           Product: Wine
           Version: 1.1.26
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression, source
          Severity: normal
          Priority: P2
         Component: shell32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

$ wine uninstaller

Backtrace:
=>0 0x7e5a4ad3 Control_RunDLLW+0x3c3(hWnd=0x10020, hInst=(nil), cmd=<is not
available>, nCmdShow=5) [/home/austin/wine-git/dlls/shell32/control.c:786] in
shell32 (0x0032fe68)
  1 0x7e5a4e7d Control_RunDLLA+0xfd(hWnd=0x10020, hInst=(nil),
cmd="appwiz.cpl", nCmdShow=5)
[/home/austin/wine-git/dlls/shell32/control.c:857] in shell32 (0x0032fe98)
  2 0x7ec3e5f7 wmain+0x307(argc=1, argv=0x110378)
[/home/austin/wine-git/programs/uninstaller/main.c:157] in uninstaller
(0x0032fee8)
  3 0x7ec3e962 __wine_spec_exe_wentry+0x82(peb=0x7ffdf000)
[/home/austin/wine-git/dlls/winecrt0/exe_wentry.c:36] in uninstaller
(0x0032ff08)
  4 0x7ede5cc0 start_process+0x130(arg=(nil))
[/home/austin/wine-git/dlls/kernel32/process.c:955] in kernel32 (0x0032ffe8)
  5 0xf7defe5d wine_call_on_stack+0x1d() in libwine.so.1 (0x00000000)
0x7e5a4ad3 Control_RunDLLW+0x3c3
[/home/austin/wine-git/dlls/shell32/control.c:786] in shell32: cmpw   
$64,0x0(%edx)
786        if ((*extraPmts == '@') && (sp == -1)) {

austin@midna:~/wine-git$ git bisect good
bd926bde3830e13398e761e588ec3be0544f52a9 is first bad commit
commit bd926bde3830e13398e761e588ec3be0544f52a9
Author: Owen Rudge 
Date:   Mon Jul 20 17:03:47 2009 -0300

shell32: Check if a numerical value has been passed inside quotes in
Control_DoLaunch.

:040000 040000 7903859b851ee2653935bccbdbda6794c8c442c8
d089d451106e5cf9b30d2caee8a301571f7720c7 M    dlls

Found by appinstall :-)
(http://austinenglish.com/logs/appinstall-2009-07-21/builtin-gui-result.txt)

[Bug 19411] 'wine uninstaller' crashes on launch (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19411

--- Comment #1 from Owen Rudge   2009-07-21 21:26:02 ---
Whoops, a stupid mistake: forgot to verify that extraPmts is a valid pointer -
patch sent to wine-patches
(http://www.winehq.org/pipermail/wine-patches/2009-July/076235.html).

[Bug 19411] 'wine uninstaller' crashes on launch (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19411

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #2 from André H.   2009-09-09 07:45:30 ---
patch comitted some time ago

[Bug 19411] 'wine uninstaller' crashes on launch (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19411

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard   2009-09-25 12:25:48 ---
Closing bugs fixed in 1.1.30.

[Bug 19411] 'wine uninstaller' crashes on launch (appinstall)

https://bugs.winehq.org/show_bug.cgi?id=19411

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6d598150596318d7514ae2266f6
                   |                            |509a61e3d4848
                 CC|                            |[e-mail]
    Regression SHA1|                            |bd926bde3830e13398e761e588e
                   |                            |c3be0544f52a9