[Bug 22866] New: Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

Summary: Cannot input new warrior name  in the game Taikou
                    Risshiden 5
           Product: Wine
           Version: 1.2-rc1
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The game Taikou Risshiden 5 (太閤立志伝 5) has an option to create new warriors.
When it asks for the name of the new warrior, nothing can be input at all.

This is a regression. The first bad commit is :

commit f7b18148d4787adbd9b0993da366e09c1230e53b
Author: Kusanagi Kouichi 
Date:   Thu Feb 18 23:06:31 2010 +0900

winex11.drv: Keep the state of XIM and IME consistent.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #1 from jslu   2010-05-25 02:20:36 ---
Reverting f7b18148d4787adbd9b0993da366e09c1230e53b solves the bug.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |f7b18148d4787adbd9b0993da36
                   |                            |6e09c1230e53b

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jerome Leclanche  2011-11-08 09:30:56 CST ---
[e-mail] is on CC. Please take a look at this.

OP, I take it this is still an issue?

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Jerome Leclanche  2011-11-08 09:32:29 CST ---
Given the symptoms and the date of the regression, I think this affects WoW
input as well.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #4 from jslu  2011-11-08 19:55:48 CST ---
(In reply to comment #2)
> [e-mail] is on CC. Please take a look at this.
>
> OP, I take it this is still an issue?

Yes, this problem still exists in wine-1.3.32.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #5 from Kusanagi Kouichi  2012-01-03 06:45:39 CST ---
Created attachment 38235
  --> http://bugs.winehq.org/attachment.cgi?id=38235
possible fix

Does this patch fix the regression?

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #6 from jslu  2012-01-03 20:21:09 CST ---
Created attachment 38249
  --> http://bugs.winehq.org/attachment.cgi?id=38249
Traces with WINEDEBUG=+imm

The above patch does not work. Still nothing can be inputed after applying the
patch.

Attached is two trace logs with WINEDEBUG=+imm. The file failure.log is
generated after applying the above patch while success.log is generated after
reverting f7b18148d4787adbd9b0993da366e09c1230e53b.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #7 from Henri Verbeet  2012-01-04 02:37:44 CST ---
Maybe this is unrelated, but what input method (scim/uim/ibus/etc.) do you use,
and do the imm32 tests (run make test in dlls/imm32/tests) pass for you?

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #8 from jslu  2012-01-04 19:37:08 CST ---
I use scim. When I turn scim off and just type English letters in the game, the
regression can still be seen.

The imm32 test fails for me:

../../../tools/runtest -q -P wine -M imm32.dll -T ../../.. -p imm32_test.exe.so
imm32.c && touch imm32.ok
fixme:imm:ImmReleaseContext (0x10056, 0x130b80): stub
fixme:imm:ImeSetCompositionString PROBLEM: This only sets the wine level string
fixme:imm:ImeSetCompositionString PROBLEM: This only sets the wine level string
fixme:imm:ImeSetCompositionString PROBLEM: This only sets the wine level string
fixme:imm:NotifyIME Unknown
fixme:imm:ImmGetOpenStatus (0x130b80): semi-stub
imm32.c:443: Test failed: ImmGetOpenStatus failed
imm32.c:452: Test succeeded inside todo block: ImmGetOpenStatus failed
fixme:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETCOMPOSITIONFONT
fixme:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETCOMPOSITIONFONT
fixme:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETCOMPOSITIONWINDOW
fixme:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETCOMPOSITIONWINDOW
fixme:imm:NotifyIME Unknown
fixme:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETSTATUSWINDOWPOS
fixme:imm:NotifyIME Unknown
fixme:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETSTATUSWINDOWPOS
fixme:imm:ImeHandleNotify WM_IME_NOTIFY:<Unknown 0x0>
make: *** [imm32.ok] Error 2

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #9 from Henri Verbeet  2012-01-05 02:17:00 CST ---
There is (used to be?) an issue with scim not properly supporting querying of
XNPreeditState, and this makes the imm32 tests fail. I'm not quite sure if
that's the same issue this bug is about, but if it is, just replacing the "ret
= XGetICValues...;" line in X11DRV_SetPreeditState() with "ret = TRUE;" may
make a difference.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #10 from jslu  2012-01-05 19:51:16 CST ---
(In reply to comment #9)
> There is (used to be?) an issue with scim not properly supporting querying of
> XNPreeditState, and this makes the imm32 tests fail. I'm not quite sure if
> that's the same issue this bug is about, but if it is, just replacing the "ret
> = XGetICValues...;" line in X11DRV_SetPreeditState() with "ret = TRUE;" may
> make a difference.

That works!

I have further tried to export XMODIFIERS='' before running the game without
changing wine code and this works too.

So is this just a scim bug?

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #11 from Henri Verbeet  2012-01-06 06:02:32 CST ---
I think so, although I wonder if there's nothing we can do about it. On the
other hand, it seems scim is mostly going away in favor of ibus.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #12 from jslu  2012-01-06 19:56:46 CST ---
I have tested with ibus. However, the regression still exists. Using ibus, I
can neither input anything in the game nor make the imm32 test pass. Replacing
the "ret = XGetICValues...;" line in X11DRV_SetPreeditState() with "ret =
TRUE;" will solve both problems.

I'm using gentoo. Can anyone using other distributions pass the imm32 test with
scim or ibus?

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #13 from Kusanagi Kouichi  2012-01-07 03:48:12 CST ---
Does this bug affect only 太閤立志伝 5?
I cannot reproduce with scim-skk and notepad.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #14 from jslu  2012-01-07 06:13:43 CST ---
I find only 太閤立志伝 5 affected.

Comment 3 mentioned WOW, but I don't have WOW in my computer and cannot confirm
that.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #15 from Kusanagi Kouichi  2012-01-08 05:47:03 CST ---
Created attachment 38300
  --> http://bugs.winehq.org/attachment.cgi?id=38300
make imm32 tests pass

Can you test this patch?

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #16 from jslu  2012-01-08 20:00:07 CST ---
(In reply to comment #15)
> Created attachment 38300 [details]
> make imm32 tests pass
>
> Can you test this patch?

This patch works. I can pass the imm32 test and input in the game now with scim
and ibus.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

--- Comment #17 from Kusanagi Kouichi  2012-01-09 01:42:00 CST ---
Patch sent:
http://source.winehq.org/patches/data/82509

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

jslu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from jslu  2012-01-11 19:19:41 CST ---
I see the patch in git now, so this bug should be marked fixed.

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |dc02e4d1a7c35b4205f6109ad71
                   |                            |deee5fdddd750
                 CC|                            |[e-mail]

[Bug 22866] Cannot input new warrior name in the game Taikou Risshiden 5

http://bugs.winehq.org/show_bug.cgi?id=22866

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard  2012-01-13 13:51:21 CST ---
Closing bugs fixed in 1.3.37.