[Bug 29274] New: Steam on Mac - mic test fails and crashes Counter Strike 1.6

http://bugs.winehq.org/show_bug.cgi?id=29274

Bug #: 29274
           Summary: Steam on Mac - mic test fails and crashes Counter
                    Strike 1.6
           Product: Wine
           Version: 1.3.34
          Platform: x86-64
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 37861
  --> http://bugs.winehq.org/attachment.cgi?id=37861
Winedebug dump with +coreaudio

When starting Counter Strike 1.6 game crashes or shows error messages and then
continues without sound.
Similar thing happens if you click "Test microphone" in Steam Settings>Voice.
Attaching debug of coreaudio.

Found one solution, but not sure it is proper one:

Appears that 
in dlls/winecoreaudio/mmdevdrv.c
in AudioCaptureClient_ReleaseBuffer function

This->public_buffer is sometimes empty and makes this crash.

So, changed:

pbuf_frames = This->public_buffer->mAudioDataByteSize / This->fmt->nBlockAlign;

to:

if (This->public_buffer)
    pbuf_frames = This->public_buffer->mAudioDataByteSize /
This->fmt->nBlockAlign;

Programmer myself, but don't have time to explore where real error is. This fix
makes game work without crash, but think problem is where is
This->public_buffer released (or not set...)

[Bug 29274] Steam on Mac - mic test fails and crashes Counter Strike 1.6

http://bugs.winehq.org/show_bug.cgi?id=29274

--- Comment #1 from [e-mail] 2011-12-08 08:22:23 CST ---
NOTE. attached output is from Steam mic test, but almost same is from Counter
Strike 1.6

[Bug 29274] Steam on Mac - mic test fails and crashes Counter Strike 1.6

http://bugs.winehq.org/show_bug.cgi?id=29274

--- Comment #2 from Jörg Höhle  2011-12-30 10:04:22 CST ---
Created attachment 38179
  --> http://bugs.winehq.org/attachment.cgi?id=38179
CoreAudio Capture work in progress patch

I've some unfinished CoreAudio capture patches that may help.
See background bug #28023

[Bug 29274] Steam on Mac - mic test fails and crashes Counter Strike 1.6

http://bugs.winehq.org/show_bug.cgi?id=29274

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38179|0                           |1
        is obsolete|                            |

--- Comment #3 from Jörg Höhle  2012-01-08 16:09:49 CST ---
Created attachment 38304
  --> http://bugs.winehq.org/attachment.cgi?id=38304
patch to winecoreaudio/mmdevdrv.c against 1.3.36

Please test this.  The crash should be gone.  However there's probably another
bug elsewhere, because on my Leopard machine, my capture test never receives
any frames.

[Bug 29274] Steam on Mac - mic test fails and crashes Counter Strike 1.6

http://bugs.winehq.org/show_bug.cgi?id=29274

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29274] Steam on Mac - mic test fails and crashes Counter Strike 1.6

http://bugs.winehq.org/show_bug.cgi?id=29274

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
                   |                            |t
         Resolution|                            |FIXED

--- Comment #4 from Jörg Höhle  2013-03-03 06:54:42 CST ---
The rogue This->public_buffer was fixed long ago.  This bug is fixed (or
abandoned). Feel free to reopen should there still be issues with the
microphone in the voice test.

[Bug 29274] Steam on Mac - mic test fails and crashes Counter Strike 1.6

http://bugs.winehq.org/show_bug.cgi?id=29274

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-03-15 14:45:49 CDT ---
Closing bugs fixed in 1.5.26.