https://bugs.winehq.org/show_bug.cgi?id=45972
Bug ID: 45972 Summary: Lego Mindstorms EV3 1.3.1 installer crashes Product: Wine Version: 3.17 Hardware: x86 URL: https://le-www-live-s.legocdn.com/downloads/LMS-EV3/LM S-EV3_Full-setup_1.3.1_en-US_WIN32.exe OS: Linux Status: NEW Keywords: download, Installer Severity: normal Priority: P2 Component: msi Assignee: wine-bugs@winehq.org Reporter: dmitry@baikal.ru Distribution: ---
Warning: winetricks has a recipe to install Lego Mindstorms EV3 as 'ev3' however it installs a lot of unnecessary things like vcrun2005, ie8 and dotnet40 and after that it downloads an old version of the software.
In order to reproduce this bug just download the installer specified in URL field and run it. After initial unpacking and pressing "Next" the installer crashes, and shows its own crash handler window with a backtrace.
Fortunately after the installer has crashed it leaves in the %TEMP% directory full installation tree under "LEGO MINDSTORMS EV3 Home Edition" sub-directory. In order to reproduce further crashes and make the investigation of the bug easier just locate in that directory tree MetaUninstaller.msi under Products/MetaUninstaller/MU and run 'wine msiexec /i MetaUninstaller.msi'.
To make long story short: the crash is caused by silently failing "NIPaths" custom action due to a failed MsiViewModify() call. MsiViewModify() failure happens because of the check https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/msi/msiquery.c#l696 696 if ( mode == MSIMODIFY_UPDATE && rec->query != query ) 697 return ERROR_FUNCTION_FAILED; since for the remote MSIRECORD structures rec->query field always stays not initialized (NULL). Commenting out this check makes both the MetaUninstaller and Lego Mindstorms EV3 installations work, however this breaks the tests.
Probably one of our MSI experts has an idea how to fix this issue properly.
https://bugs.winehq.org/show_bug.cgi?id=45972
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=45972
--- Comment #1 from Hans Leidekker hans@meelstraat.net --- Created attachment 62538 --> https://bugs.winehq.org/attachment.cgi?id=62538 patch
Something like this should fix it.
https://bugs.winehq.org/show_bug.cgi?id=45972
--- Comment #2 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Hans Leidekker from comment #1)
Created attachment 62538 [details] patch
Something like this should fix it.
The patch does fix the issue. Thanks Hans.
https://bugs.winehq.org/show_bug.cgi?id=45972
--- Comment #3 from Zebediah Figura z.figura12@gmail.com --- Ugh, thanks. So this was essentially broken by 9d121203955da5c761cfb5c22b6428278e41f0c7.
https://bugs.winehq.org/show_bug.cgi?id=45972
--- Comment #4 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Zebediah Figura from comment #3)
Ugh, thanks. So this was essentially broken by 9d121203955da5c761cfb5c22b6428278e41f0c7.
Nope, I investigated this as well (sorry for not mentioning it), and I've tested that before this commit the installer didn't work either, but it failed a bit differently. So, it's not your fault this time :)
https://bugs.winehq.org/show_bug.cgi?id=45972
--- Comment #5 from Zebediah Figura z.figura12@gmail.com --- (In reply to Dmitry Timoshkov from comment #4)
(In reply to Zebediah Figura from comment #3)
Ugh, thanks. So this was essentially broken by 9d121203955da5c761cfb5c22b6428278e41f0c7.
Nope, I investigated this as well (sorry for not mentioning it), and I've tested that before this commit the installer didn't work either, but it failed a bit differently. So, it's not your fault this time :)
Well, that's odd, given Hans' fix; commit 9d1212039 changed the struct layout and I failed to account for that. It wouldn't have manifested until 85d1fb62b, but that was the underlying cause. Possibly the installer depended on 85d1fb62b as well.
https://bugs.winehq.org/show_bug.cgi?id=45972
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |c494570d89f270c9240519c625c | |5c757a4e8ff23 Status|NEW |RESOLVED
--- Comment #6 from Dmitry Timoshkov dmitry@baikal.ru --- Committed as c494570d89f270c9240519c625c5c757a4e8ff23.
Thanks Hans.
https://bugs.winehq.org/show_bug.cgi?id=45972
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.19.
-
wine-bugs＠winehq.org