https://bugs.winehq.org/show_bug.cgi?id=56181
Bug ID: 56181 Summary: GitLab fails to detect Windows test failures Product: WineHQ Gitlab Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: gitlab-unknown Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
In MR!4839 I introduced a test failure in serialui:confdlg: https://gitlab.winehq.org/wine/wine/-/merge_requests/4839/diffs
This is confirmed by the test-linux-32 job which fails: https://gitlab.winehq.org/fgouget/wine/-/jobs/48236
But both the test-win10-21h2-32 and test-win10-21h2-64 jobs succeed: https://gitlab.winehq.org/fgouget/wine/-/jobs/48237 https://gitlab.winehq.org/fgouget/wine/-/jobs/48238
In fact the corresponding winetest.log only contain: [...] | ACP=1252 | Dll info: | Test output:
So it looks like the jobs did not even run any test?
https://bugs.winehq.org/show_bug.cgi?id=56181
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=56181
--- Comment #1 from Rémi Bernon rbernon@codeweavers.com --- According to the build-winetest artifacts, it has serialui in winetest.args, so it is supposed to have run the test. Then winetest.exe doesn't print its args so it's not yet possible to check whether it has been passed there correctly.
https://bugs.winehq.org/show_bug.cgi?id=56181
--- Comment #2 from Rémi Bernon rbernon@codeweavers.com --- Looks like that the test argument is being split into characters by Get-Content / @WINETEST_ARGS when there's a single line in winetest.args. This should be fixed with https://gitlab.winehq.org/wine/wine/-/merge_requests/4847
https://bugs.winehq.org/show_bug.cgi?id=56181
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |a6b58a2c1fe4951348c788d637a | |cf768aed4d908 Status|NEW |RESOLVED
--- Comment #3 from François Gouget fgouget@codeweavers.com --- This is fixed:
commit a6b58a2c1fe4951348c788d637acf768aed4d908 Author: Rémi Bernon rbernon@codeweavers.com Date: Mon Jan 15 08:59:06 2024 +0100
gitlab: Force WINETEST_ARGS to always be a string array.
Fixes the test name passed to winetest.exe which is otherwise split into a character array when there's a single line in the winetest.args file, and then causes it to miss the test and always return success.
-
WineHQ Bugzilla