[Bug 18425] New: DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

Summary: DLL_PROCESS_DETACH isn't called if a dll returns FALSE
                    on a DLL_PROCESS_ATTACH call
           Product: Wine
           Version: 1.1.21
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=21028)
 --> (http://bugs.winehq.org/attachment.cgi?id=21028)
testcase

Wine does not call DLL_PROCESS_DETACH when the dll returns FALSE on a
DLL_PROCESS_ATTACH call.

Attached is a test case which shows the bug.
The output on wine:
###########Load

and on winXP:
###########Load
###########Unload

This was tested with wine-1.1.21.

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

--- Comment #1 from Austin English   2009-11-19 12:53:36 ---
This is your friendly reminder that there has been no bug activity for 6
months. Is this still an issue in current (1.1.33 or newer) wine?

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

--- Comment #2 from Rico   2009-11-24 13:58:53 ---
Yes, this is still an issue with wine-1.1.33.

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|-unknown                    |ntdll
     Ever Confirmed|0                           |1

--- Comment #3 from Nikolay Sivov   2009-11-25 01:24:05 ---
Confirming.

I've just sent a patch for that:

http://www.winehq.org/pipermail/wine-patches/2009-November/081807.html

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

--- Comment #4 from Nikolay Sivov   2009-11-25 04:12:40 ---
This behaviour is documented actually, attached testcase just proves it:

http://msdn.microsoft.com/en-us/library/ms682583%28VS.85%29.aspx

---
DLL_PROCESS_DETACH
---
The DLL is being unloaded from the virtual address space of the calling process
because *it was loaded unsuccessfully* or the reference count has reached zero
(the processes has either terminated or called FreeLibrary one time for each
time it called LoadLibrary).
---

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Nikolay Sivov   2009-11-30 11:08:15 ---
This is fixed by commit dbbd2161ab516bef0c92d116c7a3cf7d061caa42. Thanks for
the report.

[Bug 18425] DLL_PROCESS_DETACH isn't called if a dll returns FALSE on a DLL_PROCESS_ATTACH call

http://bugs.winehq.org/show_bug.cgi?id=18425

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2009-12-04 12:16:04 ---
Closing bugs fixed in 1.1.34.