http://bugs.winehq.org/show_bug.cgi?id=31920
Bug #: 31920 Summary: ComboBox in a program written with Delphi is shown incorrectly Product: Wine Version: 1.5.14 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs@winehq.org ReportedBy: olelukoie@mail.ru Classification: Unclassified
We at the company I work for have a tool written with Delphi and since one of the recent wine devel versions (1.5.x) it shows its single combobox incorrectly (no button with down-arrow on the right of the control and a very large black area instead of a drop-down list).
git bisect gave me the following:
cbf9589ba397ed98d2aa2270a332171019024b3b is the first bad commit commit cbf9589ba397ed98d2aa2270a332171019024b3b Author: Sergey Guralnik serhio@etersoft.ru Date: Wed Jul 4 23:34:57 2012 +0400
user32: Rearrange ComboBox repositioning code.
:040000 040000 2977ac3d4648b010663c10785732cc8e52b05a68 a6107e62617e0ec238f7c7a40c975c175b1c62f6 M dlls
I've tried to revert this commit in wine 1.5.14 and the problem disappeared (combobox became normal and usable).
http://bugs.winehq.org/show_bug.cgi?id=31920
olelukoie olelukoie@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |cbf9589ba397ed98d2aa2270a33 | |2171019024b3b
http://bugs.winehq.org/show_bug.cgi?id=31920
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #1 from olelukoie olelukoie@mail.ru 2013-03-02 02:25:10 CST --- Created attachment 43762 --> http://bugs.winehq.org/attachment.cgi?id=43762 trace log with wine-1.4.1
As far as there is no any change with the bug in latest wine versions (up to 1.5.25) I've made some more investigations and generated logs with WINEDEBUG=+combo and made screenshots with MS's Spy++ tool.
The "good" ones are made with wine 1.4.1 and the "bad" ones are made with wine 1.5.25.
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #2 from olelukoie olelukoie@mail.ru 2013-03-02 02:25:44 CST --- Created attachment 43763 --> http://bugs.winehq.org/attachment.cgi?id=43763 trace log with wine-1.5.25
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #3 from olelukoie olelukoie@mail.ru 2013-03-02 02:27:25 CST --- Created attachment 43764 --> http://bugs.winehq.org/attachment.cgi?id=43764 screenshot of a spy++ info with wine-1.4.1
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #4 from olelukoie olelukoie@mail.ru 2013-03-02 02:29:21 CST --- Created attachment 43765 --> http://bugs.winehq.org/attachment.cgi?id=43765 screenshot of a spy++ info with wine-1.5.25
Please notice the difference in "Rectangle" and "Restored Rect" values in Spy++ screenshots.
http://bugs.winehq.org/show_bug.cgi?id=31920
Daniel Jelinski djelinski1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |serhio@etersoft.ru
--- Comment #5 from Daniel Jelinski djelinski1@gmail.com 2013-03-07 13:16:36 CST --- Adding author to CC
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #6 from Sergey Guralnik serhio@etersoft.ru 2013-03-08 15:01:31 CST --- Created attachment 43855 --> http://bugs.winehq.org/attachment.cgi?id=43855 possible fix (try 1)
At first look, problem caused by using client height/width at problem patch instead of window height/width. Test attached patch, please.
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #7 from olelukoie olelukoie@mail.ru 2013-03-09 00:45:33 CST --- (In reply to comment #6)
At first look, problem caused by using client height/width at problem patch instead of window height/width. Test attached patch, please.
Yes, with this patch applied the combo became normal and usable again. I'll do some more testing (using our other corporate software) on Monday and then report results. Do not close this report until then please.
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #8 from olelukoie olelukoie@mail.ru 2013-03-11 12:34:01 CDT --- I've tested all software that I wanted to test with this patch and had no problems with combo boxes. So I think this patch can be committed upstream.
http://bugs.winehq.org/show_bug.cgi?id=31920
--- Comment #9 from Sergey Guralnik serhio@etersoft.ru 2013-03-12 00:40:24 CDT --- (In reply to comment #8)
I've tested all software that I wanted to test with this patch and had no problems with combo boxes. So I think this patch can be committed upstream.
Slightly modified patch was sent to wine-patches@.
http://bugs.winehq.org/show_bug.cgi?id=31920
olelukoie olelukoie@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #10 from olelukoie olelukoie@mail.ru 2013-03-12 15:10:45 CDT --- Fixed. Thank you very much.
http://bugs.winehq.org/show_bug.cgi?id=31920
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ac0738471da49f57105d7d54986 | |03d73fbc650f4
http://bugs.winehq.org/show_bug.cgi?id=31920
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org 2013-03-15 14:46:04 CDT --- Closing bugs fixed in 1.5.26.
-
wine-bugs＠winehq.org