https://bugs.winehq.org/show_bug.cgi?id=50992
Bug ID: 50992 Summary: ADVAPI32.dll.QueryTraceA is a unimplemented funtion - StarCitizen does not load anymore Product: Wine Version: 6.6 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: rawfox@freenet.de Distribution: ---
Created attachment 69828 --> https://bugs.winehq.org/attachment.cgi?id=69828 Backtrace of the StarCitizen crash
Hello again^^
With the latest StarCitizen PTU, the game is asking for QueryTraceA, when it starts loading. Due to that function is not in wine yet, the game drops an error and stops working.
The patches we (LUG) wrote, to stub out that error, had all no success, the error is supressed but its crashing right after, so that we assume that the function needs to provide a proper return.
The game is asking for QueryTraceA. ControlTraceA is present in wine and should superseed QueryTraceA, but its not working.
A Backtrace is attached.
Let the games begin ... :)
https://bugs.winehq.org/show_bug.cgi?id=50992
rawfox rawfox@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|ADVAPI32.dll.QueryTraceA is |ADVAPI32.dll.QueryTraceA is |a unimplemented funtion - |a unimplemented function - |StarCitizen does not load |StarCitizen does not load |anymore |anymore CC| |rawfox@freenet.de
https://bugs.winehq.org/show_bug.cgi?id=50992
rawfox rawfox@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|ntdll |advapi32
https://bugs.winehq.org/show_bug.cgi?id=50992
Mike Scott michael.scott@quest-arts.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.scott@quest-arts.co | |.uk
--- Comment #1 from Mike Scott michael.scott@quest-arts.co.uk --- Created attachment 69831 --> https://bugs.winehq.org/attachment.cgi?id=69831 Patch to implement QueryTraceA
This is a patch I made to add the function QueryTraceA for StarCitizen.
I made it forward the QueryTrace calls to ControlTrace.
NOTE: This patch does not implement the ControlTrace functionality.
https://bugs.winehq.org/show_bug.cgi?id=50992
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|ADVAPI32.dll.QueryTraceA is |Star Citizen crashes on |a unimplemented function - |unimplemented function |StarCitizen does not load |advapi32.dll.QueryTraceA |anymore | Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=50992
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW
--- Comment #2 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Mike Scott from comment #1)
-snip-
Could you remove the whitespace changes from the patch and also remove the FIXME message from QueryTraceW and send this patch upstream?
Patches aren't picked up from bugzilla, have a look at https://wiki.winehq.org/Submitting_Patches.
https://bugs.winehq.org/show_bug.cgi?id=50992
--- Comment #3 from rawfox rawfox@freenet.de --- Created attachment 69855 --> https://bugs.winehq.org/attachment.cgi?id=69855 QueryTraceA patch from unknown author
This patch is successfull loading StarCitizen again.
https://bugs.winehq.org/show_bug.cgi?id=50992
--- Comment #4 from rawfox rawfox@freenet.de --- Mike's patch did forward to ControlTrace, wich should superseed the QueryTrace, but its not working. Yesterday a new stub attempt by an -to me- unknown author was successfull. Ive added that patch and would really like to know, who wrote it :)
https://bugs.winehq.org/show_bug.cgi?id=50992
--- Comment #5 from rawfox rawfox@freenet.de --- The patch to stub it out successfull, was written by @ngh (Netho) from Linux Users Group at RSI. Netho found the right return ERROR_WMI_INSTANCE_NOT_FOUND to make it work.
So this issue is solved for now, but the function is not yet in wine.
https://bugs.winehq.org/show_bug.cgi?id=50992
--- Comment #6 from rawfox rawfox@freenet.de --- Created attachment 69859 --> https://bugs.winehq.org/attachment.cgi?id=69859 Adds a stub for QueryTraceA and StorageDeviceSeekPenaltyProperty, needed for Star Citizen 3.13
Netho reworked the patch.
https://bugs.winehq.org/show_bug.cgi?id=50992
David Koolhoven spambox1@koolhoven-home.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |spambox1@koolhoven-home.net
--- Comment #7 from David Koolhoven spambox1@koolhoven-home.net --- A known working patch has been accepted into WINE to resolve this issue:
7d7b8e2a88c58e05fb80d3600a52c473ddee4c5d
Ticket 51065 is opened to track the seek penalty query issue.
https://bugs.winehq.org/show_bug.cgi?id=50992
Vijay Kamuju infyquest@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |7d7b8e2a88c58e05fb80d3600a5 | |2c473ddee4c5d Resolution|--- |FIXED CC| |infyquest@gmail.com Status|NEW |RESOLVED
--- Comment #8 from Vijay Kamuju infyquest@gmail.com --- setting as resolved fixed as the function is now committed in mainline by commit 7d7b8e2a88c58e05fb80d3600a52c473ddee4c5d.
https://bugs.winehq.org/show_bug.cgi?id=50992
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.8.