[Bug 22079] New: Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

Summary: Right click menu doesn't appear in one section of
                    ImgBurn's disc layout editor
           Product: Wine
           Version: 1.1.41
          Platform: x86-64
               URL: http://www.imgburn.com/index.php?act=download
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=26907)
 --> (http://bugs.winehq.org/attachment.cgi?id=26907)
Terminal output

In ImgBurn's disc layout editor window, right-clicking an item should bring up
a menu with rename, properties, and other options. However, nothing happens
when doing this in the main disc layout view, on the bottom-right (at least
until you try to move the cursor - then you'll run into another bug).

Using winetricks comctl32 makes the menu appear as it should. My log is from
ImgBurn 2.5.0.0, but 2.5.1.0 behaves the same way.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

A Wine user  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Wylda   2010-03-20 13:32:45 ---

Confirming. After "winetricks comctl32" menu appears on right clicks.

All the following versions fails to display the menu in clean wine:
 * 0.9.49, 1.0.1, 1.1.6, 1.1.13, 1.1.19, 1.1.25, 1.1.30, 1.1.35, 1.1.41

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Austin English   2010-03-20 13:49:17 ---
Confirming per comment #1.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

--- Comment #3 from A Wine user   2010-05-20 12:15:08 ---
This bug is still present in wine-1.1.44-380-g0d84ccb.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

LIGHTNING UK!  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from LIGHTNING UK!  2010-09-06 02:50:31 CDT ---
This bug is still present in 1.3.1.

Wine actually turns the right click into a drag+drop event... which clearly it
shouldn't be doing.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

--- Comment #5 from Nikolay Sivov  2011-05-14 08:15:04 CDT ---
Could someone specify steps to reproduce this? I need to know at least where
this layout view is located, preferably for 2.5.5.0 as it's the latest
available.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

--- Comment #6 from LIGHTNING UK!  2011-05-14 08:50:43 CDT ---
Sure, anything I can do to help - and thanks for looking into it :)

1. Load ImgBurn
2. From the 'Mode' menu at the top, click 'Build'.
3. From the 'Input' menu at the top, click 'Advanced'.
4. Click the big 'Show Disc Layout Editor' button in the 'Source' box. (or from
the 'View' menu at the top, click 'Disc Layout Editor').
5. Once it's open, click the 'New Folder' button.
6. Try and right click on that 'New Folder' item in the lower light listview
area.

It's supposed to bring up a menu (which you can see if you right click the same
'New Folder' item in the lower left treeview) but instead it just seems to want
to turn it into a drag+drop event - (if you move the mouse a tiny bit) the
mouse cursor changes to the circle with a line through it ('can't drop here'
kind of thing).

If you right click a second time whilst the drag+drop operation is still in
progress you can usually get the context menu to appear.

You should also be able to bring up a context menu by right clicking in the
blank white space area of that same listview box - that doesn't work properly
either. It'll only bring the context menu up if you right click (hold it down),
move the mouse a bit and then release the button.

If you need any additional info, please don't hesitate to ask.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

--- Comment #7 from LIGHTNING UK!  2011-05-14 10:26:19 CDT ---
FYI, the context/popup menus rely on the WM_CONTEXTMENU message being sent -
there's an event ('OnContextPopup') associated with it and all of my code is in
that.

I can see (having added some debug code) that the event just isn't being fired
when it should be - maybe because the drag+drop is taking over, I don't know.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

--- Comment #8 from Nikolay Sivov  2011-05-14 12:02:35 CDT ---
After a brief look drag-n-drop thing happens with native comctl32 as well (on
left button) so it's shell32 problem most likely.

And yes, listview doesn't get WM_RBUTTONUP message that's used to produce
WM_CONTEXTMENU later (also questionable cause WM_CONTEXTMENU should be produced
by default procedure).

Another thing that bothers me is that some tests show no WM_RBUTTONUP message
at all sent to native control, it looks like WM_RBUTTONDOWN - .. -
WM_CONTEXTMENU.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

--- Comment #9 from LIGHTNING UK!  2011-06-13 15:45:50 CDT ---
Still present in 1.3.22.

If it helps anyone, I put this in an email to Nikolay (but didn't hear
back)....

====================================================================

I use the OnMouseDown event and the Windows API function called 
'DragDetect'.

After stepping through the VCL code it would appear the important bit of the 
program 'flow' is as follows:

User right clicks the mouse
TControl.WMRButtonDown (calls 'inherited')
jumps to TWinControl.WMContextMenu (calls 'inherited')
jumps to TControl.WMContextMenu (calls 'TControl.DoContextPopup')
jumps to TControl.DoContextPopup (calls ListView's 'OnContextPopup' event)
jumps to control's 'OnContextPopup' event (runs my code - shows menu)
Once menu has been closed...
eventually returns to TControl.WMRButtonDown (calls 'TControl.DoMouseDown')
jumps to TControl.DoMouseDown (calls 'TControl.MouseDown')
jumps to TControl.MouseDown (calls ListView's 'OnMouseDown' event)
jumps to control's 'OnMouseDown' event (runs my code - the 'DragDetect' 
function)

So in Windows at least, my context menu code runs before anything 
'MouseDown' (and therefore 'DragDetect') related.

That aside and for some weird reason, Wine's implementation of 'DragDetect' 
seems to return 'true' even if the right mouse button was pressed (rather 
than the left). Windows doesn't do that and it goes against the docs on MSDN 
which only mention the left button. Even clicking my mouse's scroll 
wheel/button can make Wine's DragDetect return 'true' - again, this doesn't 
happen on Windows.

Under Wine, DragDetect returns true instantly if the left mouse button is 
clicked in 'white space' (not on an item). There's no drag rectangle 
(threshold) as mentioned in MSDN.
If the middle / right buttons were clicked (and held) in 'white space' then 
it only returns 'true' after the mouse has been moved 1 pixel. It doesn't 
even matter if you click and release the middle/right button, the second you 
move the mouse 1 pixel is will register it as a drag event. Likewise, you 
can click and release AND press escape before moving the mouse 1 pixel and 
it still registers as a drag event.
If you left click (and hold) on an item, you have to move the mouse 1 pixel 
before it registers as a drag event. Ditto for middle/right buttons.

I'm currently working with a version of the program that logs 'DragDetected' 
in the Log window whenever 'DragDetect' returns true. If that makes 
debugging/testing easier for you, I could send a new exe over?

====================================================================

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

gael97  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |500da7def68934d2e2d74e611bb
                   |                            |6cce77d59d60e
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Nikolay Sivov  2013-05-26 03:51:42 CDT ---
This is fixed with 500da7def68934d2e2d74e611bb6cce77d59d60e. There's another
issue after this commit described in bug 30736, but that's not relevant to this
report.

And yes, it was related to dragging with right button.

[Bug 22079] Right click menu doesn't appear in one section of ImgBurn's disc layout editor

http://bugs.winehq.org/show_bug.cgi?id=22079

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  2013-06-07 15:01:39 CDT ---
Closing bugs fixed in 1.6-rc1.