[Bug 35353] New: mono/eglib/src/gutf8.c: many bad if expressions ?

http://bugs.winehq.org/show_bug.cgi?id=35353

Bug ID: 35353
           Summary: mono/eglib/src/gutf8.c: many bad if expressions ?
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]
    Classification: Unclassified

I just ran the static analyser "cppcheck" over the
source code of wine-mono-4.5.2. It said many things
including

1.

mono/eglib/src/gutf8.c:294]: (style) Expression '(X & 0xc0) != 0xb0' is always
true.

Source code is

if ((*p & 0xc0) != 0xb0)

Suggest code rework.

2.

[../../../mono/eglib/src/gutf8.c:306]: (style) Expression '(X & 0xc0) == 0xb0'
is always false.
[../../../mono/eglib/src/gutf8.c:331]: (style) Expression '(X & 0xc0) == 0xb0'
is always false.
[../../../mono/eglib/src/gutf8.c:294]: (style) Expression '(X & 0xc0) != 0xb0'
is always true.
[../../../mono/eglib/src/gutf8.c:306]: (style) Expression '(X & 0xc0) == 0xb0'
is always false.
[../../../mono/eglib/src/gutf8.c:331]: (style) Expression '(X & 0xc0) == 0xb0'
is always false.

[Bug 35353] mono/eglib/src/gutf8.c: many bad if expressions ?

http://bugs.winehq.org/show_bug.cgi?id=35353

--- Comment #1 from Vincent Povirk  ---
Upstream bug if anything.

[Bug 35353] mono/eglib/src/gutf8.c: many bad if expressions ?

https://bugs.winehq.org/show_bug.cgi?id=35353

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |UPSTREAM

--- Comment #2 from Austin English  ---
(In reply to Vincent Povirk from comment #1)
> Upstream bug if anything.

UPSTREAM.

[Bug 35353] mono/eglib/src/gutf8.c: many bad if expressions ?

https://bugs.winehq.org/show_bug.cgi?id=35353

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|programs                    |-unknown

[Bug 35353] mono/eglib/src/gutf8.c: many bad if expressions ?

https://bugs.winehq.org/show_bug.cgi?id=35353

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Austin English  ---
Closing.

[Bug 35353] mono/eglib/src/gutf8.c: many bad if expressions ?

https://bugs.winehq.org/show_bug.cgi?id=35353

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |RESOLVED

--- Comment #4 from Austin English  ---
This was inadvertently caught up in my unclosed bugs filter. NOTOURBUG should
only be closed when fixed upstream.

Setting back to RESOLVED NOTOURBUG.

Sorry for the spam.