[Bug 49829] New: file.c:237:37: error: 'EXTATTR_NAMESPACE_USER' undeclared building with GCC 9 and FreeBSD

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49829

Bug ID: 49829
           Summary: file.c:237:37: error: 'EXTATTR_NAMESPACE_USER'
                    undeclared building with GCC 9 and FreeBSD
           Product: Wine-staging
           Version: 5.17
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]
      Distribution: Other

Created attachment 68166
  --> https://bugs.winehq.org/attachment.cgi?id=68166
Excerpt from the failure log

This regression came between version 5.16 and 5.17 and only with
Wine Staging.

I am seeing this on FreeBSD/i386 11.x with GCC 9.

[Bug 49829] file.c:237:37: error: 'EXTATTR_NAMESPACE_USER' undeclared building with GCC 9 and FreeBSD

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49829

--- Comment #1 from Gerald Pfeifer  ---
Still reproduces with Wine 5.18.

[Bug 49829] file.c:237:37: error: 'EXTATTR_NAMESPACE_USER' undeclared building with GCC 9 and FreeBSD

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49829

--- Comment #2 from Gerald Pfeifer  ---
(In reply to Gerald Pfeifer from comment #1)
> Still reproduces with Wine 5.18.

I actually meant: Still reproduces with Wine 5.19.

[Bug 49829] file.c:237:37: error: 'EXTATTR_NAMESPACE_USER' undeclared on FreeBSD

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49829

Gerald Pfeifer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|file.c:237:37: error:       |file.c:237:37: error:
                   |'EXTATTR_NAMESPACE_USER'    |'EXTATTR_NAMESPACE_USER'
                   |undeclared building with    |undeclared on FreeBSD
                   |GCC 9 and FreeBSD           |

--- Comment #3 from Gerald Pfeifer  ---
It turns out this is not specific to GCC, but to building on FreeBSD.

The following addresses part of the issue:

diff -u unix/file.c{.orig,}
--- unix/file.c.orig    2020-10-14 19:03:39.476740000 +0000
+++ unix/file.c    2020-10-14 19:49:03.226593000 +0000
@@ -112,6 +112,9 @@
 #elif defined(HAVE_SYS_XATTR_H)
 #include <sys/xattr.h>
 #endif
+#ifdef HAVE_SYS_EXTATTR_H
+#include <sys/extattr.h>
+#endif
 #include <time.h>
 #ifdef HAVE_UNISTD_H
 # include <unistd.h>

[Bug 49829] file.c:237:37: error: 'EXTATTR_NAMESPACE_USER' undeclared on FreeBSD

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49829

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Alistair Leslie-Hughes  ---
This should now be fixed.

[Bug 49829] file.c:237:37: error: 'EXTATTR_NAMESPACE_USER' undeclared on FreeBSD

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49829

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alistair Leslie-Hughes  ---
Closing bugs fixed in Staging 5.21.