https://bugs.winehq.org/show_bug.cgi?id=44570
Bug ID: 44570 Summary: wine explorer . crashes instead of opening current directly Product: Wine Version: 3.2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: stu.axon@gmail.com Distribution: ---
Created attachment 60537 --> https://bugs.winehq.org/attachment.cgi?id=60537 bactkrace.txt
On windows you can open the file explorer in the current directory like this
explorer .
If I type
wine explorer .
I get a crash.
I also got a crash using
wine explorer $PWD
My current directory is
/home/stu/Downloads/Visual Styles
Opening with the full dos path worked (I have h: mapped to home):
wine explorer h:\Downloads\Visual\ Styles
https://bugs.winehq.org/show_bug.cgi?id=44570
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de Ever confirmed|0 |1 Status|UNCONFIRMED |NEW
--- Comment #1 from Fabian Maurer dark.shadow4@web.de --- Confirming.
https://bugs.winehq.org/show_bug.cgi?id=44570
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |shell32 Summary|wine explorer . crashes |explorer.exe crashes when |instead of opening current |opening Unix file paths |directly |
https://bugs.winehq.org/show_bug.cgi?id=44570
tommywatson coder@tommywatson.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |coder@tommywatson.com
--- Comment #2 from tommywatson coder@tommywatson.com ---
Tracked to this line;
https://source.winehq.org/git/wine.git/blob/HEAD:/programs/explorer/explorer...
SetWindowTextW(This->info->main_window, name);
This->info is corrupt and accessing it causes the crash, this call to IExplorerBrowser_BrowseToObject() calls the callback IExplorerBrowserEventsImpl_fnOnNavigationComplete() with an incorrect "This" pointer.
https://source.winehq.org/git/wine.git/blob/HEAD:/programs/explorer/explorer...
https://bugs.winehq.org/show_bug.cgi?id=44570
--- Comment #3 from tommywatson coder@tommywatson.com --- Created attachment 60663 --> https://bugs.winehq.org/attachment.cgi?id=60663 Patch checks for relative paths
https://bugs.winehq.org/show_bug.cgi?id=44570
tommywatson coder@tommywatson.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #60663|0 |1 is obsolete| |
--- Comment #4 from tommywatson coder@tommywatson.com --- Comment on attachment 60663 --> https://bugs.winehq.org/attachment.cgi?id=60663 Patch checks for relative paths
Patch isn't correct
https://bugs.winehq.org/show_bug.cgi?id=44570
--- Comment #5 from tommywatson coder@tommywatson.com --- Created attachment 60665 --> https://bugs.winehq.org/attachment.cgi?id=60665 Patch
Simpler fix, stays out of dll's, assumes that 'z:' is the unix path on all systems? Seems like it as it's hard coded in ntdll?
dlls/ntdll/server.c: symlink( "/", "dosdevices/z:" );
https://bugs.winehq.org/show_bug.cgi?id=44570
--- Comment #6 from Stuart Axon stu.axon@gmail.com --- Will this behave the same as cmd.exe ?
I have h: mapped to my home directory.
If I'm in cmd.exe and run explorer . will it open in h: or will it run explorer in z:/path/to/home/path/to/folder ?
https://bugs.winehq.org/show_bug.cgi?id=44570
tommywatson coder@tommywatson.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #60665|0 |1 is obsolete| |
--- Comment #7 from tommywatson coder@tommywatson.com --- Created attachment 60672 --> https://bugs.winehq.org/attachment.cgi?id=60672 Show explorer bug
Thanks, the patch didn't handle mapped drives, just stopped the crashes, the code down in shell32, UNIXFS_get_unix_path(), returns a different path when you have another mapped drive so explorer ends up just opening "Desktop" in this case.
I have attached a patch that shows the error, it doesn't fix it, just prints an error before it crashes explaining that the item hasn't been initialised, maybe a developer with a little more knowledge of how it's supposed to work can get an idea.
https://bugs.winehq.org/show_bug.cgi?id=44570
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #8 from Zebediah Figura z.figura12@gmail.com --- Thanks for your work. I've sent a patch which should hopefully fix this in a more complete manner:
https://source.winehq.org/patches/data/142797
This should allow both dots ('explorer . / explorer ..') as well as relative paths ('explorer somedir') to work.
https://bugs.winehq.org/show_bug.cgi?id=44570
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |bd74183b1e9b443e52dedf1842c | |4721a54f9908e Resolution|--- |FIXED
--- Comment #9 from Zebediah Figura z.figura12@gmail.com --- Fixed by bd74183b1e9b443e52dedf1842c4721a54f9908e.
https://bugs.winehq.org/show_bug.cgi?id=44570
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|explorer.exe crashes when |explorer.exe crashes when |opening Unix file paths |opening relative paths
https://bugs.winehq.org/show_bug.cgi?id=44570
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.4.
https://bugs.winehq.org/show_bug.cgi?id=44570
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x
https://bugs.winehq.org/show_bug.cgi?id=44570
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---
--- Comment #11 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bugs included in 3.0.1.
-
wine-bugs＠winehq.org