[Bug 44075] New: Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

Bug ID: 44075
           Summary: Unable to set subsystem version with VC++ 2013
                    link.exe
           Product: Wine
           Version: 2.22
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 59791
  --> https://bugs.winehq.org/attachment.cgi?id=59791
Full build log with all warnings

I'm using VC++ 2013 command-line compilers under Linux with WINE.

I'm specifying /SUBSYSTEM:WINDOWS,5.1 to link.exe to target Windows XP for x86
32 bits.

Unfortunately, when using WINE VC++ runtimes, I got :

LINK : warning LNK4010: invalid subsystem version number 5.1; default subsystem
version assumed

I tried to check what warnings WINE returned but I think the only relevant one
was : fixme:heap:RtlSetHeapInformation (nil) 1 (nil) 0 stub

When I check the PE header of compiled executable, the minimum Windows version
is set to 6.0.

When using native msvcr120.dll by specifying :
export WINEDLLOVERRIDES="msvcr120.dll=n"

Everything link perfectly without warning and the PE headers has Windows 5.1
minimum version.

I attached the full build log with all warnings.

If you need a test case, I can create a small one with required VC++
executables and all files to reproduce the issue.

Thanks :)

[Bug 44075] Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

Cédric OCHS  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 44075] Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |7aa67f1e5f4e0ecafe9fbeec982
                   |                            |326c4d78bf883
         Resolution|---                         |FIXED
                 CC|                            |[e-mail]

--- Comment #1 from Piotr Caban  ---
It works for me with this patch:
7aa67f1e5f4e0ecafe9fbeec982326c4d78bf883 (msvcrt: Fix buffer size checks in
swscanf_s)

Marking as fixed.

[Bug 44075] Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

--- Comment #2 from Cédric OCHS  ---
Wow ! I couldn't imagine it was related to that, but it makes sense :)

Thanks a lot and great job for the fix :)

I'll compile the latest version with your patch :)

[Bug 44075] Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

--- Comment #3 from Cédric OCHS  ---
I compiled the latest version from Git and it works perfectly :)

Thanks again!

[Bug 44075] Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 3.0-rc1.

[Bug 44075] Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 44075] Unable to set subsystem version with VC++ 2013 link.exe

https://bugs.winehq.org/show_bug.cgi?id=44075

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.5.