[Bug 37303] New: Change of paper size in print dialog do not update DEVMODE dmFormName member

https://bugs.winehq.org/show_bug.cgi?id=37303

Bug ID: 37303
           Summary: Change of paper size in print dialog do not update
                    DEVMODE dmFormName member
           Product: Wine
           Version: 1.6.2
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comdlg32
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 49615
  --> https://bugs.winehq.org/attachment.cgi?id=49615
Update dmFormName when changing paper size (patch)

A printer paper size change through the printer dialog of any application do
not update the DEVMODE dmFormName struct member.

How to reproduce:

1. run

WINEDEBUG=+psdrv wine notepad

2. check trace output for the following entry (we assume 'A4' is used)

trace:psdrv:dump_devmode dmPaperSize: 9
    trace:psdrv:dump_devmode dmFormName: L"A4"

3. open print setting
4. change paper size to a different value (for example 'B5')
5. reopen print settings dialog
6. check trace output for the following entry

trace:psdrv:dump_devmode dmPaperSize: 11
    trace:psdrv:dump_devmode dmFormName: L"A4"

-> dmFormName has still the old value

Instead it should have

trace:psdrv:dump_devmode dmFormName: L"B5"

The appended patch fixes this issue.

[Bug 37303] Change of paper size in print dialog do not update DEVMODE dmFormName member

https://bugs.winehq.org/show_bug.cgi?id=37303

--- Comment #1 from Ralf Habacker  ---
Patch has been submitted to wine-devel mailing list.

[Bug 37303] Change of paper size in print dialog do not update DEVMODE dmFormName member

https://bugs.winehq.org/show_bug.cgi?id=37303

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, source
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1

--- Comment #2 from Qian Hong  ---
Confirming. Thanks for report. Patch is not committed.

Could you follow http://wiki.winehq.org/SubmittingPatches and resubmit your
patch to wine-patches mailing list?

Thanks!

[Bug 37303] Change of paper size in print dialog do not update DEVMODE dmFormName member

https://bugs.winehq.org/show_bug.cgi?id=37303

--- Comment #3 from Bruno Jesus  ---
Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=2b9d337f6d7848cde660ddc41c...

[Bug 37303] Change of paper size in print dialog do not update DEVMODE dmFormName member

https://bugs.winehq.org/show_bug.cgi?id=37303

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |printing
      Fixed by SHA1|                            |2b9d337f6d7848cde660ddc41c4
                   |                            |19eaefc446eb9
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Ken Sharp  ---
Should be fixed.

[Bug 37303] Change of paper size in print dialog do not update DEVMODE dmFormName member

https://bugs.winehq.org/show_bug.cgi?id=37303

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.46.