[Bug 57387] New: Sega Rally Championship Demo crashes at startup if Direct3d/renderer set to GDI

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57387

Bug ID: 57387
           Summary: Sega Rally Championship Demo crashes at startup if
                    Direct3d/renderer set to GDI
           Product: Wine
           Version: 9.0-rc3
          Hardware: x86-64
               URL: https://www.classicdosgames.com/game/Sega_Rally_Champi
                    onship.html
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
   Regression SHA1: a6e969560b02ca776f987319db37e6550a1ecfec
      Distribution: Mint

Created attachment 77357
  --> https://bugs.winehq.org/attachment.cgi?id=77357
crash log

I tested this on 64-bit Linux Mint.

steps
1) set registry to use GDI renderer (does not crash if this is not set)
2) install Sega Rally Championship Demo
3) Launch Sega Rally Championship Demo

It crashes immediately during launch

I did a git bisect and after finding the commit, I verified it by checking out
wine-9.0-rc3 and doing a revert for the commit,
a6e969560b02ca776f987319db37e6550a1ecfec, then verifying the game works if
reverted.

I also verified that this game crashes on master (wine-9.20-143-gff2070b7900). 
But I was unable to test reverting the commit on master because of a conflict.

[Bug 57387] Sega Rally Championship Demo crashes at startup if Direct3d/renderer set to GDI

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57387

--- Comment #1 from James Bryant  ---
I verified this is still an issue in Wine 10.0-rc5

I also debugged it a bit more.  In the crash log the blt is using memory after
it was free'd by

void wined3d_resource_free_sysmem(struct wined3d_resource *resource)

with the registry setting Direct3D/renderer=gdi

command I used to launch sega rally

./wine  explorer /desktop=VirtualDesktop,800x600
~/.wine/drive_c/SEGA/SRALLY/RALLY.EXE

[Bug 57387] Sega Rally Championship Demo crashes at startup if Direct3d/renderer set to GDI

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57387

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|-unknown                    |d3d
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 57387] Sega Rally Championship Demo crashes at startup if Direct3d/renderer set to GDI

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57387

Panayiotis Talianos  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Panayiotis Talianos  ---
I confirm, still exists as of commit ccb99cd00f5:
https://gitlab.winehq.org/wine/wine/-/commit/ccb99cd00f5

I've traced the issue and have a fix for it, will open a MR.

[Bug 57387] Sega Rally Championship Demo crashes at startup if Direct3d/renderer set to GDI

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57387

--- Comment #3 from Panayiotis Talianos  ---
Patch: https://gitlab.winehq.org/wine/wine/-/merge_requests/8017