https://bugs.winehq.org/show_bug.cgi?id=43187
Bug ID: 43187 Summary: OriginWebHelperService.exe crashes Product: Wine Version: 2.10 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: plata@mailbox.org Distribution: ---
Created attachment 58460 --> https://bugs.winehq.org/attachment.cgi?id=58460 backtrace
EA Origin installs with Wine 2.10 staging but then crashes in the update or login window (OriginWebHelperService.exe). As a result, the Origin window shows an infinite loading screen.
As far as I can see, this seems to be caused by qt5gui (QScreen::handle).
https://bugs.winehq.org/show_bug.cgi?id=43187
tokktokk fdsfgs@krutt.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs@krutt.org
https://bugs.winehq.org/show_bug.cgi?id=43187
Bernhard Übelacker bernhardu@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu@mailbox.org
--- Comment #1 from Bernhard Übelacker bernhardu@mailbox.org --- Created attachment 59645 --> https://bugs.winehq.org/attachment.cgi?id=59645 Details on the crash and parts of related Qt sources.
It looks like Origin makers decided to use a QGuiApplication in this service. As a result it queries available monitors via EnumDisplayMonitors. Because this runs as a service this is routed to nulldrv_EnumDisplayMonitors which just returns false without calling the callback. Therefore Qt's screen_list never gets filled and later a call to QGuiApplication::primaryScreen()->handle() leads to the crash because primaryScreen() returns null.
https://bugs.winehq.org/show_bug.cgi?id=43187
--- Comment #2 from Bernhard Übelacker bernhardu@mailbox.org --- Created attachment 59646 --> https://bugs.winehq.org/attachment.cgi?id=59646 user32: Let nulldrv return some dummy monitor informations
Attached patch makes OriginWebHelperService.exe not crash.
https://bugs.winehq.org/show_bug.cgi?id=43187
Andrew lordcube777@tutamail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lordcube777@tutamail.com
--- Comment #3 from Andrew lordcube777@tutamail.com --- I had this same bug using wine 2.22-staging on Kubuntu 17.10 and this patch fixed the problem.
https://bugs.winehq.org/show_bug.cgi?id=43187
--- Comment #4 from Andrew lordcube777@tutamail.com --- No longer having this problem with Wine version 3.0-rc1 and I didn't need to use the patch. If someone else can confirm this we can mark this as resolved.
https://bugs.winehq.org/show_bug.cgi?id=43187
--- Comment #5 from Bernhard Übelacker bernhardu@mailbox.org --- @Andrew: You tested with 3.0-rc1 regular or staging? And do you mean with "No longer having this problem" that the Origin window is not stuck in an infinite loading screen?
I run a short test with a self built regular wine, reusing the wineprefix created with 2.20.
Just by starting e.g. "wine wineconsole" I still get the line: wine: Unhandled page fault on read access to ... starting debugger...
Unfortunately the crash dialog "shows" (in regular wine) in the service window station and is therefore not visible for the user. (Bug #35928)
With this patch from staging winedbg is opened in the interactive window station. "kernel32-Debugger/0001-kernel32-Always-start-debugger-on-WinSta0.patch
Then one can still see the crash of OriginWebHelperService.exe with the same callstack as in the first attachement to this bug by user plata.
https://bugs.winehq.org/show_bug.cgi?id=43187
--- Comment #6 from Andrew lordcube777@tutamail.com --- @Bernhard I tested with a self built Wine 3.0-rc1 staging. I used a fresh prefix and no longer have the OriginWebHelperService.exe crash dialog appear. I was also running the legacy version of Origin installed via Luca Weiss's instructions on the Origin appdb page.
I ran $wine '~/.origin/drive_c/Program Files (x86)/Origin.exe' as my command and I didn't see anything in the output about the service crashing. Origin started up and displayed the login window where I could type in my credentials. It is displaying "Online Login is Currently Unavailable" so it may be crashing but just not displaying it as you said. I'll attach my output in case that helps at all. If you would like anything else just let me know I'm happy to help.
Thanks!
https://bugs.winehq.org/show_bug.cgi?id=43187
--- Comment #7 from Andrew lordcube777@tutamail.com --- Created attachment 59924 --> https://bugs.winehq.org/attachment.cgi?id=59924 Consule output from Origin.exe wine 3.0-rc1 staging
https://bugs.winehq.org/show_bug.cgi?id=43187
BieHDC byi5000@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |byi5000@gmail.com
--- Comment #8 from BieHDC byi5000@gmail.com --- Created attachment 59930 --> https://bugs.winehq.org/attachment.cgi?id=59930 my patches
I did the same as Andrew and build my own partially 3.0-rc1 staging (includes most wined3d and dx* commits, half of dll injection related patches in ntdll and some other ones from wine mainline later on and the attached patch here and some other collected patches) and i can confirm Origin working very good. 3/4 starts work fine. downloaded battlefield 1942 through origin and it started fine. right now i am downloading battlefield 3 (on 2nd try of downloading attempt it worked) and see where i go.
first apply on wine-2.21 the staging patches for 2.21 and then these patches on top of it. disclaimer, i am not experienced at all, so dont blame me if something goes very wrong when you apply my hack-fixed patches.
https://bugs.winehq.org/show_bug.cgi?id=43187
Iain iain@daft-ideas.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iain@daft-ideas.co.uk
--- Comment #9 from Iain iain@daft-ideas.co.uk --- (In reply to Andrew from comment #4)
No longer having this problem with Wine version 3.0-rc1 and I didn't need to use the patch. If someone else can confirm this we can mark this as resolved.
I am experiencing this bug on wine-3.16 (Staging) so I don't think it is resolved
https://bugs.winehq.org/show_bug.cgi?id=43187
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Keywords| |download, patch Component|-unknown |user32 Summary|OriginWebHelperService.exe |EA Origin |crashes |'OriginWebHelperService' | |(QGuiApplication) | |non-interactive service | |process crashes due to null | |monitor info when | |determining the primary | |(default) screen URL| |https://www.origin.com/deu/ | |en-us/store/download CC| |focht@gmx.net Ever confirmed|0 |1
--- Comment #10 from Anastasius Focht focht@gmx.net --- Hello folks,
refining summary to reflect the analysis and filling fields. Also confirming on behalf of OP.
Regards
https://bugs.winehq.org/show_bug.cgi?id=43187
--- Comment #11 from Bernhard Übelacker bernhardu@mailbox.org --- Patch and Test sent to wine-devel: https://www.winehq.org/pipermail/wine-devel/2018-September/thread.html#13295...
https://bugs.winehq.org/show_bug.cgi?id=43187
Bernhard Übelacker bernhardu@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #59646|0 |1 is obsolete| |
https://bugs.winehq.org/show_bug.cgi?id=43187
--- Comment #12 from Bernhard Übelacker bernhardu@mailbox.org --- Patches got committed: https://source.winehq.org/git/wine.git/commit/f5bb76f69a96e2b5a5b0953817035a...
https://bugs.winehq.org/show_bug.cgi?id=43187
Jacek Caban jacek@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f5bb76f69a96e2b5a5b09538170 | |35a8cbe94153a Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jacek@codeweavers.com
--- Comment #13 from Jacek Caban jacek@codeweavers.com --- Fixed in Git.
https://bugs.winehq.org/show_bug.cgi?id=43187
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.18.
https://bugs.winehq.org/show_bug.cgi?id=43187
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x
https://bugs.winehq.org/show_bug.cgi?id=43187
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---
--- Comment #15 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bug fixes included in 3.0.5.