[Bug 54054] New: Rayman Origins has messed up rendering

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

Bug ID: 54054
           Summary: Rayman Origins has messed up rendering
           Product: vkd3d
           Version: 1.5
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: vkd3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 73607
  --> https://bugs.winehq.org/attachment.cgi?id=73607
example

vkd3d:fixme:evaluate_array_dimension Unhandled type HLSL_IR_EXPR.
0218:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -4.
0218:err:d3dcompiler:D3DCompile2 Shader log:
0218:err:d3dcompiler:D3DCompile2     <anonymous>:39:16: E5008: Array size is
not a positive integer constant.
0218:err:d3dcompiler:D3DCompile2
0218:err:d3dcompiler:D3DCompile2 Shader log:
0218:err:d3dcompiler:D3DCompile2     <anonymous>:47:16: E5005: Function "tex2D"
is not defined.
0218:err:d3dcompiler:D3DCompile2
0218:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -4.
0218:err:d3dcompiler:D3DCompile2 Shader log:
0218:err:d3dcompiler:D3DCompile2     <anonymous>:166:18: E5005: Function "tan"
is not defined.
0218:err:d3dcompiler:D3DCompile2

vkd3d-1.5-93-g1b11b576

[Bug 54054] Rayman Origins has messed up rendering

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|vkd3d                       |hlsl
                 CC|                            |[e-mail]

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rayman Origins has messed   |Rayman Origins has messed
                   |up rendering                |up rendering due to HLSL
                   |                            |compilation failure 'Array
                   |                            |size is not a positive
                   |                            |integer constant'

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #1 from [e-mail] ---
since there has been lots of shader compiler impro

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]        |

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #2 from Nikolay Sivov  ---
This needs a retest with
https://source.winehq.org/git/vkd3d.git/commit/7d41cf44402d016ae456d45376ee3....
First two errors should be gone now with current vkd3d-shader. Missing "tan"
function is still a problem.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #3 from Gijs Vermeulen  ---
For me, with wine-git and vkd3d-git, the first two are indeed gone. I can't get
the 'tan' message to show up, though.

These ones are new (I think):

<anonymous>:543:1: E5017: Aborting due to not yet implemented feature:
Instruction type HLSL_IR_IF.

<anonymous>:147:21: E5017: Aborting due to not yet implemented feature: SM1
"cos" expression.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #4 from Gijs Vermeulen  ---
I forgot to mention that the game doesn't even launch for me because of:

Assertion failed: hlsl_types_are_equal(if_true->data_type,
if_false->data_type), file ../vkd3d-source/libs/vkd3d-shader/hlsl_codegen.c,
line 2133

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #5 from Nikolay Sivov  ---
(In reply to Gijs Vermeulen from comment #4)
> I forgot to mention that the game doesn't even launch for me because of:
>
> Assertion failed: hlsl_types_are_equal(if_true->data_type,
> if_false->data_type), file ../vkd3d-source/libs/vkd3d-shader/hlsl_codegen.c,
> line 2133

The best option is to dump the shader that's causing this.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #6 from Gijs Vermeulen  ---
Created attachment 74439
  --> https://bugs.winehq.org/attachment.cgi?id=74439
Rayman shaders

Attached are the shaders dumped with VKD3D_SHADER_DUMP_PATH using current
vkd3d-git.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #7 from Nikolay Sivov  ---
(In reply to Gijs Vermeulen from comment #4)
> I forgot to mention that the game doesn't even launch for me because of:
>
> Assertion failed: hlsl_types_are_equal(if_true->data_type,
> if_false->data_type), file ../vkd3d-source/libs/vkd3d-shader/hlsl_codegen.c,
> line 2133

Thanks. This is coming from ternary operator, I'll take a look.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #8 from Nikolay Sivov  ---
The immediate issue was a type mismatch between ternary operator values. I
submitted https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/201 for this.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

--- Comment #9 from Nikolay Sivov  ---
(In reply to Nikolay Sivov from comment #8)
> The immediate issue was a type mismatch between ternary operator values. I
> submitted https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/201 for this.

This is now fixed with dc41444941a633bef522dbcf738d99c8536c6670. Please retest
with current vkd3d git.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from Andrey Gusev  ---
Now it launches with a black screen.

Default output has:

<anonymous>:612:16: W5300: Implicit truncation of matrix type.
<anonymous>:85:24: E5017: Aborting due to not yet implemented feature: SM1
"cast" expression.
<anonymous>:208:20: E5017: Aborting due to not yet implemented feature: SM1
non-float expression.
<anonymous>:208:20: E5017: Aborting due to not yet implemented feature:
Dereference with non-constant offset of type HLSL_IR_EXPR.
<anonymous>:147:21: E5017: Aborting due to not yet implemented feature: SM1
"cos" expression.
vkd3d:fixme:hlsl_fold_constant_exprs Fold "rcp" expression.
<anonymous>:401:24: E5017: Aborting due to not yet implemented feature: SM1
"(null)" expression.
<anonymous>:486:14: E5017: Aborting due to not yet implemented feature:
Instruction type HLSL_IR_IF.
<anonymous>:166:18: E5005: Function "tan" is not defined.

[Bug 54054] Rayman Origins has messed up rendering due to HLSL compilation failure 'Array size is not a positive integer constant'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54054

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Nikolay Sivov  ---
I'm going to close this one. Remaining issues seem to be covered by other
reports.