[Bug 18007] New: Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Summary: Subtitle Workshop "Save as.." selection menu not
                    appearing
           Product: Wine
           Version: 1.1.19
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=20384)
 --> (http://bugs.winehq.org/attachment.cgi?id=20384)
Results of regression test

When using the "Save as" option in Subtitle Workshop a list of the available
formats and a little icon for each one is supposed to appear, it worked fine in
1.1.18 but in 1.1.19 this list and icons fail to show.

Regression test result is attached with a picture of the bug.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #1 from Pat   2009-04-11 17:22:18 ---
Created an attachment (id=20385)
 --> (http://bugs.winehq.org/attachment.cgi?id=20385)
Image of bug

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #2 from Nikolay Sivov   2009-04-11 18:17:56 ---
(In reply to comment #1)
> Created an attachment (id=20385)

--> (http://bugs.winehq.org/attachment.cgi?id=20385) [details]
> Image of bug

Hi, Pat.

First of all two questions:
- does reverting this commit help?
- what program version are you trying?

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #3 from Pat   2009-04-11 18:28:47 ---
Yes when I ran through the test reverting this commit fixed the bug.

Version 2.51

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]        |

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #4 from Nikolay Sivov   2009-04-11 18:36:30 ---
(In reply to comment #3)
> Yes when I ran through the test reverting this commit fixed the bug.
>
> Version 2.51

I see. No sources available I suppose?

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #5 from Pat   2009-04-11 18:54:49 ---
http://www.urusoft.net/download.php?lang=1&id=sw

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20384|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #20384|RegressionTest.log          |RegressionTest.txt
           filename|                            |

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

--- Comment #6 from Austin English   2009-04-11 19:43:06 ---
No need to attach, just put it in as a comment:

59148d0bb549ff8690f15f14571a715e3fdd43a5 is first bad commit
commit 59148d0bb549ff8690f15f14571a715e3fdd43a5
Author: Nikolay Sivov 
Date:   Tue Apr 7 12:15:21 2009 -0400

comctl32/listview: Implement delayed header creation for ListView control.

:040000 040000 917d3c197548165028394f45e22b6d32632f36cd
3df9c0746fceb9202daab94828b78177e4f4c176 M      dlls

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #7 from Nikolay Sivov   2009-04-12 02:09:10 ---
Created an attachment (id=20393)
 --> (http://bugs.winehq.org/attachment.cgi?id=20393)
Fix for 59148d0bb549ff8690f15f14571a715e3fdd43a5

(In reply to comment #5)
> http://www.urusoft.net/download.php?lang=1&id=sw

I meant sources code.

Anyway try this patch.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Pat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Pat   2009-04-12 09:02:51 ---
Patch fixed the bug.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #9 from Nikolay Sivov   2009-04-12 09:50:53 ---
(In reply to comment #8)
> Patch fixed the bug.

Not fixed until patch goes upstream. Reopen it please.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #10 from Vitaliy Margolen   2009-04-12 11:38:52 ---
Reopening.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #11 from Nikolay Sivov   2009-04-13 01:55:13 ---
Fix sent:

http://www.winehq.org/pipermail/wine-patches/2009-April/071795.html

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #12 from Nikolay Sivov   2009-04-13 17:54:46 ---
(In reply to comment #11)
> Fix sent:
>
> http://www.winehq.org/pipermail/wine-patches/2009-April/071795.html

It's obsolete now, use this one:

http://www.winehq.org/pipermail/wine-patches/2009-April/071825.html

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20393|0                           |1
        is obsolete|                            |

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #13 from Nikolay Sivov   2009-04-14 16:05:00 ---
Should be fixed now:
http://source.winehq.org/git/wine.git/?a=commit;h=e014484a4365a49cbd2e62f7df...

Retest please.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

--- Comment #14 from Pat   2009-04-14 22:04:10 ---
Just checked-out the latest source from git, bug is fixed.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Dmitry Timoshkov   2009-04-15 01:10:33 ---
Reported fixed.

[Bug 18007] Subtitle Workshop "Save as.." selection menu not appearing

http://bugs.winehq.org/show_bug.cgi?id=18007

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2009-04-24 12:22:30 ---
Closing bugs fixed in 1.1.20.