[Bug 53082] New: "explorer: Create clipboard manager thread when creating a desktop." causes hangs on wine startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53082

Bug ID: 53082
           Summary: "explorer: Create clipboard manager thread when
                    creating a desktop." causes hangs on wine startup
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: d8a74e5cf9f259c5ec9480e74d286c93609b8d9c
      Distribution: ---

Since this commit, d8a74e5cf9f259c5ec9480e74d286c93609b8d9c "explorer: Create
clipboard manager thread when creating a desktop.", hangs occasionally when
setting up a new wineprefix. (It's possible that it also hangs when starting
wine with a preexisting wineprefix, but I pinpointed it for the init procedure
when setting up a fresh wineprefix.)

I've built wine headless (I only run command line executables), i.e. configured
with "--without-x" (on Linux). I've reproduced this on arm32, but it's
plausible that the same can happen on other architectures, too.

When bootstrapping a new wineprefix (setting WINEPREFIX to a new, nonexistent
directory, running "wine wineboot"), it can hang, printing errors like these:

0048:err:sync:RtlpWaitForCriticalSection section 7BC8A3F0
"../src/dlls/ntdll/loader.c: loader_section" wait timed out in thread 0048,
blocked by 0054, retrying (60 sec)
0048:err:sync:RtlpWaitForCriticalSection section 7BC8A3F0
"../src/dlls/ntdll/loader.c: loader_section" wait timed out in thread 0048,
blocked by 0054, retrying (60 sec)

Did this commit trigger some race condition when bootstrapping the environment?

This issue doesn't happen every time - when testing setup of a new wineprefix,
it happens maybe once in 5-10 attempts.

[Bug 53082] "explorer: Create clipboard manager thread when creating a desktop." causes hangs on wine startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53082

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |7.9
           Keywords|                            |download, regression,
                   |                            |source

[Bug 53082] "explorer: Create clipboard manager thread when creating a desktop." causes hangs on wine startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53082

--- Comment #1 from Martin Storsjö  ---
The same issue also does happen when running with a preexisting wineprefix, but
in those cases, it doesn't seem to block the main foreground task so it's less
noticable - it just leaves the background processes hanging.

I've also reproduced the same issue on aarch64 too (on the same system). (I
don't test nightly wine on x86, but the issue doesn't seem specific to any
architecture, but just like a race condition.)

[Bug 53082] "explorer: Create clipboard manager thread when creating a desktop." causes hangs on wine startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53082

--- Comment #2 from Jacek Caban  ---
Created attachment 72523
  --> https://bugs.winehq.org/attachment.cgi?id=72523
fix

Thanks for the report. I could reproduce the hang. I think the attached patch
should fix it.

[Bug 53082] "explorer: Create clipboard manager thread when creating a desktop." causes hangs on wine startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53082

--- Comment #3 from Martin Storsjö  ---
(In reply to Jacek Caban from comment #2)
> Created attachment 72523 [details]
> fix
>
> Thanks for the report. I could reproduce the hang. I think the attached
> patch should fix it.

Awesome, thanks! It does indeed look like this patch fixes the hang for me.
Thank you!

[Bug 53082] "explorer: Create clipboard manager thread when creating a desktop." causes hangs on wine startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53082

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |40cda88021601c4bfc93db24ba9
                   |                            |b6ddc4b3a5257
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Jacek Caban  ---
Fixed in git:
https://source.winehq.org/git/wine.git/commitdiff/40cda88021601c4bfc93db24ba...

[Bug 53082] "explorer: Create clipboard manager thread when creating a desktop." causes hangs on wine startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53082

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 7.11.