[Bug 29141] New: Regression: Uru crashing on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

Bug #: 29141
           Summary: Regression: Uru crashing on startup
           Product: Wine
           Version: 1.3.33
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msvcrt
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified

After upgrading to wine 1.3.33 (I am compiling wine myself, on Debian testing
64bit, but wine is built as 32bit), Uru [1] stopped working. It now crashes on
startup with some unusable backtrace being shown by the application. The mouse
cursor and keyboard focus is somehow caught inside the Uru window, so I need to
Ctrl+Alt+F2 and kill wine from the outside to use X again - but I think that's
just a consequence of the actual crash.

I did a bisect to 1.3.32, the first bad commit is:
commit f2043352d1bedc31a286facce09d7e644c67b672
Author: Francois Gouget 
Date:   Mon Nov 14 15:10:55 2011 +0100

msvcrt: Give a name to the critical sections.

:040000 040000 084be8bc545218de3739d563f7c8f037b362a1ec
c79e84c96f9b52cd81b375c815fe6ac29edd46a1 M      dlls

I verified that the revision before the given one works, and applying that
change breaks Uru.

[1] AppDB:
http://appdb.winehq.org/objectManager.php?sClass=application&iId=10836
Demo download:
http://www.fileplanet.com/133011/download/Uru:-Ages-Beyond-MYST-Demo

[Bug 29141] Regression: Uru crashing on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

--- Comment #1 from [e-mail] 2011-11-21 13:14:32 CST ---
The problem persists with the current git master
35b9c42f530a9a338eaae928c96bd12c7a3514aa

[Bug 29141] Regression: Uru crashing on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |f2043352d1bedc31a286facce09
                   |                            |d7e644c67b672

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.fileplanet.com/1
                   |                            |33011/download/Uru:-Ages-Be
                   |                            |yond-MYST-Demo
            Summary|Regression: Uru crashing on |Uru crashes on startup
                   |startup                     |

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #2 from Michael Stefaniuc  2011-11-21 15:56:40 CST ---
Confirming. Just reverting the 2nd chunk of the patch fixes it.

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Piotr Caban  2011-11-23 05:35:17 CST ---
I've sent a patch that should fix this problem:
http://source.winehq.org/patches/data/81197

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

--- Comment #4 from Michael Stefaniuc  2011-11-23 15:04:34 CST ---
Piotr,
commit 3fe5e6ee8a89cce691144e0a3d501be43d09c566 makes it actually crash even
earlier with:
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr
0x7e72df9f
There is no backtrace.

Reverting both 3fe5e6ee8a89cce691144e0a3d501be43d09c566 and
f2043352d1bedc31a286facce09d7e644c67b672 makes it work again.

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

--- Comment #5 from Piotr Caban  2011-11-24 05:16:27 CST ---
I've sent another patch for this bug. The demo is not crashing for me, so I was
not able to test it. If it still crashes with this patch
(http://source.winehq.org/patches/data/81236) please attach a relay log.

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

--- Comment #6 from Michael Stefaniuc  2011-11-24 07:49:32 CST ---
Yes, your second patch fixes it for me too. Thanks!

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |66520ea08a5960bc15312dae711
                   |                            |90969de478d66
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Michael Stefaniuc  2011-11-24 15:27:38 CST ---
Patch is in.

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

--- Comment #8 from [e-mail] 2011-11-26 05:01:57 CST ---
I can confirm that the current git master fixes the problem. Thanks a lot :)

[Bug 29141] Uru crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=29141

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2011-12-02 13:33:45 CST ---
Closing bugs fixed in 1.3.34.