http://bugs.winehq.org/show_bug.cgi?id=20303
Summary: Spurious valgrind warning in HEAP_CreateSubHeap? Product: Wine Version: 1.1.29 Platform: PC OS/Version: Linux Status: NEW Keywords: download, source Severity: normal Priority: P2 Component: ntdll AssignedTo: wine-bugs@winehq.org ReportedBy: dank@kegel.com
Running wine's tests under valgrind generates lots of errors like:
Invalid write of size 4 at 0xCC5CE91: HEAP_CreateSubHeap (heap.c:815) by 0xCC5E643: RtlCreateHeap (heap.c:1265) by 0xCC95B0D: thread_init (thread.c:328) by 0xCC67898: __wine_process_init (loader.c:2695) by 0xC52E91A: wine_init (loader.c:711) by 0x7BF01274: main (main.c:218) Address 0x7f00000c is not stack'd, malloc'd or (recently) free'd
Seems like ntdll is missing a valgrind annotation or two...?
http://bugs.winehq.org/show_bug.cgi?id=20303
--- Comment #1 from Dan Kegel dank@kegel.com 2009-10-10 21:27:00 --- Another error with the same root cause:
Invalid write of size 2 at start_vfat_ioctl (directory.c:1046) by find_file_in_dir (directory.c:1748) by wine_nt_to_unix_file_name (directory.c:2111) by FILE_QueryFullAttributesFile (file.c:1977) by NtQueryAttributesFile (file.c:2034) by RtlDoesFileExists_U (directory.c:2204) by RtlDosSearchPath_U (path.c:475) by find_dll_file (loader.c:1833) by load_dll (loader.c:1923) by import_dll (loader.c:538) by fixup_imports (loader.c:711) by LdrInitializeThunk (loader.c:2501) by __wine_kernel_init (process.c:1117) by __wine_process_init (loader.c:2719) by wine_init (loader.c:711) by main (main.c:218) Address 0x7f112008 is not stack'd, malloc'd or (recently) free'd
It seems that NtAllocateVirtualMemory wasn't informing valgrind about the blocks it created. This didn't seem to be a problem with old valgrind, but valgrind at top of tree (and probably 3.5.0) complains. I will attach a patch that fixes the problem here.
http://bugs.winehq.org/show_bug.cgi?id=20303
--- Comment #2 from Dan Kegel dank@kegel.com 2009-10-10 21:29:44 --- Created an attachment (id=24020) --> (http://bugs.winehq.org/attachment.cgi?id=24020) ntdll: add valgrind annotations to NtAllocateVirtualMemory
http://bugs.winehq.org/show_bug.cgi?id=20303
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=20303
--- Comment #3 from Alexandre Julliard julliard@winehq.org 2009-10-11 03:53:31 --- That's just a mmap, surely valgrind should be able to figure this out without help?
http://bugs.winehq.org/show_bug.cgi?id=20303
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID
--- Comment #4 from Dan Kegel dank@kegel.com 2009-10-11 19:40:07 --- Narrowed it down to a particular valgrind commit, filed https://bugs.kde.org/show_bug.cgi?id=210268 with minimal test case.
http://bugs.winehq.org/show_bug.cgi?id=20303
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Dmitry Timoshkov dmitry@codeweavers.com 2009-10-11 23:15:39 --- Closing invalid.
http://bugs.winehq.org/show_bug.cgi?id=20303
--- Comment #6 from Dan Kegel dank@kegel.com 2009-10-20 03:33:40 --- https://bugs.kde.org/show_bug.cgi?id=205541#c1 has the fix for valgrind.
http://bugs.winehq.org/show_bug.cgi?id=20303
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #24020|0 |1 is obsolete| |
http://bugs.winehq.org/show_bug.cgi?id=20303
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |UPSTREAM
--- Comment #7 from Austin English austinenglish@gmail.com 2012-04-01 17:03:26 CDT --- UPSTREAM bug, was fixed in valgrind.
-
wine-bugs＠winehq.org