http://bugs.winehq.org/show_bug.cgi?id=17229
Summary: TGB Dual crashes when opening files Product: Wine Version: 1.1.14 Platform: PC URL: http://appdb.winehq.org/objectManager.php?sClass=applica tion&iId=6468 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comdlg32 AssignedTo: wine-bugs@winehq.org ReportedBy: madewokherd@gmail.com
TGB Dual crashes when attempting to open any file. To reproduce, select the first item in the left-most menu and choose a file (it does not have to be a rom).
http://bugs.winehq.org/show_bug.cgi?id=17229
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #1 from Vincent Povirk madewokherd@gmail.com 2009-02-01 23:41:49 --- Created an attachment (id=19194) --> (http://bugs.winehq.org/attachment.cgi?id=19194) crash log
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2009-02-02 04:02:19 --- Created an attachment (id=19205) --> (http://bugs.winehq.org/attachment.cgi?id=19205) check for NULL in FILEDLG95_OnWMCommand
Hi, Vincent. Try with this. I'm not sure that's correct, but it'll help maybe.
http://bugs.winehq.org/show_bug.cgi?id=17229
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #3 from Vincent Povirk madewokherd@gmail.com 2009-02-08 14:51:26 --- It still crashes, but now it doesn't give me a traceback.
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #4 from Vincent Povirk madewokherd@gmail.com 2010-06-23 14:54:43 --- Still present in wine-1.2-rc4-70-g802c4de.
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #5 from Vincent Povirk madewokherd@gmail.com 2011-03-30 12:57:45 CDT --- Still present in wine-1.3.16-145-g9ea9a05.
http://bugs.winehq.org/show_bug.cgi?id=17229
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=17229
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW URL|http://appdb.winehq.org/obj |http://gigo.retrogames.com/ |ectManager.php?sClass=appli |tgb/tgb_dual_8_3.zip |cation&iId=6468 | CC| |frederic.delanoy@gmail.com Ever Confirmed|0 |1
--- Comment #6 from Frédéric Delanoy frederic.delanoy@gmail.com 2012-03-16 09:34:01 CDT --- Confirmed in wine-1.4-284-gc5faf15
http://bugs.winehq.org/show_bug.cgi?id=17229
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19194|0 |1 is obsolete| |
--- Comment #7 from Frédéric Delanoy frederic.delanoy@gmail.com 2012-03-16 09:35:25 CDT --- Created attachment 39400 --> http://bugs.winehq.org/attachment.cgi?id=39400 terminal + crash log wine 1.4
http://bugs.winehq.org/show_bug.cgi?id=17229
Heejin Park heepark@vassar.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |heepark@vassar.edu
--- Comment #8 from Heejin Park heepark@vassar.edu 2012-05-21 02:43:25 CDT --- Still present in wine-1.5.4
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #9 from lahmbi5675@gmx.de 2012-05-21 04:30:51 CDT --- the download link is broken, the whole site seems down, the emulator can be downloaded at http://www.emulator-zone.com/doc.php/gameboy/tgbdual.html direct link would be http://www.emulator-zone.com/download.php/emulators/gameboy/tgbdual/TGBDUE-7...
http://bugs.winehq.org/show_bug.cgi?id=17229
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://gigo.retrogames.com/ |http://www.emulator-zone.co |tgb/tgb_dual_8_3.zip |m/doc.php/gameboy/tgbdual.h | |tml CC| |00cpxxx@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #10 from Bruno Jesus 00cpxxx@gmail.com 2012-06-09 14:07:32 CDT --- Created attachment 40461 --> http://bugs.winehq.org/attachment.cgi?id=40461 patch to make it work
The attached patch will make the game load files and run. I'm not sure if it's correct or not, the main problem is that ofn->lpstrFile is NULL so the functions PathFindFileNameA and PathFindExtensionA also return NULL. I don't know how it ended up being NULL which is probably the cause of the bug.
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #11 from Bruno Jesus 00cpxxx@gmail.com 2012-06-09 14:23:25 CDT --- The caller didn't allocate space for ofn->lpstrFile so it left it NULL in the structure, then it was not filled due to line 2652. Currently the code assume the variable was set and use it anyway leading to a crash. A correct fix would be to avoid using ofn->lpstrFile and use lpstrPathAndFile directly after proper unicode to char convertion.
http://bugs.winehq.org/show_bug.cgi?id=17229
--- Comment #12 from Bruno Jesus 00cpxxx@gmail.com 2012-06-18 20:31:28 CDT --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2012-June/115131.html
http://bugs.winehq.org/show_bug.cgi?id=17229
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8c5cf7e25f8c547306f37ae151d | |2b4cda712cf47 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #13 from Austin English austinenglish@gmail.com 2012-06-19 16:47:31 CDT --- (In reply to comment #12)
Patch sent: http://www.winehq.org/pipermail/wine-patches/2012-June/115131.html
http://source.winehq.org/git/wine.git/commitdiff/8c5cf7e25f8c547306f37ae151d...
http://bugs.winehq.org/show_bug.cgi?id=17229
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org 2012-06-22 13:31:34 CDT --- Closing bugs fixed in 1.5.7.
http://bugs.winehq.org/show_bug.cgi?id=17229
Dylan swordofsilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |swordofsilence@gmail.com