[Bug 17674] New: wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Summary: wine recaching font metrics on every run
           Product: Wine
           Version: 1.1.16
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

fresh install of OS X, with updates (10.5.6)
fresh git clone and build (wine-1.1.16-292-g1b9a6fb)

every time wine runs it regenerates the cache, which takes roughly 30 seconds

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

--- Comment #1 from Andrew Roth   2009-03-10 20:20:54 ---
Created an attachment (id=19870)
 --> (http://bugs.winehq.org/attachment.cgi?id=19870)
log.txt

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #2 from Vitaliy Margolen   2009-03-10 21:31:53 ---
Duplicate

*** This bug has been marked as a duplicate of bug 17548 ***

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Vitaliy Margolen   2009-03-10 21:32:01 ---
Closing dup

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |t

--- Comment #4 from Jörg Höhle   2009-05-22 04:58:23 ---
I claim this is no duplicate of bug #17548. The others are about Linux and many
fonts, while the OP's log message is particular to MacOS.
As I wrote today 2009-05-19 to wine-devel: wine on MacOS 10.5.7: 3/4 success

"dlopen() searches the following the following until it finds a compatible
Mach-O file: $LD_LIBRARY_PATH, $DYLD_LIBRARY_PATH, current working directory,
$DYLD_FALLBACK_LIBRARY_PATH
Note: There are no configuration files to control dlopen searching."

Set one of those to /usr/X11/lib, because that's where libfreetype*
resides in MacOS. There's no need to turn to MacPorts.

LD_LIBRARY_PATH=/usr/X11/lib ./wine notepad
 lets wine finds hundreds of Apple fonts, the log messages are gone.

BTW, Macports' wrapper uses DYLD_FALLBACK_LIBRARY_PATH

The ./wine wrapper itself sets DYLD_LIBRARY_PATH to its internal .so dir.

Maybe it would not be a good idea to add this directory to the
official ./wine wrapper, as it could cause conflicts with Fink or
Macports sets of libraries?

Or adding that to DYLD_[FALLBACK]_LIBRARY_PATH inside the ./wine wrapper is The
Right Thing to do to solve this issue (no conflicts?). What do MacPorts or Fink
users think?

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

--- Comment #5 from Jörg Höhle   2009-07-06 06:43:38 ---
Created an attachment (id=22215)
 --> (http://bugs.winehq.org/attachment.cgi?id=22215)
patch submitted 2009-07-02 to wine-patches

This patch uses DYLD_FALLBACK_LIBRARY_PATH instead of LD_LIBRARY_PATH.

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Andrew Roth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|DUPLICATE                   |

--- Comment #6 from Andrew Roth   2009-07-13 06:57:54 ---
Reopened as per Jörg's comment and patch.

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Wim Lewis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Wim Lewis   2009-10-06 02:45:08 ---
commit a1c66499bf6b fixes the caching of font metrics on OSX (10.5 et seq.) so
that it does not need to recache on every run. This is separate from the
freetype load-path bug (Wine will now cache the font metrics correctly even if
freetype is not found). So as far as I can tell:

- the problem described in the title of this bug (excessive re-caching making
Wine slow) is fixed;
- the problem described in most of the comments of this bug (Wine not using
freetype and therefore having to cache font metrics in the first place) is not
fixed.

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Dmitry Timoshkov   2009-10-06 04:14:00 ---
(In reply to comment #7)
> - the problem described in the title of this bug (excessive re-caching making
>
> Wine slow) is fixed;

This bug is fixed then.
> - the problem described in most of the comments of this bug (Wine not using
>
> freetype and therefore having to cache font metrics in the first place) is not
> fixed.

Please file a separate bug report for that problem.

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

--- Comment #9 from Jörg Höhle   2009-10-06 06:54:13 ---
Wim,
I was very pleased to read in git that the font caching bug is gone -- and that
there are a few people advancing MacOS issues. Thanks a lot.

Dmitry,
the other issue (Wine not finding FreeType, or for that matter any libraries
not in /usr/lib that Wine tries to use via dlopen) I'm not sure is a Wine bug.
It would likely be rejected, given AJ already rejected my patch in comment #5,
arguing IIRC that the correct PATH ought to come from the invoking environment,
not from within Wine, even though it is very annoying and needs fixing
*somewhere*.  That's why I mentioned DYLD_FALLBACK_LIBRARY_PATH in the Wiki
pages. http://wiki.winehq.org/MacOSX/Building
Hmm, maybe an even better place would be the FAQ?
OTOH, bugzilla is the place people turn to looking for bugs.

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2009-10-09 11:13:55 ---
Closing bugs fixed in 1.1.31.

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Macintosh                   |x86

[Bug 17674] wine recaching font metrics on every run

http://bugs.winehq.org/show_bug.cgi?id=17674

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|Mac OS X 10.5               |Mac OS X

[Bug 17674] wine recaching font metrics on every run

https://bugs.winehq.org/show_bug.cgi?id=17674

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |a1c66499bf6b93bc2c027b5786f
                   |                            |e73615b1f8fb7
          Component|-unknown                    |winex11.drv