[Bug 53677] New: invalid O_WRONLY read sets errno=EACCES instead of EBADF

List overview All Threads

newer

older

[Bug 53100] New: Euphoria: freezes...

[Bug 53932] New: ntlm_auth was not...

WineHQ Bugzilla

14 Sep 2022 14 Sep '22

11:48 a.m.

https://bugs.winehq.org/show_bug.cgi?id=53677

Bug ID: 53677 Summary: invalid O_WRONLY read sets errno=EACCES instead of EBADF Product: Wine Version: 7.17 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: xantares09@hotmail.com Distribution: ---

Created attachment 73089 --> https://bugs.winehq.org/attachment.cgi?id=73089 minimal testcase

I noticed that an incorrect read from a file in write-only mode can result in errno to be set to EACCES instead of EBADF that is returned on native linux or on windows (either msvc or cross-compiled mingw), see attached testcase

$ x86_64-w64-mingw32-gcc main.c $ wine a.exe EBADF=9 EACCES=13 errno=13 errno should be EBADF

whereas on native linux or windows:

...

a

EBADF=9 EACCES=13 errno=9

tested with latest 7.17 on archlinux but also happens with 6.0 on ubuntu jammy

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

WineHQ Bugzilla

14 Sep 14 Sep

11:49 a.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

xantares xantares09@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |ArchLinux

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

20 Sep 20 Sep

3:57 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #1 from xantares xantares09@hotmail.com --- Created attachment 73132 --> https://bugs.winehq.org/attachment.cgi?id=73132 executable file matching testcase source

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3:58 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #2 from xantares xantares09@hotmail.com --- here is the testcase:

``` #include <stdio.h> #include <errno.h> #include <sys/stat.h> #include <fcntl.h>

#ifndef _WIN32 #include <unistd.h> #define POSIX(call) call #else #include <io.h> #define POSIX(call) _##call #endif

int main() { // create a file a write into if const char * path = "test-file"; FILE* fp = fopen(path, "w"); fputs("long live the king", fp); fclose(fp);

// open file in write-only mode int oflag = POSIX(O_WRONLY); #ifndef _WIN32 int perm = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH; #else int perm = _S_IREAD | _S_IWRITE; #endif int fd = POSIX(open(path, oflag, perm)); if (fd < 0) { printf("ERROR open failed\n"); return 1; }

// it should fail to read char buffer = 0; unsigned count = 1; int result = POSIX(read(fd, &buffer, count)); if (result >= 0) { printf("ERROR read should fail\n"); return 1; }

// compare error code mingw->EACCES, linux->EBADF printf("EBADF=%d EACCES=%d\n", EBADF, EACCES); printf("errno=%d\n", errno); if (errno != EBADF) { printf("errno should be EBADF\n"); return 1; }

return 0; } ```

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3:59 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

xantares xantares09@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

xantares xantares09@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4:02 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #3 from xantares xantares09@hotmail.com --- I discussed this previously on the mingw mailing list:

https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/CALK-3m%...

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

27 Sep 27 Sep

2:45 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

xantares xantares09@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard@winehq.org

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

29 Sep 29 Sep

7:34 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

xantares xantares09@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Version|7.17 |7.18

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1 Nov 1 Nov

6:57 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

Piotr Caban piotr.caban@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

2 Nov 2 Nov

3:14 a.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

Fabian Maurer dark.shadow4@web.de changed:

--- Comment #4 from Fabian Maurer dark.shadow4@web.de --- Confirming. Not sure how to best fix it though.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

6:33 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #5 from xantares xantares09@hotmail.com --- thanks, at least I was right

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3 Nov 3 Nov

11:30 a.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #6 from Piotr Caban piotr.caban@gmail.com --- It should be fixed by 3fd47b4663af18d815f85f50c9f343bb6aca7066. Please retest.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

6:27 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #7 from Fabian Maurer dark.shadow4@web.de --- (In reply to Piotr Caban from comment #6)

...

It should be fixed by 3fd47b4663af18d815f85f50c9f343bb6aca7066. Please retest.

Huh, is the file being opened read only really the only case where we can get ERROR_ACCESS_DENIED? I thought there might be others...

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4 Nov 4 Nov

8:57 a.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #8 from Piotr Caban piotr.caban@gmail.com --- (In reply to Fabian Maurer from comment #7)

...

Huh, is the file being opened read only really the only case where we can get ERROR_ACCESS_DENIED? I thought there might be others...

I'm also not sure if the change is correct but there's a big chance it is. Native sets errno, doserrno and GetLastError to EBADF and ERROR_ACCESS_DENIED. Since it's very unlikely that SetLastError is called directly in msvcrt I assume that ReadFile is called. Msvcrt does not store open mode of fd, one would need to call e.g. NtQueryInformationFile to distinguish between ERROR_ACCESS_DENIED errors. Probably the only way of checking it is to create a custom device handle that will return ERROR_ACCESS_DENIED on read. Since it's hard to test and is an unlikely use case I didn't test it.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

7 Nov 7 Nov

7:11 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #9 from xantares xantares09@hotmail.com --- thanks a lot, I'll definetely test this when next version hits the repo

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

18 Nov 18 Nov

3 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

xantares xantares09@hotmail.com changed:

--- Comment #10 from xantares xantares09@hotmail.com --- ok with 7.21

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3:13 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

xantares xantares09@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #11 from xantares xantares09@hotmail.com --- closing

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3:14 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

Gijs Vermeulen gijsvrm@gmail.com changed:

--- Comment #12 from Gijs Vermeulen gijsvrm@gmail.com --- No need to close, FIXED bug reports are closed automatically when the next release goes live.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

22 Nov 22 Nov

12:35 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

--- Comment #13 from xantares xantares09@hotmail.com --- hello,

Similarly I found another incorrect error code:

https://bugs.winehq.org/show_bug.cgi?id=53950

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

25 Nov 25 Nov

11:28 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.22.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

31 Jan 31 Jan

9:57 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |7.0.x

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

20 Apr 20 Apr

7:18 p.m.

New subject: [Bug 53677] invalid O_WRONLY read sets errno=EACCES instead of EBADF

https://bugs.winehq.org/show_bug.cgi?id=53677

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|7.0.x |---

--- Comment #15 from Michael Stefaniuc mstefani@winehq.org --- Drop 7.0.x target milestone from bugs that didn't make it.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

632

Age (days ago)

850

Last active (days ago)

wine-bugs@winehq.org

22 comments

1 participants

tags (0)

participants (1)

WineHQ Bugzilla