[Bug 46712] New: Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Bug ID: 46712
           Summary: Atelier Firis config tool crashes with "Unhandled page
                    fault on execute access"
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 63681
  --> https://bugs.winehq.org/attachment.cgi?id=63681
Terminal outputs

Atelier Firis launches a config tool to change game settings before launching
the actual game. The config tool crashes at startup with the following error:

wine: Unhandled page fault on execute access to 0x400033e0 at address
0x400033e0 (thread 00d8), starting debugger...

I've attached logs with the default terminal output, a +relay output (without
kernel32, advapi32, gdi32, ntdll and winex11) and a +win output. All of the
logs include output from steam as well. The following lines from the +relay
output seem interesting:

00d8:Call user32.SetWindowLongA(000101e2,fffffffc,1400033e0) ret=140004058
00d8:Ret  user32.SetWindowLongA() retval=7f648ef86e32 ret=140004058
00d8:Ret  dialog proc 0x140003c20
(hwnd=0x101dc,msg=WM_INITDIALOG,wp=000101e2,lp=00000000) retval=00000001
result=00000000
00d8:Ret  window proc 0x7f648ef1525a
(hwnd=0x101dc,msg=WM_INITDIALOG,wp=000101e2,lp=00000000) retval=00000001
00d8:Call window proc 0x400033e0
(hwnd=0x101e2,msg=WM_GETDLGCODE,wp=00000000,lp=00000000)
wine: Unhandled page fault on execute access to 0x400033e0 at address
0x400033e0 (thread 00d8), starting debugger...

The relay and win logs were taken on wine 4.0-rc5, but the game still behaves
the same in wine 4.2-staging. I'm using arch-linux, 64bit.
Proton bug report for the game:
https://github.com/ValveSoftware/Proton/issues/1486

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
Odd, it's calling SetWindowLongA (instead of SetWindowLongPtrA) to set a new
window procedure address, but SetWindowLongA is supposed to be only for 32bit
values, so wine is truncating the address.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

--- Comment #2 from Nikolay Sivov  ---
Created attachment 63685
  --> https://bugs.winehq.org/attachment.cgi?id=63685
patch

It looks like 64-bit version simply rejects calls like that. Please try this
patch if you can, it should be expanded for other pointer-sized slots with
proper tests.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.2
          Component|-unknown                    |user32

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from [e-mail] ---
It looks like you forgot "WIN_ReleasePtr( wndPtr );" in your patch, resulting
in a crash with "00ec:err:graphics:USER_CheckNotLock BUG: holding USER lock".

I added "WIN_ReleasePtr( wndPtr );" before the two return statements, and now
the config tool works fine. Thanks for the patch!

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
                 CC|                            |[e-mail]
         Resolution|FIXED                       |---

--- Comment #4 from Józef Kucia  ---
It is not fixed in Wine yet.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

--- Comment #5 from Nikolay Sivov  ---
Ah, thanks. Reopening, since nothing was merged in wine yet.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #6 from Nikolay Sivov  ---
Should be fixed with c2f4e2b338906918c77634631ff82f106570e02e,
d00ed8e7b94390f831873278b399b6862f3cc484. Please test with Wine 4.3.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

--- Comment #7 from [e-mail] ---
Can confirm that the crash is fixed on wine 4.3.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c2f4e2b338906918c77634631ff
                   |                            |82f106570e02e
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Gijs Vermeulen  ---
(In reply to tijs96 from comment #7)
> Can confirm that the crash is fixed on wine 4.3.

In that case marking FIXED, thanks for reporting back.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 4.4.

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.x

[Bug 46712] Atelier Firis config tool crashes with " Unhandled page fault on execute access"

https://bugs.winehq.org/show_bug.cgi?id=46712

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #10 from Michael Stefaniuc  ---
Removing the 4.0.x milestone from bug fixes included in 4.0.2.

[Bug 46712] Atelier Firis config tool crashes with "Unhandled page fault on execute access"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46712

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]