[Bug 10028] New: rappelz updater is slow because of dlls/mshtml/htmlnode.c: get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

Summary: rappelz updater is slow because of
                    dlls/mshtml/htmlnode.c:get_node(...)
           Product: Wine
           Version: CVS/GIT
          Platform: All
               URL: http://rappelz.gpotato.com/download/index.php
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P3
         Component: wine-misc
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

The update for the game rappelz changes the embedded html regularly to update
the progress bar and seems to spend most of it's cpu time on that which seems
to slow the downloading. By using oprofile I found it is spending most of it's
cpu on "if(iter->nsnode == nsnode)" in get_node(...) from
dlls/mshtml/htmlnode.c . The comment above the function already suggests: "We
should use a better data structure or (better) find a way to store
HTMLDOMelement poiner in nsIDOMNode."

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c: get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

Jan Zerebecki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c: get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

booiiing  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

--- Comment #1 from Austin English   2008-12-08 00:52:01 ---
Is this still an issue in current (1.1.10 or newer) wine?

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

--- Comment #2 from Austin English   2009-01-18 03:45:58 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #3 from Austin English   2009-01-18 03:46:06 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |mshtml

--- Comment #4 from Nikolay Sivov   2009-12-29 15:09:09 ---
Most likely still present, searching loop and corresponding commit tells about
possible optimization here.

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

--- Comment #5 from Austin English  2011-08-16 21:30:31 CDT ---
FIXME is still present in 1.3.26 at line 1075, so assuming still present.

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #6 from Austin English  2012-02-23 15:20:01 CST ---
Removing deprecated 'All' Platform/OS.

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

--- Comment #7 from Jacek Caban  2012-07-11 02:20:16 CDT ---
This will be fixed by the new Gecko and associated patches:

http://www.winehq.org/pipermail/wine-devel/2012-July/096192.html

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |12f1fbb7a4f0c6e741275e69eb9
                   |                            |a12c4b32da79d
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Jacek Caban  2012-07-20 05:55:21 CDT ---
Fixed in Git.

[Bug 10028] rappelz updater is slow because of dlls/mshtml/htmlnode.c:get_node(...)

http://bugs.winehq.org/show_bug.cgi?id=10028

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2012-07-31 14:20:33 CDT ---
Closing bugs fixed in 1.5.10.