[Bug 42437] New: Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

https://bugs.winehq.org/show_bug.cgi?id=42437

Bug ID: 42437
           Summary: Wine Wiki: Building Wine - Compiler Optimizations &
                    Call-Stacks
           Product: WineHQ.org
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: www-unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Wiki link:
https://wiki.winehq.org/Building_Wine#Compiler_Optimizations_.26_Call-Stacks

Says:
../wine-source/configure CFLAGS="-g -O1 -fno-optimize-sibling-calls
-fno-omit-frame-pointer -fno-inline"

IMHO these two are superfluous as:
 * "optimize-sibling-calls" is disabled in -O1 and enabled since -O2
 * "omit-frame-pointer" is disabled in -O0, -O1 and -O2

at least by comparing output of following two commands:
gcc -g -O1 -Q --help=common
gcc -g -O1 -fno-optimize-sibling-calls -fno-omit-frame-pointer -fno-inline -Q
--help=common

I tried that on Debian Stretch. Gcc (Debian 6.3.0-6) 6.3.0 20170205

[Bug 42437] Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

https://bugs.winehq.org/show_bug.cgi?id=42437

--- Comment #1 from Rosanne DiMesio  ---
The Building Wine page was written by Kyle Auble; I just ported over what he
wrote. I think the page needs major revision, but I'm not qualified to address
the specific issues you're raising.

You can make corrections yourself. If you tell me your wiki account username, I
can give you edit permission.

[Bug 42437] Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

https://bugs.winehq.org/show_bug.cgi?id=42437

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Austin English  ---
Actually, you may want -Og for that:
  -Og                         Optimize for debugging experience rather than
speed or size.

[Bug 42437] Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

https://bugs.winehq.org/show_bug.cgi?id=42437

--- Comment #3 from Wylda  ---
(In reply to Rosanne DiMesio from comment #1)
> ...but I'm not qualified to address the specific issues you're raising.

Me too. I really have no idea what's correct. I just read that page and tried
to verify that elsewhere.

+ Thanks Austin.

[Bug 42437] Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

https://bugs.winehq.org/show_bug.cgi?id=42437

Kyle Auble  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Kyle Auble  ---
(In reply to Wylda from comment #0)
> Wiki link:
> https://wiki.winehq.org/Building_Wine#Compiler_Optimizations_.26_Call-Stacks
>
> Says:
> ../wine-source/configure CFLAGS="-g -O1 -fno-optimize-sibling-calls
> -fno-omit-frame-pointer -fno-inline"
>
> IMHO these two are superfluous as:
> - "optimize-sibling-calls" is disabled in -O1 and enabled since -O2
> - "omit-frame-pointer" is disabled in -O0, -O1 and -O2

Hi Wylda,

This section of the page came from splicing what was already on the wiki with
info from GCC & Clang docs. I never really bothered to see if they were
redundant because that shouldn't cause any problems, plus I think which
features each -O level enables can vary based on your GCC version and config.

(In reply to Austin English from comment #2)
> Actually, you may want -Og for that:
>   -Og                         Optimize for debugging experience rather than
> speed or size.

Now, this -Og option definitely simplifies things so I've rewritten the
wiki-page to emphasize it. I think it's a relatively new feature (the GCC
release notes mention adding it in v4.8), but I imagine most distros have moved
to that version or newer by now. I've left the table of individual flags as a
note though, mainly to give the reader some context about the debug process.

If that sounds good to everybody, I think we can close the bug.

[Bug 42437] Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

https://bugs.winehq.org/show_bug.cgi?id=42437

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 42437] Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=42437

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Ken Sharp  ---
No response so assuming it's fine.

[Bug 42437] Wine Wiki: Building Wine - Compiler Optimizations & Call-Stacks

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=42437

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Ken Sharp  ---
Closing