[Bug 39118] New: Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

Bug ID: 39118
           Summary: Office 2013 installer fails to start
           Product: Wine
           Version: 1.7.49
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ntdll
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Office 2013 installer fails to start showing message box with text:
"Installation language not supported"

This is a regression caused by:
e67a00b46694625e3c40386008affac42e7e3847 is the first bad commit
commit e67a00b46694625e3c40386008affac42e7e3847
Author: Dmitry Timoshkov 
Date:   Tue Aug 18 15:25:40 2015 +0800

ntdll: Separate image relocation from NtMapViewOfSection.

:040000 040000 57d1c2330c02dd39d3ce5c8b2523c3d510fbc194
ca972ebe981cd75c1f88d4357637ad756bce66b9 M      dlls

Reverting the patch in current wine lets the installer start.

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]
    Regression SHA1|                            |e67a00b46694625e3c40386008a
                   |                            |ffac42e7e3847

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #1 from Dmitry Timoshkov  ---
Is there a free download or demo version to look at?

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #2 from Piotr Caban  ---
(In reply to Dmitry Timoshkov from comment #1)
> Is there a free download or demo version to look at?

No (not one that is working in wine). Only "offline" installer is working in
wine.

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #3 from Dmitry Timoshkov  ---
Could you please generate and attach 2 logs (without and with the patch
applied) +relay,+seh,+tid,+module without the wine start up and with >>
(append) mode.

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #4 from Piotr Caban  ---
Created attachment 52124
  --> https://bugs.winehq.org/attachment.cgi?id=52124
relay,tid,seh,module log (with reverted patch)

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #5 from Piotr Caban  ---
Created attachment 52125
  --> https://bugs.winehq.org/attachment.cgi?id=52125
relay,tid,seh,module log (with patch)

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #6 from Dmitry Timoshkov  ---
Setup fails to load OSETUPUI.DLL from the temporary directory because it's
loaded not at the default base address and that dll lacks relocation info.
Could you please send that dll to me privately, so that I could have a look?

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #7 from Dmitry Timoshkov  ---
Created attachment 52126
  --> https://bugs.winehq.org/attachment.cgi?id=52126
patch

Does the attached patch help?

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #8 from Piotr Caban  ---
> Does the attached patch help?

Yes, thank you.

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #9 from Dmitry Timoshkov  ---
Created attachment 52127
  --> https://bugs.winehq.org/attachment.cgi?id=52127
patch2

I think that this version of the patch is more correct: having a zero-sized
relocation block is OK, but non-zero sized block and zero virtual address
should be considered as an error.

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52126|1                           |0
           is patch|                            |

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

--- Comment #10 from Piotr Caban  ---
The second patch is working as well.

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |7386de357f61094d6a32dbd3c0a
                   |                            |b8bbed3436f6c
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Dmitry Timoshkov  ---
The fix was committed as 7386de357f61094d6a32dbd3c0ab8bbed3436f6c.

[Bug 39118] Office 2013 installer fails to start

https://bugs.winehq.org/show_bug.cgi?id=39118

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.50.