[Bug 16607] New: Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Summary: Sound broken in World of Warcraft
           Product: Wine
           Version: CVS/GIT
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dsound
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

After
ce06de420874b9983324508f8257a580fee341ca is first bad commit
commit ce06de420874b9983324508f8257a580fee341ca
Author: Reece Dunn 
Date:   Mon Dec 22 13:33:43 2008 +0000

dsound: Correct the dsound fraglen calculations.

the sound in World of Warcraft is broken for me. (nothing played)

Testing is possibe at the login screen.

the old version of DSOUND_fraglen had input nSamplesperSec=48000 and
nBlockAlign=4 and returned 1024 while the new version returns 2048

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Karsten Elfenbein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail]  2008-12-23 20:59:06 ---
Also happens under S.T.A.L.K.E.R. SoC.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |1.1.11

--- Comment #2 from Vitaliy Margolen   2008-12-23 21:38:33 ---
Did you removed/disabled pulseaudio?

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #3 from [e-mail]  2008-12-23 22:31:36 ---
gentoo-pc ~ $ pgrep pulseaudio
gentoo-pc ~ $

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Adys  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adys.wh+winehqdotorg@gmail.c
                   |                            |om

--- Comment #4 from Adys   2008-12-24 00:03:50 ---
Confirming, sort of. I have pulseaudio installed.
The good news is I don't get any stutter with pulseaudio anymore. The bad news
is that if I kill pulseaudio (which used to make wow's sound play smooth), I
don't get any sound, which is probably what you're getting.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Ben Klein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Ben Klein   2008-12-24 00:39:51 ---
Standard procedure with sound in wine:
1) Kill or completely remove pulseaudio
2) Configure winecfg to use ALSA driver
3) On the odd occasion that ALSA driver doesn't work, try it out with OSS
driver
4) Blame Ubuntu :P

I've heard that you can't really kill pulseaudio in Ubuntu without removing it
via the package manager (which will also remove the ubuntu-desktop
metapackage). I've also heard that removing pulseaudio breaks recent (latest?)
versions of Ubuntu. Might be related ...

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #6 from Karsten Elfenbein   2008-12-24 04:14:48 ---
oh forgot to mention that I use alsa for sound output

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #7 from Maarten Lankhorst   2008-12-24 05:11:29 ---
Created an attachment (id=18168)
 --> (http://bugs.winehq.org/attachment.cgi?id=18168)
Revert patch

Test this patch

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #8 from M.Kiesel   2008-12-24 06:10:40 ---
Maarten's patch works for me. Note it's not a revert of Reece's patch despite
its naming.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #9 from Karsten Elfenbein   2008-12-24 06:33:20 ---
it's working here as well

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #10 from Karsten Elfenbein   2008-12-24 06:34:58 ---
but isn't 14/2=7 ?

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #11 from Vitaliy Margolen   2008-12-24 21:23:10 ---
(In reply to comment #7)
> Created an attachment (id=18168)

--> (http://bugs.winehq.org/attachment.cgi?id=18168) [details]
> Revert patch
>
> Test this patch

So what's this patch does? All it seems to me that you guys playing with "magic
numbers". Only those number don't work on all system. Which indicate something
isn't right with all of those systems. And surprise surprise they all have
pulseaudio!

Oh and everything still perfectly works with pure AlSA.

Closing invalid - file bug with ubuntu's broken pulseaudio!

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Vitaliy Margolen   2008-12-24 21:23:17 ---
Closing

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #13 from Adys   2008-12-24 22:35:24 ---
(In reply to comment #11)
> (In reply to comment #7)
> > Created an attachment (id=18168)

--> (http://bugs.winehq.org/attachment.cgi?id=18168) [details] [details]
> > Revert patch
> >
> > Test this patch
>
> So what's this patch does? All it seems to me that you guys playing with "magic
> numbers". Only those number don't work on all system. Which indicate something
> isn't right with all of those systems. And surprise surprise they all have
> pulseaudio!
>
> Oh and everything still perfectly works with pure AlSA.
>
> Closing invalid - file bug with ubuntu's broken pulseaudio!

Vitaliy, the reporter does not have pulseaudio and is using gentoo. 
I'm using Pulseaudio and it works fine here. The bug is valid.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Karsten Elfenbein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #14 from Karsten Elfenbein   2008-12-25 15:54:16 ---
still using alsa and still broken without Maarten's patch

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #15 from Ben Klein   2008-12-25 19:00:30 ---
(In reply to comment #14)
> still using alsa and still broken without Maarten's patch

Is pulseaudio installed and running? I ask because sometimes (but not always)
you can get ALSA connections via pulse.

(In reply to comment #13)
> (In reply to comment #11)
> > So what's this patch does? All it seems to me that you guys playing with "magic
> > numbers". Only those number don't work on all system. Which indicate something
> > isn't right with all of those systems. And surprise surprise they all have
> > pulseaudio!
> >
> > Oh and everything still perfectly works with pure AlSA.
> >
> > Closing invalid - file bug with ubuntu's broken pulseaudio!
>
> Vitaliy, the reporter does not have pulseaudio and is using gentoo. 
> I'm using Pulseaudio and it works fine here. The bug is valid.

What exactly "works fine here"?

This bug is valid if it is reproducable on a system that does not have
pulseaudio (or other sound daemons) running, since the report is about ALSA
output. So far, no one has said explicitly whether pulseaudio is running -
saying "ALSA output" is not enough, since this only means winealsa.drv is being
used.

If someone can find a (preferably small) downloadable application that exhibits
the bug, I'd be happy to test it on my systems.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #16 from Karsten Elfenbein   2008-12-26 04:38:59 ---
no pulseaudio is not even installed

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #17 from [e-mail]  2008-12-26 09:00:26 ---
Actually, I explicitly said that pulseaudio was not active on my system. I
don't even have it installed.

Bug is valid.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #18 from Vitaliy Margolen   2008-12-26 11:59:57 ---
Adys,
Stop posting into bugs that have absolutely nothing to do with your problems!

Maarten,
I still don't see what exactly are you changing? Why making queue smaller will
"fix" absent sound?

Stalker SoC works fine here with ALSA in latest git.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Johannes Holzfuß  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Johannes Holzfuß   2008-12-26 13:49:59 ---
> If someone can find a (preferably small) downloadable application that exhibits
> the bug, I'd be happy to test it on my systems.

Hi. I first noticed the bug on my system with foobar2000, which can be
downloaded at http://www.foobar2000.org/. It seems to run through songs much,
much faster than usual (4-6x) but no sound is actually output (default
installation).

Starting a game (Warhammer 40000: Dawn of War) runs through the intro video
about twice as fast as is usual, and does not output sound either.

Reverting commit ce06de420 fixes all that, and it works perfectly again.

Having said that, I'm using Ubuntu and haven't touched the sound configuration
(either in Wine or the system itself), which probably means I am using
PulseAudio.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #20 from Johannes Holzfuß   2008-12-26 15:06:15 ---
Sorry for the double post.

I also tried the patch above, and it seems to fix the problem for me, too.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #21 from M.Kiesel   2008-12-26 17:17:30 ---
To clarify my comment: I'm also using ALSA (only - no PulseAudio, not even OSS
compatibility modules). Reece's patch broke sound in Prince of Persia SoT and
WW for me. Maarten's patch fixed it. I don't know why *larger* buffers are an
issue here, either, but they are.

For completeness, SoT with Reece's patch wasn't completely silent but
stuttering faint sound was playing (sometimes).

I guess this bug might also be related to the sound card used
(snd_hda_intel/ATI SBx00 Azalia here).

Strange there's no word from Reece here...

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #22 from M.Kiesel   2008-12-26 22:05:27 ---
I just noticed that with Reece's commit, audio in Supreme Commander works for
me (with "Audio Hardware Acceleration: Emulation" setting). Previously (without
Reece's commit), that was stuttering a lot. Adding Maarten's patch is fine,
too. I vote for Reece+Maarten ;-).

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

John Beaulieu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #23 from John Beaulieu   2008-12-27 00:52:00 ---
*** This bug has been confirmed by popular vote. ***

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #24 from Adys   2008-12-27 02:57:41 ---
(In reply to comment #18)
> Adys,
> Stop posting into bugs that have absolutely nothing to do with your problems!

What kind of comment is that Vitaliy? I'm leaving my own feedback. If you are
trying to get users away from bugzilla please do so right on the home page.

Again, this is not the place to do personal accusations. Nothing will be
achieved out of it.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #25 from [e-mail]  2008-12-27 07:24:26 ---
Interesting. I also use HDA Intel (onboard), specifically:
http://pastebin.com/m30a161a9 .. correlation?

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Reece Dunn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #26 from Johannes Holzfuß   2008-12-27 08:45:53 ---
For what it's worth, I'm also using onboard Intel HDA:
http://pastebin.com/fb4a3095

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #27 from Ben Klein   2008-12-27 16:40:14 ---
To me, this now looks like a conflict between Reece's commit and ALSA's
snd-intel-hda. Is anyone with this problem NOT using snd-intel-hda? I'm
interested to see what snd-intel8x0 (or whatever it's called) does, since
that's the precursor to intel-hda.

I have an snd-intel-hda laptop and an snd-emu10k1 desktop, so I'll be trying to
verify that this is a conflict with intel-hda and not a generic problem with
Wine (when I get time :) ). It'd be good if people with other soundcards,
preferably a mix of those with hardware mixing and software mixing (via dmix
plugin for ALSA and not pulseaudio or other daemons) could test Reece's patch
too.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #28 from Reece Dunn   2008-12-28 09:45:44 ---
This bug is valid. I found that commit dc224421416bd2616bfd52431388a6f9630bc860
("dsound: Tune some parameters to make pulseaudio work.") broke dsound for
pulseaudio, but only reverted (and cleaned up) the DSOUND_fraglen part of that
patch.

Talking with Maarten on IRC, what I did was increased the overall latency.
dc2244.. halved the period (DSOUND_fraglen) and doubled the length (the
variables in dsound_main.c). My patch doubled the period, but did not halve the
length.

The patch that Maarten has posted here completes the revert of dc2244.., which
is why it is called a revert even though it does not revert my patch! I have
tested Maarten's patch on a system with pulseaudio, and Ack the fix - it works
with various dsound games.

Also, this fixes the remaining sound issues reported by Carl on bug 15559.

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Kevin Meyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #29 from Kevin Meyer   2008-12-28 17:14:42 ---
I can confirm this using the newest GIT available (as of this writing) for
fallout 3

soundsystem = ALSA
soundcard = snd-hda-intel/azalia
distro = Kubuntu 8.10

winecfg
hardware acceleration = full
sample rate = 48000
bits per sample = 16

personally I'd label this a major regression

on an additional note, a sound in fallout 3 will play everynow and then, like
you might hear a single bullet hit the walls (and no more), a single footstep
of all taken, etc

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #30 from Reece Dunn   2008-12-28 22:28:00 ---
Kevin: does the "Revert patch" patch attached here fix the sound issues for
you?

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #31 from Kevin Meyer   2008-12-28 22:54:30 ---
(In reply to comment #30)
> Kevin: does the "Revert patch" patch attached here fix the sound issues for
> you?

before applying the patch, I should note that audio playback returns to normal
if I set the acceleration level to "emulation"

with the patch and while at full hardware audio acceleration, the audio is also
fixed for me

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Todd Mokros  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #32 from M.Kiesel   2009-01-02 15:49:12 ---
Looks like 1.1.12 includes Maarten's fix:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=94c620cf95ed31add0e5ef...

So everything should be fine now...?

Still, I wonder why Maarten's patch from August 2008
http://source.winehq.org/git/wine.git//wine.git?a=commit;h=dc224421416bd2616...
said it fixes pulseaudio but it doesn't (see comment #28).

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

--- Comment #33 from M.Kiesel   2009-01-02 16:37:45 ---
Audio seems to be okay again with 1.1.12. intel-hda, ALSA-only here. Tested
with Prince of Persia: Sands of Time (which was broken by the December commit)
and Supreme Commander (which now has sound again that was stuttering a lot
probably since the August commit, both with Intel HDA and ES1370 sound cards).

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Karsten Elfenbein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #34 from Karsten Elfenbein   2009-01-03 05:12:53 ---
the patch is in git and working fine

[Bug 16607] Sound broken in World of Warcraft

http://bugs.winehq.org/show_bug.cgi?id=16607

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #35 from Roderick Colenbrander   2009-01-03 15:52:02 ---
Closing the bug.