[Bug 32687] New: Win7 psdk fails to install: "SDKSetup encountered an error: Parameter is not valid."

http://bugs.winehq.org/show_bug.cgi?id=32687

Bug #: 32687
           Summary: Win7 psdk fails to install: "SDKSetup encountered an
                    error: Parameter is not valid."
           Product: Wine
           Version: 1.5.10
          Platform: x86-64
               URL: http://www.microsoft.com/downloads/details.aspx?Family
                    ID=c17ba869-9671-4330-a63e-1fd44e0e2505&displaylang=en
        OS/Version: Linux
            Status: NEW
          Keywords: download, Installer, regression
          Severity: minor
          Priority: P2
         Component: gdiplus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 938d42c1480fbc7c80a4db187a29148a7742e219

Created attachment 43128
  --> http://bugs.winehq.org/attachment.cgi?id=43128
+gdiplus,+tid

Regression, introduced by:
austin@aw25 ~/wine-rt $ git bisect good
938d42c1480fbc7c80a4db187a29148a7742e219 is the first bad commit
commit 938d42c1480fbc7c80a4db187a29148a7742e219
Author: Dmitry Timoshkov 
Date:   Wed Aug 15 12:10:08 2012 +0900

gdiplus: When there is no target rectangle specified DrawImage should scale
image to device dpi.

:040000 040000 0f0fc68c618405366dc3f6e709a26ec3ff7ebcec
4fa9b0c78ab1a5d293caa150569d6b577638208f M    dlls

to reproduce:
winetricks -q psdkwin7

Still in wine-1.5.21-80-g082f989.

winetricks gdiplus works around it. +gdiplus,+tid trace attached.

[Bug 32687] Win7 psdk fails to install: "SDKSetup encountered an error: Parameter is not valid."

http://bugs.winehq.org/show_bug.cgi?id=32687

--- Comment #1 from Dmitry Timoshkov  2013-01-08 22:53:14 CST ---
The problem is that resolution of a .bmp image loaded from stream is 0/0,
and it's not clear whether a WIC .bmp decoder should set it to some valid
resolution, or gdiplus should handle this case gracefully.

[Bug 32687] Win7 psdk fails to install: "SDKSetup encountered an error: Parameter is not valid."

http://bugs.winehq.org/show_bug.cgi?id=32687

--- Comment #2 from Vincent Povirk  2013-01-08 23:23:25 CST ---
Feel free to write a test case, but my guess is that the decoder should always
return a valid resolution, falling back to 96/96 if necessary.

[Bug 32687] Win7 psdk fails to install: "SDKSetup encountered an error: Parameter is not valid."

http://bugs.winehq.org/show_bug.cgi?id=32687

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8d72c2771dd134c2595c83a383b
                   |                            |3c1fb3ab506eb
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Dmitry Timoshkov  2013-01-09 21:10:56 CST ---
Should be fixed now.

[Bug 32687] Win7 psdk fails to install: "SDKSetup encountered an error: Parameter is not valid."

http://bugs.winehq.org/show_bug.cgi?id=32687

--- Comment #4 from Austin English  2013-01-09 23:06:15 CST ---
(In reply to comment #3)
> Should be fixed now.

Yep, thanks.

[Bug 32687] Win7 psdk fails to install: "SDKSetup encountered an error: Parameter is not valid."

http://bugs.winehq.org/show_bug.cgi?id=32687

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-01-18 14:57:22 CST ---
Closing bugs fixed in 1.5.22.