[Bug 48072] New: Textures not working correctly after commit a838e144dcaa55e227d7e99566a59f7a31d97227

List overview All Threads

newer

older

[Bug 33284] New: Direct3D(maybe...

[Bug 23729] New: Need for Speed:...

WineHQ Bugzilla

10 Nov 2019 10 Nov '19

8:46 p.m.

https://bugs.winehq.org/show_bug.cgi?id=48072

Bug ID: 48072 Summary: Textures not working correctly after commit a838e144dcaa55e227d7e99566a59f7a31d97227 Product: Wine Version: 4.17 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: tramtrist@tramtrist.com Distribution: ---

Created attachment 65622 --> https://bugs.winehq.org/attachment.cgi?id=65622 texture bug from 4.17

See attached: Floor and sky textures in everquest trilogy for Everquest Classic not working from >= 4.17 4.16 worked fine. Guessing commit a838e144dcaa55e227d7e99566a59f7a31d97227 is breaking the textures in sky/ground

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

WineHQ Bugzilla

10 Nov 10 Nov

8:57 p.m.

New subject: [Bug 48072] Textures not working correctly after commit a838e144dcaa55e227d7e99566a59f7a31d97227

https://bugs.winehq.org/show_bug.cgi?id=48072

Steve tramtrist@tramtrist.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |tramtrist@tramtrist.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

11 Nov 11 Nov

1:27 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

Austin English austinenglish@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1:41 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #1 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Steve from comment #0)

...

Guessing commit a838e144dcaa55e227d7e99566a59f7a31d97227

Could you do a regression test to find out for sure? See: https://wiki.winehq.org/Regression_Testing

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

12 Nov 12 Nov

7:39 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #2 from Steve tramtrist@tramtrist.com --- Working on it.. though it's a bit out of my league :/

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

7:50 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

Ken Sharp imwellcushtymelike@gmail.com changed:

--- Comment #3 from Ken Sharp imwellcushtymelike@gmail.com --- 1. Checkout commit a838e144dcaa55e227d7e99566a59f7a31d97227 2. Compile and test 3. Revert commit a838e144dcaa55e227d7e99566a59f7a31d97227 4. Compile and test

Easy.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

14 Nov 14 Nov

2:29 a.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #4 from Steve tramtrist@tramtrist.com --- I have run the bisect until I found the commit which cause the issue. 96547e622b04f403bc0c78d649275d1f844ed40e seems to have done it. I can revert that commit and cause the issue

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3:34 a.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

Zebediah Figura z.figura12@gmail.com changed:

--- Comment #5 from Zebediah Figura z.figura12@gmail.com --- Here's hoping this one isn't too far over my head. Can you please attach a log with WINEDEBUG=+ddraw,+d3d8,+d3d9,+d3d?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

11:45 a.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #6 from Steve tramtrist@tramtrist.com --- Created attachment 65666 --> https://bugs.winehq.org/attachment.cgi?id=65666 Log for commit 96547e622b04f403bc0c78d6492

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4:05 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

Zebediah Figura z.figura12@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4:28 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #7 from Zebediah Figura z.figura12@gmail.com --- Created attachment 65668 --> https://bugs.winehq.org/attachment.cgi?id=65668 patch

Can you please try the attached patch?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4:51 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #8 from Steve tramtrist@tramtrist.com --- Apply it to which version? Latest?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4:54 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #9 from Zebediah Figura z.figura12@gmail.com --- (In reply to Steve from comment #8)

...

Apply it to which version? Latest?

Yes, or at any rate a version after the offending commit.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

6:01 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #10 from Steve tramtrist@tramtrist.com --- Yep that fixed it... attaching new log.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

6:02 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #11 from Steve tramtrist@tramtrist.com --- Created attachment 65671 --> https://bugs.winehq.org/attachment.cgi?id=65671 log after patch

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

6:28 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #12 from Steve tramtrist@tramtrist.com --- I applied the patch right after the commit which broke it.

I'll rebase the source and apply it to 4.19 latest tonight.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:05 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #13 from tram tramtrist@tramtrist.com --- Ya this worked in 4.19 with the patch applied. Good to go I'd say. Can the developer explain how the patch worked/what caused the issue just for my education? Thanks :)

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

15 Nov 15 Nov

12:56 a.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

--- Comment #14 from Zebediah Figura z.figura12@gmail.com --- (In reply to tram from comment #13)

...

Ya this worked in 4.19 with the patch applied. Good to go I'd say. Can the developer explain how the patch worked/what caused the issue just for my education? Thanks :)

Sure. wined3d has an internal "command stream" thread, which serves the dual purpose of serializing commands sent by multiple client d3d threads, and improving performance by allowing those threads to execute asynchronously. Because of its asynchronicity, the command stream thread has its own state. That state doesn't carry a reference to resources which have a reference count attached (e.g. textures), I think because destruction of resources also has to go through the command stream.

When IDirectDraw7::SetCooperativeLevel() is called, we (among other things) tear down and recreate the wined3d device. Commit 96547e622 fixed an error where the CS might try to use a resource after it had been freed, since state_cleanup() releases all resources bound to the current state in the wined3d_device, but previously no corresponding call was made for the CS.

However, it in turn did not get rid of the discrepancy between device state cleanup and CS state cleanup—since wined3d_cs_reset_state() resets *all* state, but state_cleanup() only resets allocated resources. Now the CS is holding the default state, whereas the device is holding stale sampler state. In practice, this wouldn't matter—another part of SetCooperativeLevel() is restoring the state from before it was called—except that the functions that set state skip doing anything (including signaling the CS) if the device already has that state.

So, in summary, before 96547e622, both bugs cancelled each other out: wined3d_device_set_sampler_state() didn't update the CS state, but the CS state was stale and so was correct anyway. 96547e622 fixed the second bug; the attached patch essentially fixes the first, by making sure that the device state is completely reset to the default state.

That may have been a bit long-winded, but I tried to include all the context necessary for a newcomer to understand the problem.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1 a.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

tram tramtrist@tramtrist.com changed:

--- Comment #15 from tram tramtrist@tramtrist.com --- See comments below.. Attached patch has fixed the issue. Please apply in next release.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1:20 a.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

Zebediah Figura z.figura12@gmail.com changed:

--- Comment #16 from Zebediah Figura z.figura12@gmail.com --- We don't mark bugs FIXED until a patch has been applied.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

11:47 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

Zebediah Figura z.figura12@gmail.com changed:

--- Comment #17 from Zebediah Figura z.figura12@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/7b1581a7841a94bb4f4aa27bfa6125d749afa433.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

29 Nov 29 Nov

7:18 p.m.

New subject: [Bug 48072] Everquest Classic: Textures not working correctly

https://bugs.winehq.org/show_bug.cgi?id=48072

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #18 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.21.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1852

Age (days ago)

1871

Last active (days ago)

wine-bugs@winehq.org

21 comments

1 participants

tags (0)

participants (1)

WineHQ Bugzilla