http://bugs.winehq.org/show_bug.cgi?id=24754
Summary: Nancy Drew "Tale of the Twister" demo text not rendered Product: Wine Version: 1.3.5 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3dx9 AssignedTo: wine-bugs@winehq.org ReportedBy: dank@kegel.com CC: wine-bugs@winehq.org
Here's where to get the game: http://www.herinteractive.com/games/tot/TOT_demo.zip 09c8e2180399462e6d5936d12341b6c8840ec730 TOT_demo.zip
With today's git and Matteo's four patch series (starting with http://www.winehq.org/pipermail/wine-patches/2010-October/094566.html ) the game runs well.. but there's no text. Looks like it uses ID3DXFont.
Tony implemented that a while ago, see http://neobrain.wordpress.com/2009/06/06/font-goodness-cleanup/ http://repo.or.cz/w/wine/d3dx9TW.git/commitdiff/4e4e47bf0ba3236713472dfe5027...
so perhaps we're not far from having these apps fully working.
http://bugs.winehq.org/show_bug.cgi?id=24754
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.herinteractive.c | |om/games/tot/TOT_demo.zip
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #1 from Dan Kegel dank@kegel.com 2010-10-15 13:25:09 CDT --- (I should have mentioned, this is the next problem after bug 6548 for this game).
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #2 from Dan Kegel dank@kegel.com 2010-10-15 15:51:20 CDT --- Created an attachment (id=31282) --> (http://bugs.winehq.org/attachment.cgi?id=31282) Tony's four font patches, rediffed against 1.3.5
Looking at http://repo.or.cz/w/wine/d3dx9TW.git/shortlog/refs/heads/font it seems there are only four patches needed. Here's an attempted rediff (the first one isn't a git patch, sorry). This improves the behavior of the app slightly - the mouseover boxes now look the right width - but there's still no text.
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #3 from Dan Kegel dank@kegel.com 2010-10-15 16:03:11 CDT --- Oh, and 'winetricks d3dx9_36' works around the text problem.
http://bugs.winehq.org/show_bug.cgi?id=24754
Tony Wasserka tony.wasserka@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tony.wasserka@freenet.de
--- Comment #4 from Tony Wasserka tony.wasserka@freenet.de 2010-10-16 12:29:45 CDT --- Should've mentioned that you'll need a fix for ID3DXSprite as well. I didn't commit that one, yet, iirc. http://repo.or.cz/w/wine/d3dx9TW.git/commit/e4dfdb7c2cc4264bbe89ef938c939a39... Try again with that, should work now. Anyway, tell me if it doesn't or if there's some minor glitches/differences to the native dll.
http://bugs.winehq.org/show_bug.cgi?id=24754
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |matteo.mystral@gmail.com
--- Comment #5 from Matteo Bruni matteo.mystral@gmail.com 2010-10-16 18:29:54 CDT --- (In reply to comment #4)
Should've mentioned that you'll need a fix for ID3DXSprite as well. I didn't commit that one, yet, iirc. http://repo.or.cz/w/wine/d3dx9TW.git/commit/e4dfdb7c2cc4264bbe89ef938c939a39...
That patch should roughly have the same end effect as http://www.winehq.org/pipermail/wine-patches/2010-October/094567.html, which Dan included in his test run. I gave a try using your patch instead of mine, I get the same end result (keeping in mind that I may have made mistakes while rebasing/updating your patch). Actually it's not exact that no text at all is rendered on screen. Some text does appear, I see it in the journal (second button from the left) and in the load window. So, there are still some bugs around (probably in ID3DXFont or ID3DXSprite) but your patches do work. :)
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #6 from Tony Wasserka tony.wasserka@freenet.de 2010-10-31 04:56:43 CDT --- Turns out that inserting
D3DLOCKED_RECT lr; IDirect3DTexture9_LockRect((LPDIRECT3DTEXTURE9) This->pTexture, 0, &lr, NULL, 0); IDirect3DTexture9_UnlockRect((LPDIRECT3DTEXTURE9) This->pTexture, 0);
after the GetGlyphData call in DrawTextW() fixes this issue...
Maybe the dirty rect doesn't get updated properly or something? Try using IDirect3DTexture9_AddDirtyRect((LPDIRECT3DTEXTURE9)This->pTexture, NULL); instead of the above code...
http://bugs.winehq.org/show_bug.cgi?id=24754
Travis Athougies iammisc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iammisc@gmail.com
--- Comment #7 from Travis Athougies iammisc@gmail.com 2010-10-31 16:53:43 CDT --- I tried to call IDirect3DTexture9_AddDirtyRect but that did nothing. For some unknown reason, the patch I've attached fixes the issue, even though the IDirect3DTexture9_GetSurfaceLevel call does indeed fail...
This is quite inexplicable
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #8 from Travis Athougies iammisc@gmail.com 2010-10-31 16:54:11 CDT --- Created an attachment (id=31632) --> (http://bugs.winehq.org/attachment.cgi?id=31632) fixes the issue, but for an unknown reason
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #9 from Travis Athougies iammisc@gmail.com 2010-11-07 03:52:42 CST --- gcc 4.5 vanilla seems to fix the problem, without using this ugly hack.
http://bugs.winehq.org/show_bug.cgi?id=24754
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |RandomAccountName@mail.com
--- Comment #10 from A Wine user RandomAccountName@mail.com 2010-11-12 10:17:22 CST --- *** Bug 25118 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #11 from Dan Kegel dank@kegel.com 2011-08-03 21:34:10 CDT --- Also affects (unsurprisingly) Nancy Drew Warnings at Waverly Academy's demo.
The four patches don't apply anymore & need updating.
http://bugs.winehq.org/show_bug.cgi?id=24754
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gyebro69@gmail.com
--- Comment #12 from GyB gyebro69@gmail.com 2012-03-23 14:14:34 CDT --- Still present in Wine-1.5.0.
http://bugs.winehq.org/show_bug.cgi?id=24754
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
--- Comment #13 from Austin English austinenglish@gmail.com 2012-08-28 13:20:45 CDT --- *** Bug 31565 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #14 from Andrey Gusev andrey.goosev@gmail.com 2013-10-09 15:43:57 CDT --- Created attachment 46246 --> http://bugs.winehq.org/attachment.cgi?id=46246 log on 1.7.3
Still present.
http://bugs.winehq.org/show_bug.cgi?id=24754
Andrey Gusev andrey.goosev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andrey.goosev@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=24754
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Summary|Nancy Drew "Tale of the |Multiple games have no text |Twister" demo text not |rendered due to |rendered |ID3DXFont::DrawTextA/W | |method stubs (Nancy Drew | |'Tale of the Twister', | |Europa Universalis Rome)
--- Comment #15 from Anastasius Focht focht@gmx.net --- Hello folks,
refining summary as this affect a lot of games, targeting specific stub.
Another game: 'Europa Universalis Rome' demo
Download: http://www.gamershell.com/download_24442.shtml
--- snip --- $ pwd /home/focht/.wine/drive_c/Program Files/Paradox Interactive/Rome - Demo
$ wine ./Rome.exe ... fixme:d3dx:ID3DXFontImpl_DrawTextA iface 0xbe012b0, sprite 0xbe011f0, string "Loading Map-Sprites...", count 22, rect (0,660)-(1024,760), format 0x115, color 0xffffffff stub! ... --- snip ---
MSDN: http://msdn.microsoft.com/en-us/library/windows/desktop/bb173962%28v=vs.85%2...
Source: http://source.winehq.org/git/wine.git/blob/7d1fa526e6b5e6588c819af7a4aa6f73e...
--- snip --- 179 static INT WINAPI ID3DXFontImpl_DrawTextA(ID3DXFont *iface, ID3DXSprite *sprite, 180 const char *string, INT count, RECT *rect, DWORD format, D3DCOLOR color) 181 { 182 FIXME("iface %p, sprite %p, string %s, count %d, rect %s, format %#x, color 0x%08x stub!\n", 183 iface, sprite, debugstr_a(string), count, wine_dbgstr_rect(rect), format, color); 184 return 1; 185 } 186 187 static INT WINAPI ID3DXFontImpl_DrawTextW(ID3DXFont *iface, ID3DXSprite *sprite, 188 const WCHAR *string, INT count, RECT *rect, DWORD format, D3DCOLOR color) 189 { 190 FIXME("iface %p, sprite %p, string %s, count %d, rect %s, format %#x, color 0x%08x stub!\n", 191 iface, sprite, debugstr_w(string), count, wine_dbgstr_rect(rect), format, color); 192 return 1; 193 } --- snip ---
'winetricks d3dx9_36' works around and the text is rendered.
$ sha1sum Rome_Demo.exe 57e1fc8f2a1b8eeb0a1ccff218010eb828b00159 Rome_Demo.exe
$ du -sh Rome_Demo.exe 308M Rome_Demo.exe
$ wine --version wine-1.7.13-100-gfcae016
Regards
https://bugs.winehq.org/show_bug.cgi?id=24754
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xvachon@gmail.com
--- Comment #16 from Austin English austinenglish@gmail.com --- *** Bug 26136 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=24754
Jarkko K jarkko_korpi@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jarkko_korpi@hotmail.com
--- Comment #17 from Jarkko K jarkko_korpi@hotmail.com --- Pride of Nations (demo) https://bugs.winehq.org/show_bug.cgi?id=27629
debug is full of DrawTextA lines.
http://bugs.winehq.org/show_bug.cgi?id=24754
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
--- Comment #18 from Vincent Povirk madewokherd@gmail.com --- *** Bug 36158 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=24754
hildalev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hildalev@gmail.com
--- Comment #19 from hildalev@gmail.com --- Tried winetricks d3dx9_36 on Nancy Drew: Warmings at Waverly Academy on wine 1.7.18, but the game crashes before opening. Does the 2d patch work on 1.7?
https://bugs.winehq.org/show_bug.cgi?id=24754
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
--- Comment #20 from Sebastian Lackner sebastian@fds-team.de --- Wine Staging now contains a patch by Christian Costa, which implements the missing DrawText functions. See: https://github.com/wine-compholio/wine-staging/tree/master/patches/d3dx9_36-...
We tested with a couple of games it seems to fix the issue - nevertheless, some more feedback would be appreciated, especially if it doesn't work for a specific game.
https://bugs.winehq.org/show_bug.cgi?id=24754
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #21 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Created attachment 50354 --> https://bugs.winehq.org/attachment.cgi?id=50354 Stronghold Kingdoms
I tested with Stronghold kingdom.
The patch works, sort of, but the text is off to the left.
https://bugs.winehq.org/show_bug.cgi?id=24754
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #22 from Sebastian Lackner sebastian@fds-team.de --- Could you please test again, a second patch was added to fix the handling of centered text.
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #23 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to Sebastian Lackner from comment #22)
Could you please test again, a second patch was added to fix the handling of centered text.
The text now appears in the correct place.
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #24 from Andrey Gusev andrey.goosev@gmail.com --- *** Bug 34520 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=24754
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #25 from joaopa jeremielapuree@yahoo.fr --- @Sebastian: Do you plan to send Chritian's patches to Wine?
https://bugs.winehq.org/show_bug.cgi?id=24754
Christian Costa titan.costa@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |titan.costa@gmail.com
--- Comment #26 from Christian Costa titan.costa@gmail.com --- @joaopa: The patches can't be upstream right now as my implementation was intended to be as simple as possible. A more complete approach will be needed to go upstream. Tony Wasserka did a more complete implementation many years ago but it was not accepted upstream. I can work on it if someone gives me some clue as I don't have time to submit every possible solutions until magically finding the right one.
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #27 from joaopa jeremielapuree@yahoo.fr --- Christian > Do you know the reasons Tony's patches were not commited?
Design or formatting problems problems?
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #28 from Christian Costa titan.costa@gmail.com --- @joapoa: iirc there were some code duplicated from the gdi DrawText function. There was no clue of how a better approach would be.
https://bugs.winehq.org/show_bug.cgi?id=24754
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/d3dx9_36-DrawT | |ext
https://bugs.winehq.org/show_bug.cgi?id=24754
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=24754
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |isakov-sl@bk.ru
--- Comment #29 from Józef Kucia joseph.kucia@gmail.com --- *** Bug 40327 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=24754
Paul Gofman gofmanp@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #30 from Sergey Isakov isakov-sl@bk.ru --- (In reply to Sebastian Lackner from comment #20)
Wine Staging now contains a patch by Christian Costa, which implements the missing DrawText functions. See: https://github.com/wine-compholio/wine-staging/tree/master/patches/d3dx9_36- DrawText
We tested with a couple of games it seems to fix the issue - nevertheless, some more feedback would be appreciated, especially if it doesn't work for a specific game.
d3dx9_36 is not full solution, native or built with this patch as I noted in bug 40327. With native library I see broken text while with wine-staging I see good text. Font replacing does matter? Or "gdi32-Lazy_Font_Initialization"?
https://bugs.winehq.org/show_bug.cgi?id=24754
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kvero1@u.brockport.edu
--- Comment #31 from Matteo Bruni matteo.mystral@gmail.com --- *** Bug 42899 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=24754
Andri Möll andri@dot.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andri@dot.ee
https://bugs.winehq.org/show_bug.cgi?id=24754
--- Comment #32 from Andri Möll andri@dot.ee --- If it's of any help, I can confirm Titan Quest Anniversary Edition runs pretty fluently and with text when used with Arch Linux's wine-staging v2.21-1 (built on Wed 22 Nov 2017 04:19:06 AM UTC) whereas the latest WINE v3.0-1 still lacks text.
https://bugs.winehq.org/show_bug.cgi?id=24754
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/d3dx9_36-DrawT |er/patches/d3dx9_36-DrawTex |ext |t
https://bugs.winehq.org/show_bug.cgi?id=24754
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |toddrme2178@gmail.com
--- Comment #33 from Anastasius Focht focht@gmx.net --- *** Bug 26711 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=24754
Artem S. Tashkinov aros@gmx.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34143
https://bugs.winehq.org/show_bug.cgi?id=24754
Andrey Gusev andrey.goosev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |316a8d0ae11ae1a9654bc731d2c | |9dc23febc7a2d Resolution|--- |FIXED Status|STAGED |RESOLVED
--- Comment #34 from Andrey Gusev andrey.goosev@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commit/316a8d0ae11ae1a9654bc731d2c9dc...
https://bugs.winehq.org/show_bug.cgi?id=24754
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #35 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.4.