[Bug 38279] New: Uninitialized src_rect in wined3d/surface.c:cpu_blit_color_fill

https://bugs.winehq.org/show_bug.cgi?id=38279

Bug ID: 38279
           Summary: Uninitialized src_rect in
                    wined3d/surface.c:cpu_blit_color_fill
           Product: Wine
           Version: 1.7.39
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

In procedure cpu_blit_color_fill there is local variable
static const RECT src_rect;
assumed inited by zero?
Then it used as parameter
return surface_cpu_blt(dst_surface, dst_rect, NULL, &src_rect,
            WINEDDBLT_COLORFILL, &BltFx, WINED3D_TEXF_POINT);
And this function explicitly used the pointer
    srcheight = src_rect->bottom - src_rect->top;
    srcwidth = src_rect->right - src_rect->left;

What behavior assumed here?
I found no assingment to this static constant.

[Bug 38279] Uninitialized src_rect in wined3d/surface.c:cpu_blit_color_fill

https://bugs.winehq.org/show_bug.cgi?id=38279

--- Comment #1 from Henri Verbeet  ---
I'm not quite sure what you think the bug is, but static implies zero
initialisation, which is fine because WINEDDBLT_COLORFILL doesn't really use a
source rectangle.

[Bug 38279] Uninitialized src_rect in wined3d/surface.c:cpu_blit_color_fill

https://bugs.winehq.org/show_bug.cgi?id=38279

--- Comment #2 from Sergey Isakov  ---
OK,
if it is normal for src_rect to be zero then let it be.

[Bug 38279] Uninitialized src_rect in wined3d/surface.c:cpu_blit_color_fill

https://bugs.winehq.org/show_bug.cgi?id=38279

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Austin English  ---
(In reply to Sergey Isakov from comment #2)
> OK,
> if it is normal for src_rect to be zero then let it be.

Invalid.

[Bug 38279] Uninitialized src_rect in wined3d/surface.c:cpu_blit_color_fill

https://bugs.winehq.org/show_bug.cgi?id=38279

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Bruno Jesus  ---
Closing invalid bugs.