[Bug 29894] New: LibreOffice runs out of GDI object handles and crashes on a particular VSD file (err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash)

http://bugs.winehq.org/show_bug.cgi?id=29894

Bug #: 29894
           Summary: LibreOffice runs out of GDI object handles and crashes
                    on a particular VSD file (err:gdi:alloc_gdi_handle out
                    of GDI object handles, expect a crash)
           Product: Wine
           Version: 1.4-rc3
          Platform: x86
               URL: http://download.documentfoundation.org/libreoffice/sta
                    ble/3.5.0/win/x86/LibO_3.5.0_Win_x86_install_multi.msi
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Steps to reproduce:

Install LibreOffice 3.5.0.

Open DNetwork.vsd from
http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=2402...
(Visio 2003 Sample: 20 Sample Diagrams).

followed by:

err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash
err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash
err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash
err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash
err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash
err:seh:raise_exception Unhandled exception code e06d7363 flags 1 addr
0x7b839dd2
Process of pid=0021 has terminated

Even under winedbg I cannot get a backtrace.

If it's desirable I can upload the sample file on http://ompldr.org/

[Bug 29894] LibreOffice runs out of GDI object handles and crashes on a particular VSD file (err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash)

http://bugs.winehq.org/show_bug.cgi?id=29894

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                 CC|                            |[e-mail]

--- Comment #1 from Artem S. Tashkinov  2012-02-14 14:51:57 CST ---
CC'ing Dmitry Timoshkov as he solved a similar bug (bug 22256) in the past )))

[Bug 29894] LibreOffice runs out of GDI object handles and crashes on a particular VSD file (err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash)

http://bugs.winehq.org/show_bug.cgi?id=29894

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdi32                       |-unknown

--- Comment #2 from Artem S. Tashkinov  2012-02-14 14:53:33 CST ---
Actually I don't know what's the faulty component here.

[Bug 29894] LibreOffice runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |
          Component|-unknown                    |gdiplus
            Summary|LibreOffice runs out of GDI |LibreOffice runs out of GDI
                   |object handles and crashes  |object handles and crashes
                   |on a particular VSD file    |on a particular VSD file
                   |(err:gdi:alloc_gdi_handle   |
                   |out of GDI object handles,  |
                   |expect a crash)             |
           Severity|normal                      |minor

--- Comment #3 from Dmitry Timoshkov  2012-02-14 22:11:59 CST ---
'winetricks gdiplus' is a workaround.

[Bug 29894] LibreOffice runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #4 from Dmitry Timoshkov  2012-02-15 01:09:20 CST ---
The problem is that the application leaks an object created with
GdipCreateSolidFill(), and built-in gdiplus always creates a GDI brush
for such an object. Most likely native gdiplus creates a GDI brush only
when needed.

Artem, you may want to report this leak to LibreOffice developers, but it's
also a valid Wine bug.

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|LibreOffice runs out of GDI |LibreOffice: sdraw.exe runs
                   |object handles and crashes  |out of GDI object handles
                   |on a particular VSD file    |and crashes on a particular
                   |                            |VSD file

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #5 from Artem S. Tashkinov  2012-02-15 01:18:56 CST ---
(In reply to comment #4)
> The problem is that the application leaks an object created with
> GdipCreateSolidFill(), and built-in gdiplus always creates a GDI brush
> for such an object. Most likely native gdiplus creates a GDI brush only
> when needed.
>
> Artem, you may want to report this leak to LibreOffice developers, but it's
> also a valid Wine bug.

I once filed a bug report against OpenOffice two years ago (it's still not
solved). Zero comments, nothing, no activity. I guess I will refrain from
waisting my time again.

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Dmitry Timoshkov  2012-02-15 01:49:15 CST ---
The following patch makes it work for me:
http://www.winehq.org/pipermail/wine-patches/2012-February/111591.html

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #7 from Dmitry Timoshkov  2012-02-15 02:38:24 CST ---
(In reply to comment #5)
> (In reply to comment #4)
> > The problem is that the application leaks an object created with
> > GdipCreateSolidFill(), and built-in gdiplus always creates a GDI brush
> > for such an object. Most likely native gdiplus creates a GDI brush only
> > when needed.
> >
> > Artem, you may want to report this leak to LibreOffice developers, but it's
> > also a valid Wine bug.
>
> I once filed a bug report against OpenOffice two years ago (it's still not
> solved). Zero comments, nothing, no activity. I guess I will refrain from
> waisting my time again.

You may try anyway since you are using that application. It leaks lots of
memory, so that's quite serious problem.

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #8 from Nikolay Sivov  2012-02-15 07:37:06 CST ---
(In reply to comment #4)
> The problem is that the application leaks an object created with
> GdipCreateSolidFill(), and built-in gdiplus always creates a GDI brush
> for such an object. Most likely native gdiplus creates a GDI brush only
> when needed.

You mean they never delete gdiplus brushes?

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Dan Kegel  2012-02-15 07:38:19 CST ---
Aw, a leak is a juicy kind of bug someone might well eventually fix
during some future sweep, please do file it at https://bugs.freedesktop.org

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #10 from Dmitry Timoshkov  2012-02-15 07:40:51 CST ---
(In reply to comment #8)
> (In reply to comment #4)
> > The problem is that the application leaks an object created with
> > GdipCreateSolidFill(), and built-in gdiplus always creates a GDI brush
> > for such an object. Most likely native gdiplus creates a GDI brush only
> > when needed.
>
> You mean they never delete gdiplus brushes?

They do, sometimes :)

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #11 from Dmitry Timoshkov  2012-02-29 01:33:30 CST ---
I sent a more complete version of the patch for review:
http://www.winehq.org/pipermail/wine-devel/2012-February/094466.html

LibreOffice opens and displays all the sample files with this patch for me,
Artem, could you please test it as well?

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #12 from Dmitry Timoshkov  2012-02-29 22:25:03 CST ---
Sent to wine-patches as
http://www.winehq.org/pipermail/wine-patches/2012-February/111934.html

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0d7bc4b325de1788dc2643ac84d
                   |                            |5579bed82d562
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Dmitry Timoshkov  2012-03-09 17:36:14 CST ---
Should be fixed now.

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

--- Comment #14 from Alexandre Julliard  2012-03-16 14:09:27 CDT ---
Closing bugs fixed in 1.5.0.

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  2012-03-16 17:11:44 CDT ---
Really closing bugs fixed in 1.5.0.

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 29894] LibreOffice: sdraw.exe runs out of GDI object handles and crashes on a particular VSD file

http://bugs.winehq.org/show_bug.cgi?id=29894

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---