[Bug 26880] New: menubuilder fails to extract icon for SimCity 3000 Unlimited's Scenario Creator
http://bugs.winehq.org/show_bug.cgi?id=26880
Summary: menubuilder fails to extract icon for SimCity 3000 Unlimited's Scenario Creator Product: Wine Version: 1.3.18 Platform: x86-64 OS/Version: Linux Status: NEW Keywords: integration Severity: trivial Priority: P5 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: kennybobs@o2.co.uk
Created an attachment (id=34272) --> (http://bugs.winehq.org/attachment.cgi?id=34272) Wine 1.3.18 +menubuilder
menubuilder fails to extract icon for SimCity 3000 Unlimited's Scenario Creator
trace:menubuilder:extract_icon path=[L"C:\Program Files\Maxis\SimCity 3000 Unlimited\Apps\ScenarioCreator\SimCity Scenario Creator.ico"] index=0 destFilename=[(null)] warn:menubuilder:open_module_icon LoadLibraryExW (L"C:\Program Files\Maxis\SimCity 3000 Unlimited\Apps\ScenarioCreator\SimCity Scenario Creator.ico") failed, error 193 warn:menubuilder:read_ico_direntries Invalid ico file format (hr=0x00000000, bytesRead=6) warn:menubuilder:extract_icon writing icon failed, error 0x80004005 err:menubuilder:InvokeShellLinker failed to extract icon from L"C:\Program Files\Maxis\SimCity 3000 Unlimited\Apps\ScenarioCreator\SimCity Scenario Creator.ico"
eog has no problem reading the file.
$file SimCity\ Scenario\ Creator.ico SimCity Scenario Creator.ico: PC bitmap, Windows 3.x format, 32 x 32 x 8
http://bugs.winehq.org/show_bug.cgi?id=26880
Damjan Jovanovic damjan.jov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |damjan.jov@gmail.com
--- Comment #1 from Damjan Jovanovic damjan.jov@gmail.com 2011-06-05 03:27:02 CDT --- That icon uses a non-standard idType or idReserved.
Please attach the output of:
od -t x1 -N 6 "~/.wine/drive_c/Program Files/Maxis/SimCity 3000 Unlimited/Apps/ScenarioCreator/SimCity Scenario Creator.ico"
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #2 from Ken Sharp kennybobs@o2.co.uk 2011-06-06 17:33:05 CDT --- 0000000 42 4d 34 08 00 00 0000006
as requested.
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #3 from Damjan Jovanovic damjan.jov@gmail.com 2011-06-07 02:37:42 CDT --- (In reply to comment #2)
0000000 42 4d 34 08 00 00 0000006
as requested.
idReserved = 0x4d42, should be 0 but maybe Windows ignores it idType = 0x0834, should be 1 or 2 but maybe Windows ignores it idCount = 0x0000, gives icon count that follows, must be >= 1
Even if idReserved and idType don't matter, a zero idCount should make the entire icon unusable. Are you sure you ran that command on the right file? Can you please attach it or email it to me?
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #4 from Ken Sharp kennybobs@o2.co.uk 2011-06-07 07:28:49 CDT --- Yes it's the correct icon. I have emailed the .ico to you as I don't want to attach it for copyright reasons.
Windows XP and 7 is fine with it, for some reason.
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru 2011-06-07 08:24:21 CDT --- (In reply to comment #3)
(In reply to comment #2)
0000000 42 4d 34 08 00 00 0000006
as requested.
idReserved = 0x4d42, should be 0 but maybe Windows ignores it idType = 0x0834, should be 1 or 2 but maybe Windows ignores it idCount = 0x0000, gives icon count that follows, must be >= 1
Probably that's a BMP file signature, 'BM' == 0x4d42.
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #6 from Ken Sharp kennybobs@o2.co.uk 2011-06-07 09:41:37 CDT ---
From comment 0:
$file SimCity\ Scenario\ Creator.ico SimCity Scenario Creator.ico: PC bitmap, Windows 3.x format, 32 x 32 x 8
http://bugs.winehq.org/show_bug.cgi?id=26880
Damjan Jovanovic damjan.jov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |programs
--- Comment #7 from Damjan Jovanovic damjan.jov@gmail.com 2011-06-16 03:24:37 CDT --- Tests on Windows show that .BMP files with DIB header size 40 (ie. BITMAPINFOHEADER) and .LNK nIndex of exactly 0 will generate a thumbnail icon for .LNK files. But .BMP files with BITMAPV4HEADER won't, and .PNG files won't.
I'll write a patch.
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #8 from Damjan Jovanovic damjan.jov@gmail.com 2011-06-16 04:23:05 CDT --- My patch was almost finished, then I realized that Windowscodecs cannot convert BMP files to ICO files :-(. So I am waiting for that feature in bug 27499 before I can continue.
http://bugs.winehq.org/show_bug.cgi?id=26880
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27499
http://bugs.winehq.org/show_bug.cgi?id=26880
Bug 26880 depends on bug 27499, which changed state.
Bug 27499 Summary: Please add a WICIcoEncoder http://bugs.winehq.org/show_bug.cgi?id=27499
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #9 from Ken Sharp kennybobs@o2.co.uk 2011-10-10 19:32:07 CDT --- Bug 27499 is a WONTFIX, where does that leave this bug?
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #10 from Damjan Jovanovic damjan.jov@gmail.com 2011-10-11 00:17:14 CDT --- I'll have to do the conversion in winemenubuilder internally. But first I want to write a thorough set of tests to see which Windows APIs can take BMPs in place of ICOs.
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #11 from Ken Sharp kennybobs@o2.co.uk 2012-11-09 07:37:05 CST --- Still present in wine-1.5.16-286-g3e264ce
http://bugs.winehq.org/show_bug.cgi?id=26880
Per Johansson per@morth.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |per@morth.org
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #12 from Ken Sharp kennybobs@o2.co.uk 2013-03-24 08:25:21 CDT --- Still present in Wine 1.5.26.
http://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #13 from Ken Sharp imwellcushtymelike@gmail.com --- Still present in wine-1.7.10-191-g8953c74
https://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #14 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.37 or newer) wine? If so, please attach the terminal output in 1.7.37 (see http://wiki.winehq.org/FAQ#get_log).
https://bugs.winehq.org/show_bug.cgi?id=26880
--- Comment #15 from Ken Sharp imwellcushtymelike@gmail.com --- I've no idea where I've put the disc but there's no reason to assume anything has changed. Will update when I find it.
-
wine-bugs＠winehq.org