[Bug 9795] New: Russian buisens application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Summary: Russian buisens application 1C:Enterprise crashes
           Product: Wine
           Version: 0.9.45.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: wine-gui
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=8233)
 --> (http://bugs.winehq.org/attachment.cgi?id=8233)
backtrace

Hello.
Crash:
1) starting program
2) open any MDI-child window -> crash in seconds

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Anton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Russian buisens application |Russian business application
                   |1C:Enterprise crashes       |1C:Enterprise crashes

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #1 from Lei Zhang   2007-10-09 18:16:36 ---
is the application available for download?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #2 from Anton   2007-10-10 11:19:01 ---
no, app is not available for download, even more it protected with hasp-key
(http://aladdin.com)

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|_obsolete_gui               |-unknown

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |obfuscation

--- Comment #3 from Austin English   2008-06-03 15:26:46 ---
Is this still an issue in 1.0-rc3?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Michael Karpukhin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Michael Karpukhin   2008-06-13 02:35:48 ---
Yes, still does not work

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #5 from Austin English   2008-12-11 10:29:53 ---
Is this still an issue in current (1.1.10 or newer) wine?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Michael  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Michael   2009-01-07 03:05:11 ---
> > Problem still persists...

i'va managed to fix it by using native winXP dlls

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #7 from Austin English   2009-07-08 13:25:15 ---
(In reply to comment #6)
> > > Problem still persists...
>
> i'va managed to fix it by using native winXP dlls

Which dlls?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #8 from Michael   2009-07-15 04:51:34 ---
(In reply to comment #7)
> (In reply to comment #6)
> > > > Problem still persists...
> >
> > i'va managed to fix it by using native winXP dlls
>
> Which dlls?

i can't say now, but it was shell32.dll related dlls (if i'm not mistaking)

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #9 from Michael   2009-08-17 06:25:09 ---
I had to play with those dlls:
(native)
commctrl.dll
comctl32.dll
comdlg32.dll
rasapi32.dll
mpr.dll
netapi32.dll
NETBIOS.dll
tapi32.dll
mspwl32.dll
svrapi.dll
msvcrt20.dll

(native then builtin)
shell.dll
shell32.dll
imm32.dll
lzexpand.dll
systhunk.dll
lz32.dll
ver.dll
version.dll

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #10 from Austin English   2010-04-29 18:26:30 ---
This is your friendly reminder  that there has been no bug activity for 6
months. Is this still an issue in current (1.1.43 or newer) wine?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #11 from Pavel   2010-06-22 09:41:03 ---
Created an attachment (id=29067)
 --> (http://bugs.winehq.org/attachment.cgi?id=29067)
reversed native comctl32.dll (maybe undocumented) behavior

native comctl32 send WM_DRAWITEM message to tab childs with pointer to a
DRAWITEMSTRUCT in lParam

if TAB->cbInfo value <= 4 the pointer to value stored by CB_SETITEMDATA it's
replased by Value.

ASSM code:

native comctl32.dll

5D5DF475   |.  837B 30 04    CMP DWORD PTR DS:[EBX+30],4                  ;If
[EBX+30] <= 4 // [EBX+30] <-> tab->CbInfo (OFFSET 0x30)

5D5DF479   |.  8B45 10       MOV EAX,DWORD PTR SS:[EBP+10]          ;

5D5DF47C   |.  77 05         JA SHORT COMCTL32.5D5DF483                 ;

5D5DF47E   |.  8B40 38       MOV EAX,DWORD PTR DS:[EAX+38]          ;  var  =
(DWORD *)TabItem->extra  //( extra OFFSET 0x38)

5D5DF481   |.  EB 03         JMP SHORT COMCTL32.5D5DF486          ;else

5D5DF483   |>  83C0 38       ADD EAX,38                          ;  var  =
TabItem->extra     // ( extra OFFSET 0x38)

5D5DF486   |>  8945 DC       MOV DWORD PTR SS:[EBP-24],EAX          ; itemData
= var;

5D5DF489   |.  8D45 B0       LEA EAX,DWORD PTR SS:[EBP-50]

5D5DF48C   |.  50            PUSH EAX                                     ;
/lParam

5D5DF48D   |.  FF75 1C       PUSH DWORD PTR SS:[EBP+1C]                   ;
|wParam

5D5DF490   |.  6A 2B         PUSH 2B                                      ;
|Message = WM_DRAWITEM

5D5DF492   |.  FF73 04       PUSH DWORD PTR DS:[EBX+4]                    ;
|hWnd

5D5DF495   |.  FF15 CC135B5D CALL DWORD PTR DS:[<&USER32.SendMessageW>]   ;
\SendMessageW

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Pavel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Pavel   2010-06-22 09:48:18 ---
The crash is caused by different behavior of comctl32.dll in windows.
This application (1C:Enterprise) store in tab childs  MDI window index
(0,1,2,3) from Windows Handle array.

but the DRAWITEMSTRUCT under Wine contains Pointer to this value instead.
i.e. attempts to read something like Array[0x987654]  cause a memory error.

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #13 from Nikolay Sivov   2010-06-22 09:51:11 ---
Ok, so you'll be banned from any work on comctl32 now and any existing patches
you have. However you can still provide a test patch for Wine tests that shows
that behaviour.

Does native comctl32 fixes a crash by the way?

P.S. if it's possible, someone with admin rights please wipe out assembly part
from previous comment 11.

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Dan Kegel   2010-06-22 09:57:39 ---
I've been looking, and I can't see any way to edit comments, so I'm
just going to delete the bug.  Whoever is interested can refile the
bug without the assembly.

Pavel, which WineHQ.org pages should we add the "DO NOT USE A DISASSEMBLER
ON MICROSOFT CODE" to so that you would have known not to do that?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |trash

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|trash                       |-unknown

--- Comment #15 from Dan Kegel   2010-06-22 10:22:19 ---
arrgh.  can't delete via the web interface.

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #16 from Pavel   2010-06-23 05:47:20 ---
Oops...

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Pavel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29067|reversed native             |TAB_DrawItemInternal from
        description|comctl32.dll (maybe         |comctl32.dll.so
                   |undocumented) behavior      |undocumented behavior

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Pavel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29067|TAB_DrawItemInternal from   |TAB_DrawItemInterion from
        description|comctl32.dll.so             |comctl32.dll.so suggested
                   |undocumented behavior       |behavior

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Pavel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29067|TAB_DrawItemInterion from   |TAB_DrawItemInterior from
        description|comctl32.dll.so suggested   |comctl32.dll.so suggested
                   |behavior                    |behavior

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #17 from Pavel   2010-06-23 07:59:20 ---
This behavior seems to be documented ...
See: 
owner_drawn_tabs

http://msdn.microsoft.com/en-us/library/bb760550%28VS.85%29.aspx#owner_drawn...
> By default, the itemData member of DRAWITEMSTRUCT contains the value of the >lParam member of the TCITEM structure. However, if you change the amount of >application-defined data per tab, itemData  contains the ADRESS of the data >instead.

And

http://msdn.microsoft.com/en-us/library/bb760554%28v=VS.85%29.aspx
> lParam
>    LPARAM
> Application-defined data associated with the tab control item. If more or >less than 4 bytes of application-defined data exist per tab, an application must >define a structure and use it instead of the TCITEM structure. The first member >of the application-defined structure must be a TCITEMHEADER structure.

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

JuryS  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #19 from Nikolay Sivov  2010-10-11 12:11:14 CDT ---
Actually a tab problem is fixed by f08938c381b2dfadceebfbd657b2e3987c2d1fd1.

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #20 from JuryS  2010-10-11 12:36:07 CDT ---
(In reply to comment #19)
> Actually a tab problem is fixed by f08938c381b2dfadceebfbd657b2e3987c2d1fd1.

Hi! It's a cool. But where we can download this patch ?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #21 from Nikolay Sivov  2010-10-11 12:42:59 CDT ---
(In reply to comment #20)
> (In reply to comment #19)
> > Actually a tab problem is fixed by f08938c381b2dfadceebfbd657b2e3987c2d1fd1.
>
> Hi! It's a cool. But where we can download this patch ?

It's in Wine git repo
(http://source.winehq.org/git/wine.git/?a=commit;h=f08938c381b2dfadceebfbd657...).

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #22 from JuryS  2010-10-11 12:54:35 CDT ---
It's working COOL with patch of tab.c !!!!!!!!!!!

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #23 from JuryS  2010-10-11 12:56:12 CDT ---
There is no more test ! It's working and it's wonderful !!!
I have also some patches for 1C ! How I can input this in WineHQ project ?

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #24 from Nikolay Sivov  2010-10-11 13:02:17 CDT ---
(In reply to comment #23)
> I have also some patches for 1C ! How I can input this in WineHQ project ?

It depends how you got them. Disassembling and deep tracing of native modules
is not allowed, so if you used something that sounds like that - no way to get
it in. If you got some obvious (or not so obvious) fixes with tests for them
read this http://wiki.winehq.org/SubmittingPatches

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #25 from JuryS  2010-10-11 13:16:43 CDT ---
(In reply to comment #24)
> (In reply to comment #23)
> > I have also some patches for 1C ! How I can input this in WineHQ project ?
>
> It depends how you got them. Disassembling and deep tracing of native modules
> is not allowed, so if you used something that sounds like that - no way to get
> it in. If you got some obvious (or not so obvious) fixes with tests for them
> read this http://wiki.winehq.org/SubmittingPatches

For the sample we all see that the MDI windows are very slowly for show. It
very slowly for MS Access, 1C and other.

And here my first patch with user32/mdi.c:

static void MDI_SwitchActiveChild( MDICLIENTINFO *ci, HWND hwndTo, BOOL
activate )
{
    HWND hwndPrev;

hwndPrev = ci->hwndActiveChild;

if ( hwndTo != hwndPrev )
    {
        BOOL was_zoomed = IsZoomed(hwndPrev);

if (was_zoomed)
        {
            ShowWindow( hwndTo, SW_MAXIMIZE );
        }
    }
}

Also I'm have 138 patches like this.

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

--- Comment #26 from Dmitry Timoshkov  2010-10-12 00:20:36 CDT ---
(In reply to comment #25)
> And here my first patch with user32/mdi.c:

1. This is not a patch
2. For guide lines how to send a patch read here:
http://wiki.winehq.org/SubmittingPatches
3. I doubt that 'make test' will pass with your change
4. this is not an appropriate place to post and discuss patches

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|-unknown                    |comctl32
         Resolution|                            |FIXED

--- Comment #27 from Nikolay Sivov  2010-10-12 04:16:03 CDT ---
Control problem fixed anyway.

[Bug 9795] Russian business application 1C:Enterprise crashes

http://bugs.winehq.org/show_bug.cgi?id=9795

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #28 from Alexandre Julliard  2010-10-15 12:50:38 CDT ---
Closing bugs fixed in 1.3.5.