[Bug 31239] New: GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

Bug #: 31239
           Summary: GTAIV lacks some lights
           Product: Wine
           Version: 1.5.9
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: e834c920ec09390a491848a3075eca8f35e3a253

Created attachment 41034
  --> http://bugs.winehq.org/attachment.cgi?id=41034
Screenshot

See the screenshot. Git bisect gives me this:

e834c920ec09390a491848a3075eca8f35e3a253 is the first bad commit
commit e834c920ec09390a491848a3075eca8f35e3a253
Author: Henri Verbeet 
Date:   Tue Jul 17 11:40:38 2012 +0200

wined3d: Introduce a separate function for initializing various limits.

:040000 040000 5c8a144355b561a03b272f50aa083bc391bb4ed7
8e71f83fbbff896e6728005055e47a257d10cf05 M      dlls

My video card is:
05:00.0 VGA compatible controller: NVIDIA Corporation GF104 [GeForce GTX 460]
(rev a1)
with driver version 302.17

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #1 from Ruslan  2012-07-18 06:49:49 CDT ---
Created attachment 41035
  --> http://bugs.winehq.org/attachment.cgi?id=41035
How it should look instead

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #2 from Henri Verbeet  2012-07-18 07:11:26 CDT ---
Is there any output?

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #3 from Ruslan  2012-07-18 07:54:18 CDT ---
No unusual output with unset WINEDEBUG. Here's output from WINEDEBUG=d3d:
http://www.mediafire.com/download.php?ay70115l9wdveoy

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #4 from Henri Verbeet  2012-07-18 11:05:24 CDT ---
I don't see anything particularly unusual in the +d3d log either. Do you know
if this affects any other applications? (Preferably ones with free demos.)

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #5 from Ruslan  2012-07-18 11:41:44 CDT ---
Well, dunno which apps to test. I've tested Lightsmark 2008, Furmark current
and an older version, Unigine Heaven - all they work OK.
What would you suggest to test?

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #6 from Henri Verbeet  2012-07-18 11:47:35 CDT ---
Nothing specific, I was just asking if you were aware of this affecting other
applications. If the commit you found broke something I'd expect it to affect a
fairly large number of applications.

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Austin English  2012-07-18 14:07:50 CDT ---
*** Bug 31243 has been marked as a duplicate of this bug. ***

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #8 from Henri Verbeet  2012-07-18 14:36:16 CDT ---
http://source.winehq.org/patches/data/88422 will probably help with this.

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #9 from Ruslan  2012-07-18 14:41:06 CDT ---
(In reply to comment #8)
Yes, it fixes this

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Henri Verbeet  2012-07-19 05:20:38 CDT ---
*** Bug 31242 has been marked as a duplicate of this bug. ***

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Henri Verbeet  2012-07-19 05:21:08 CDT ---
*** Bug 31253 has been marked as a duplicate of this bug. ***

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

--- Comment #12 from Jonathan Strander  2012-07-19 07:44:10 CDT ---
The patch fixes the same issue in The Witcher 2. (Duplicate Bug 31253)

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f1aea860f9b83e07e24c6e517da
                   |                            |abfb4df7e04c6
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #13 from Wylda  2012-07-19 15:27:17 CDT ---

Based on comment #8 and comment #9, this should be fixed by Henri's today
commit:

http://source.winehq.org/git/wine.git/commit/f1aea860f9b83e07e24c6e517daabfb...

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from GyB  2012-07-21 23:33:47 CDT ---
*** Bug 31277 has been marked as a duplicate of this bug. ***

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from GyB  2012-07-23 10:54:19 CDT ---
*** Bug 31257 has been marked as a duplicate of this bug. ***

[Bug 31239] GTAIV lacks some lights

http://bugs.winehq.org/show_bug.cgi?id=31239

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  2012-07-31 14:20:01 CDT ---
Closing bugs fixed in 1.5.10.